[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#186968: marked as done (mpg321: NMU for Bug#178948 )

Your message dated Tue, 12 Jan 2010 03:20:33 +0000
with message-id <E1NUXJ3-00042W-9N@ries.debian.org>
and subject line Bug#186968: fixed in mpg321 0.2.11-1
has caused the Debian Bug report #186968,
regarding mpg321: NMU for Bug#178948 
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
186968: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=186968
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: mpg321
Version: 0.2.10.1
Severity: normal

I was asked to NMU this package to close 178948.  Here is the patch,
uploaded to DELAYED=7.


diff -ru mpg321-0.2.10.1.prenmu/debian/changelog mpg321-0.2.10.1/debian/changelog
--- mpg321-0.2.10.1.prenmu/debian/changelog	2002-04-04 06:13:27.000000000 +0200
+++ mpg321-0.2.10.1/debian/changelog	2003-03-31 10:57:36.000000000 +0200
@@ -1,3 +1,10 @@
+mpg321 (0.2.10.1-1.1) unstable; urgency=low
+
+  * NMU
+  * Apply patch to close fd (Closes: Bug#178948)
+
+ -- Mario Lang <mlang@debian.org>  Mon, 31 Mar 2003 10:56:12 +0200
+
 mpg321 (0.2.10.1) unstable; urgency=low
 
   * Check both for file existing and link existing in fix-mistake code in
diff -ru mpg321-0.2.10.1.prenmu/mpg321.c mpg321-0.2.10.1/mpg321.c
--- mpg321-0.2.10.1.prenmu/mpg321.c	2002-03-24 06:49:20.000000000 +0100
+++ mpg321-0.2.10.1/mpg321.c	2003-03-31 10:54:48.000000000 +0200
@@ -410,12 +410,14 @@
             
             if(fstat(fd, &stat) == -1)
             {
+                close(fd);
                 mpg321_error(currentfile);
                 continue;
             }
             
             if (!S_ISREG(stat.st_mode))
             {
+                close(fd);
                 continue;
             }
             
@@ -432,10 +434,12 @@
             if((playbuf.buf = mmap(0, playbuf.length, PROT_READ, MAP_SHARED, fd, 0))
                                 == MAP_FAILED)
             {
+                close(fd);
                 mpg321_error(currentfile);
                 continue;
             }
             
+            close(fd);
             playbuf.frames[0] = playbuf.buf;
             
             mad_decoder_init(&decoder, &playbuf, read_from_mmap, read_header, /*filter*/0,

-- 
CYa,
  Mario | Debian Developer <URL:http://debian.org/>
        | Get my public key via finger mlang@db.debian.org
        | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44

--- End Message ---
--- Begin Message --- 
Source: mpg321
Source-Version: 0.2.11-1

We believe that the bug you reported is fixed in the latest version of
mpg321, which is due to be installed in the Debian FTP archive:

mpg321_0.2.11-1.diff.gz
  to main/m/mpg321/mpg321_0.2.11-1.diff.gz
mpg321_0.2.11-1.dsc
  to main/m/mpg321/mpg321_0.2.11-1.dsc
mpg321_0.2.11-1_i386.deb
  to main/m/mpg321/mpg321_0.2.11-1_i386.deb
mpg321_0.2.11.orig.tar.gz
  to main/m/mpg321/mpg321_0.2.11.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 186968@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nanakos Chrysostomos <nanakos@wired-net.gr> (supplier of updated mpg321 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 11 Jan 2010 19:17:42 +0200
Source: mpg321
Binary: mpg321
Architecture: source i386
Version: 0.2.11-1
Distribution: unstable
Urgency: low
Maintainer: Nanakos Chrysostomos <nanakos@wired-net.gr>
Changed-By: Nanakos Chrysostomos <nanakos@wired-net.gr>
Description: 
 mpg321     - Simple and lighweight command line MP3 player
Closes: 153594 158950 163399 182480 186968 207871 269118 285959 471770
Changes: 
 mpg321 (0.2.11-1) unstable; urgency=low
 .
   * New upstream release.
   * New maintainer (Closes: Bug#471770).
   * Updated S-V to 3.8.3.
   * Added HTTP Proxy support with Basic Authentication mechanism
     from Chrysostomos Nanakos <nanakos@wired-net.gr>.
   * ID3 tags now display on all files when playing a list of files and
     you haven't pressed CTRL-C to switch between them.
   * Make volume scaling work entirely within fixed point. This is the
     way it should have been to begin with.
   * Add patch to support IPv6 from Carlos Jesus Bernandos Cano.
     This is now the default in the Debian packages.
     (Closes: Bug#182480).
   * Fix up maintainer scripts to not quit on unknown arguments.
   * Add GAIN option to remote control mode.
     Patch from Ralf Engels <ralf-engels@gmx.de>.
   * Improve shuffling/randomizing code. Patch from Bas Zoetekouw - thanks!
     (Closes: Bug#153594).
   * Moritz Jodeit <moritz@jodeit.org>:
      * Make http://some.server.name (no trailing slash) work.
      * Fix other networking issues.
      * Fix some format string issues.
   * Change use of random() to rand() because random() on Solaris
     doesn't return up to RAND_MAX, but 2**31.
   * Add patch from Mario <diverses@univecom.ch> to better
     support HTTP and Shoutcast streams.
 .
   * Nanakos Chrysostomos <nanakos@wired-net.gr>:
      * Run autoreconf to update the buildsystem to
        current versions of autotools.
      * [debian/ruls] Use dh_installman instead of dh_installmanpages
      * Add debian/mime and call dh_installmime.
        (Closes: Bug#207871).
      * Use ifneq and not ifeq to set options for INSTALL when
        DEB_BUILD_OPTIONS has nostrip.
        (Closes: Bug#163399).
      * Acknowledge NMU (Thanks Mario Lang).
        (Closes: Bug#186968).
      * Print the current frame number of the current file when playing
        multiple files in verbose mode. Patch from Piotr Sulecki - thanks.
        (Closes: Bug#269118).
      * Patch from Gergely Szasz to fix crash when GAIN is
        set in remote mode without an argument.
      * Add support for winamp playlists.
        (Filter out line with # at the beginning).
        Patch from Manolis Stamatogiannakis.
      * Patch from David G. Andersen to check return value of read and only
        decode the right number of bytes.
      * Fix off-by-one in networking code parsing ftp reply.
      * Add loop option. Patch from Nicolas Bonifas.
        (Closes: Bug#158950).
      * Add output remote mode to distinguish between stopping playback and
        the song finishing. Patch from Nicolas Bonifas.
      * Reinitialise the current playback time when rewinding.
        Another patch from Nicolas Bonifas.
      * Only show the verbose option once in the usage text.
        (Closes: Bug#285959).
      * Add xterm title support.Patch from Chrysostomos Nanakos.
Checksums-Sha1: 
 d17cad1a6e1d0122a9df96d1dfa1a0c5a3f9ad28 1058 mpg321_0.2.11-1.dsc
 0423d94484d428f58e059a5a80ece602ac867cda 137707 mpg321_0.2.11.orig.tar.gz
 1786bd3d2ca0027d2c96702a6ad53d277a01e7f8 9705 mpg321_0.2.11-1.diff.gz
 1c82a71daeac8b30e722705799f3246f4343e11f 39720 mpg321_0.2.11-1_i386.deb
Checksums-Sha256: 
 82c659d0dfd17bfa3bb623cd5e862445a76bcfa353c307b9d30f797990b01d0f 1058 mpg321_0.2.11-1.dsc
 ead969c94de9d4ebbcace8b372b1b99f487b2e8b90f4af22eca39439d5c56995 137707 mpg321_0.2.11.orig.tar.gz
 3818f122779a5a60f86e1ef0474c2954a8813f3f259312864c18f9e3a140725d 9705 mpg321_0.2.11-1.diff.gz
 39be110c98671478a63ba9b29e2acf66fbb3eecd82812c0190b477d7e5ba5983 39720 mpg321_0.2.11-1_i386.deb
Files: 
 7785bc861ef29918d78b7ecc0ba95882 1058 sound optional mpg321_0.2.11-1.dsc
 39783ce4b6cb56ed8668ff9dafb3f388 137707 sound optional mpg321_0.2.11.orig.tar.gz
 9931fb0f7f04b47673ac8830b56be9e3 9705 sound optional mpg321_0.2.11-1.diff.gz
 6f75a39d94096b944d21cced85afc96c 39720 sound optional mpg321_0.2.11-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAktL3ssACgkQ5ItltUs5T34OCQCfVEML0oJafSyXhQfZ3iNUeoRe
qNMAn2HLQQMf1NquCxn6F9uchGKcKzMB
=kdlR
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: