[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#563121: marked as done (dh_installdefoma leads to buggy maintainer scripts)



Your message dated Thu, 31 Dec 2009 13:17:09 +0000
with message-id <E1NQKtp-00021B-4M@ries.debian.org>
and subject line Bug#563121: fixed in defoma 0.11.10-4
has caused the Debian Bug report #563121,
regarding dh_installdefoma leads to buggy maintainer scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
563121: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563121
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: defoma
Version: 0.11.10-3
Severity: grave
Justification: Fucks up fontconfig (at least), then buildds.

Hi,

dh_installdefoma leads to this kind of code in maintainer scripts:
  test -x `which foo` && foo bar baz

The trick being that if foo isn't found by which, “foo bar baz” gets
executed, leading to broken packages (see fontconfig's #559136 and
#560252 for examples).

A pair of quotes would fix this:
| kibi@finzi:~$ test -x `which foo` && foo bar baz
| -bash: foo: command not found
| kibi@finzi:~$ test -x "`which foo`" && foo bar baz
| kibi@finzi:~$ 

I'm about to QA-upload defoma with this change in the various
debhelper-files/* files, but I wanted to open this bugreport for
reference.

Cc'ing defoma folks and buildd folks, since they might be interested in
knowing about this.

Mraw,
KiBi.



--- End Message ---
--- Begin Message ---
Source: defoma
Source-Version: 0.11.10-4

We believe that the bug you reported is fixed in the latest version of
defoma, which is due to be installed in the Debian FTP archive:

defoma-doc_0.11.10-4_all.deb
  to main/d/defoma/defoma-doc_0.11.10-4_all.deb
defoma_0.11.10-4.dsc
  to main/d/defoma/defoma_0.11.10-4.dsc
defoma_0.11.10-4.tar.gz
  to main/d/defoma/defoma_0.11.10-4.tar.gz
defoma_0.11.10-4_all.deb
  to main/d/defoma/defoma_0.11.10-4_all.deb
psfontmgr_0.11.10-4_all.deb
  to main/d/defoma/psfontmgr_0.11.10-4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 563121@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated defoma package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 31 Dec 2009 13:16:08 +0100
Source: defoma
Binary: defoma defoma-doc psfontmgr
Architecture: source all
Version: 0.11.10-4
Distribution: unstable
Urgency: high
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description: 
 defoma     - Debian Font Manager -- automatic font configuration framework
 defoma-doc - Debian Font Manager documentation
 psfontmgr  - PostScript font manager -- part of Defoma, Debian Font Manager
Closes: 563121
Changes: 
 defoma (0.11.10-4) unstable; urgency=high
 .
   * QA upload.
   * Fix dh_installdefoma: Use “if [ -x "`which foo 2>/dev/null`" ]”
     instead of test -x `which foo` since test -x without parameter
     succeeds, leading to the execution of the next command, breaking
     maintainer scripts (Closes: #563121).
   * Set urgency to “high” accordingly.
   * Introduce ${misc:Depends} for all binary packages.
Checksums-Sha1: 
 3dbab671b6d6166583d3ed68cf85b566ecd9795f 775 defoma_0.11.10-4.dsc
 e467ce997a4ba3c9696535b473f0af9ff6888074 149111 defoma_0.11.10-4.tar.gz
 251166bfcaa0f6b680992cfc6a428330a135e1dd 100918 defoma_0.11.10-4_all.deb
 4554d46e4332311b9465f605a8a91a141d9d99e3 64112 defoma-doc_0.11.10-4_all.deb
 8bd138d4c5970fe68888cc750d7bfce071e45ef9 22718 psfontmgr_0.11.10-4_all.deb
Checksums-Sha256: 
 072ec5a98af059b318df3301bc38c382e6db2d7ebf540f4963fce16ccace97b2 775 defoma_0.11.10-4.dsc
 b8b3fa4090f555f2609dfc02b292450f874aa660b5296579da816050189aa800 149111 defoma_0.11.10-4.tar.gz
 a2121f1d86ac5ce85f24cc3cf5964dfced650adbc33ebb8f7abdabe06603fb1f 100918 defoma_0.11.10-4_all.deb
 6dc6391489aa0170f072d3167e51b1f9881ccf9849a136ebc5b50df737d539a5 64112 defoma-doc_0.11.10-4_all.deb
 41933990cf409c3adc0ba7c60bc84841954816fb8695c8472aea26a8de8a77fb 22718 psfontmgr_0.11.10-4_all.deb
Files: 
 b367887769d9d0ab33291ab3a7ab1dc8 775 admin optional defoma_0.11.10-4.dsc
 796c9305e4fcdc0bac09e6dad31b6e41 149111 admin optional defoma_0.11.10-4.tar.gz
 f7ed144e156aa4ab9d88506111fa885c 100918 admin optional defoma_0.11.10-4_all.deb
 4a8ef2b1c608eb39359b60e16ac02681 64112 doc optional defoma-doc_0.11.10-4_all.deb
 9d150790fc6911634b0cf0871971a653 22718 admin optional psfontmgr_0.11.10-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAks8oLcACgkQeGfVPHR5Nd1V5wCg0NgEpAdryhnE+dKL1dnZKdGd
8HQAnRH27lezq4ZGyoYS6N4EmeirLKM/
=iHfc
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: