Bug#559422: egroupware: Timesheet user filter doesn't work right userId >= 2000 - error in core accounts->members method?
Package: egroupware
Version: 1.6.002+dfsg-1~bpo50+1
Severity: normal
Tags: patch
Our setup has some users with low Ids (in 1-20 range) and some others with high Ids (>=2000), due to a migration to LDAP.
User filtering in Timesheet list works ok for low Ids, but wrong for high Ids.
It worked well with 1.6.001 .
Issue seems to be the following line timesheet/inc/class.timesheet_ui.inc.php:457:
---
$query['col_filter']['ts_owner'] = array_merge(array($query['col_filter']['ts_owner']),$GLOBALS['egw']->accounts->members($query['col_filter']['ts_owner'],true));
---
Call to account->members seems not to work properly, as our >=2000 ids are users and no groups, but it returns some low-ids...
Changing that line with the following solves the problem:
---
# Do not call account->members for groups (groups have id < 0)
if ($query['col_filter']['ts_owner'] < 0) {
$query['col_filter']['ts_owner'] = array_merge(array($query['col_filter']['ts_owner']),$GLOBALS['egw']->accounts->members($query['col_filter']['ts_owner'],true));
}
---
Anyway, real problem seems to be in account->members method, but this solves the reported problem.
Thanks a lot
Eneko
-- System Information:
Debian Release: 5.0.3
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages egroupware depends on:
ii egroupware-addres 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - addres
ii egroupware-bookma 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - bookma
ii egroupware-calend 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - calend
ii egroupware-core 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - core m
ii egroupware-develo 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - develo
ii egroupware-emaila 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - e-mail
ii egroupware-etempl 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - widget
ii egroupware-felami 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - e-mail
ii egroupware-filema 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - file m
ii egroupware-infolo 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - infolo
ii egroupware-manual 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - manual
ii egroupware-news-a 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - news a
ii egroupware-notifi 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - notifi
ii egroupware-phpbra 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - phpbra
ii egroupware-phpsys 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - phpSys
ii egroupware-polls 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - pollin
ii egroupware-projec 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - projec
ii egroupware-regist 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - regist
ii egroupware-resour 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - resour
ii egroupware-sambaa 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - Samba
ii egroupware-sitemg 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - site m
ii egroupware-timesh 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - timesh
ii egroupware-tracke 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - tracke
ii egroupware-wiki 1.6.002+dfsg-1~bpo50+1 web-based groupware suite - wiki a
egroupware recommends no packages.
egroupware suggests no packages.
-- no debconf information
Reply to: