[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#322207: marked as done (FTBFS on GNU/kFreeBSD)

Your message dated Fri, 28 Aug 2009 13:59:37 +0000
with message-id <E1Mh1zN-0007em-0Q@ries.debian.org>
and subject line Bug#322207: fixed in audiooss 1.0.0-5
has caused the Debian Bug report #322207,
regarding FTBFS on GNU/kFreeBSD
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
322207: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=322207
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: audiooss
Severity: important
Tags: patch

This package fails to build on GNU/kFreeBSD due to some unportable usages of the
OSS interface.

I also spotted a pair of obvious bugs in the package, which I also fixed:

  - audiooss doesn't use X11 (except for imake of course), so it doesn't need to
    link against it.
  - nas-dev is a virtual package.  For the build-dependency is should be
    libaudio-dev | nas-dev.

The attached patch includes a fix for all the above problems.  Please, could you
forward the upstream part to upstream developers?

Thank you very much

-- System Information:
Debian Release: testing/unstable
Architecture: kfreebsd-i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: GNU/kFreeBSD 5.3-17
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)

diff -ur audiooss-1.0.0.old/Imakefile audiooss-1.0.0/Imakefile
--- audiooss-1.0.0.old/Imakefile	2002-03-22 20:38:00.000000000 +0100
+++ audiooss-1.0.0/Imakefile	2005-08-09 20:24:11.000000000 +0200
@@ -62,7 +62,7 @@
  MALLOC_DEFINES = -DMALLOC_0_RETURNS_NULL
 #endif
 
-        DEFINES = $(MALLOC_DEFINES) $(SYSV_DEFINES) -D_REENTRANT -D__REENTRANT -DLINUX_IOCTL
+        DEFINES = $(MALLOC_DEFINES) $(SYSV_DEFINES) -D_REENTRANT -D__REENTRANT
 
 HEADERS = 
 
@@ -76,7 +76,7 @@
 
    OBJS = audiooss.o nasaudio.o
 
-REQUIREDLIBS = -L/usr/X11R6/lib -laudio -lX11 -ldl
+REQUIREDLIBS = -laudio -ldl
 
 #if ProjectX >= 5
 LibraryObjectRule()
diff -ur audiooss-1.0.0.old/audiooss.c audiooss-1.0.0/audiooss.c
--- audiooss-1.0.0.old/audiooss.c	2005-08-09 20:23:51.000000000 +0200
+++ audiooss-1.0.0/audiooss.c	2005-08-09 20:24:29.000000000 +0200
@@ -48,14 +48,15 @@
 
 #define YELL	if (arg == NULL) { DPRINTF("ioctl with argp == NULL, returning -1\n"); errno = EINVAL; return -1; }
 
-#ifdef LINUX_IOCTL
-#include <linux/ioctl.h>
-#endif
+/* Hack to avoid ioctl() declaration */
+#define ioctl __dummy_ioctl
+#include <sys/soundcard.h>
+#undef ioctl
+
 #include <dlfcn.h>
 #include <stdarg.h>
 #include <unistd.h>
 
-#include "soundcard.h"
 #include "nasaudio.h"
 
 typedef struct _nasInfo {
@@ -625,14 +626,30 @@
       errno = EINVAL;
       return -1;
 
+#ifdef SOUND_MIXER_ACCESS
     case SOUND_MIXER_ACCESS:
+#endif
+#ifdef SOUND_MIXER_AGC
     case SOUND_MIXER_AGC:
+#endif
+#ifdef SOUND_MIXER_3DSE
     case SOUND_MIXER_3DSE:
+#endif
+#ifdef SOUND_MIXER_PRIVATE1
     case SOUND_MIXER_PRIVATE1:
+#endif
+#ifdef SOUND_MIXER_PRIVATE2
     case SOUND_MIXER_PRIVATE2:
+#endif
+#ifdef SOUND_MIXER_PRIVATE3
     case SOUND_MIXER_PRIVATE3:
+#endif
+#ifdef SOUND_MIXER_PRIVATE4
     case SOUND_MIXER_PRIVATE4:
+#endif
+#ifdef SOUND_MIXER_PRIVATE5
     case SOUND_MIXER_PRIVATE5:
+#endif
       DPRINTF("MIXER: sound_mixer r/w obscure ioctl %x\n", request);
       errno = EINVAL;
       return -1;
diff -ur audiooss-1.0.0.old/debian/control audiooss-1.0.0/debian/control
--- audiooss-1.0.0.old/debian/control	2005-08-09 20:23:51.000000000 +0200
+++ audiooss-1.0.0/debian/control	2005-08-09 20:24:11.000000000 +0200
@@ -2,7 +2,7 @@
 Section: sound
 Priority: optional
 Maintainer: Lex Spoon <lex@debian.org>
-Build-Depends: debhelper (>> 3.0.0), nas-dev, xlibs-dev, xutils
+Build-Depends: debhelper (>> 3.0.0), libaudio-dev | nas-dev, xutils
 Standards-Version: 3.5.2
 
 Package: audiooss

--- End Message ---
--- Begin Message --- 
Source: audiooss
Source-Version: 1.0.0-5

We believe that the bug you reported is fixed in the latest version of
audiooss, which is due to be installed in the Debian FTP archive:

audiooss_1.0.0-5.diff.gz
  to pool/main/a/audiooss/audiooss_1.0.0-5.diff.gz
audiooss_1.0.0-5.dsc
  to pool/main/a/audiooss/audiooss_1.0.0-5.dsc
audiooss_1.0.0-5_amd64.deb
  to pool/main/a/audiooss/audiooss_1.0.0-5_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 322207@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated audiooss package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 28 Aug 2009 15:28:07 +0200
Source: audiooss
Binary: audiooss
Architecture: source amd64
Version: 1.0.0-5
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description: 
 audiooss   - transparent OSS emulation over NAS
Closes: 322207
Changes: 
 audiooss (1.0.0-5) unstable; urgency=low
 .
   * QA upload.
   * Fix FTBFS on GNU/kFreeBSD by including the patch by Robert Millan
     (Closes: #322207):
      - Fix DEFINES and REQUIREDLIBS variables.
      - Make soundcard-related stuff generic instead of Linux-only.
      - Tweak Build-Depends to have libaudio-dev as (primary) alternative
        to nas-dev, which is a virtual package.
   * Use UTF-8 encoding for debian/copyright.
Checksums-Sha1: 
 84482afc6a0ac7c21c848efcd483378c6c9e68b8 1005 audiooss_1.0.0-5.dsc
 6e4d0157a48dcb50b28580c4088adb50c19b9675 7336 audiooss_1.0.0-5.diff.gz
 a48f878eb2907a006f402b5ba4ff277e04219376 18678 audiooss_1.0.0-5_amd64.deb
Checksums-Sha256: 
 2e2c63d5000f600bbb26b59acc1d91bf13e14d6ba67331fd6641f59a46d5f1be 1005 audiooss_1.0.0-5.dsc
 b30c2da44d774811ced8f79095bd2f8b53e9119a0774a7b97afd73a30fc7e496 7336 audiooss_1.0.0-5.diff.gz
 e504550bca0bc15ff37115f86057ea55df66c6f188741191cfb82d2c7b516c65 18678 audiooss_1.0.0-5_amd64.deb
Files: 
 5cdfe505001286abbad101cea2b23a87 1005 sound optional audiooss_1.0.0-5.dsc
 1e5723a0c867c113fdbd6fc3615e6524 7336 sound optional audiooss_1.0.0-5.diff.gz
 9969dc2d82a245f6a0933fd5267b0f53 18678 sound optional audiooss_1.0.0-5_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqX4JIACgkQeGfVPHR5Nd0aiQCfXQzOirvS7PqJtu8vmsYD/xHn
EfMAoNZFIM0Sb6mI2/FFrhTcQwCbgwW2
=LSgQ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: