[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#542678: xfs: Incorrect provides and dependencies in init.d script

Package:  xfs
Version:  1:1.0.4-1
Severity: normal
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The script should run before all *dm
services, and thus should include a header to make sure that happen.
Without it, it can start to late in the boot sequence.  The only of
these script currently depending on xfs is xdm at the moment.  The
others should depend on it too. :)

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Setting severity to normal, as
this only might give a wrong ordering when running makefile style
concurrent booting.

diff -ur xfs-1.0.8/debian/xfs.init xfs-1.0.8-pere/debian/xfs.init
--- xfs-1.0.8/debian/xfs.init   2009-08-20 21:11:00.000000000 +0200
+++ xfs-1.0.8-pere/debian/xfs.init      2009-08-20 21:12:26.000000000 +0200
@@ -25,6 +25,7 @@
 # Required-Stop:     $local_fs $remote_fs $syslog
 # Should-Start:      $network
 # Should-Stop:       $network
+# X-Start-Before:    gdm kdm xdm ldm sdm
 # Default-Start:     2 3 4 5
 # Default-Stop:      1
 # Short-Description: Start/stop script for the X Font Server.

Happy hacking,
Petter Reinholdtsen

Reply to: