[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#528669: marked as done (init script failing when specter already running or already stopped)

Your message dated Sun, 24 May 2009 15:18:27 +0000
with message-id <E1M8FT1-0003bo-QL@ries.debian.org>
and subject line Bug#528669: fixed in specter 1.4-4
has caused the Debian Bug report #528669,
regarding init script failing when specter already running or already stopped
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
528669: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528669
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: specter
Version: 1.4-3
Severity: normal
Tags: patch

Init script returns a non zero status when called to stop / start an
already stopped / started specter daemon.
This has unexcepted behaviour when trying to restart specter or to
uninstall it when daemon is already stopped.

An example output when trying to remove the package and specter daemon
is already stopped:

The following packages will be REMOVED:
  specter*
0 upgraded, 0 newly installed, 1 to remove and 42 not upgraded.
After this operation, 401kB disk space will be freed.
Do you want to continue [Y/n]? 
(Reading database ... 141013 files and directories currently installed.)
Removing specter ...
Stopping Specter Logging Facility: invoke-rc.d: initscript specter,
action "stop" failed.
dpkg: error processing specter (--purge):
 subprocess pre-removal script returned error exit status 1
Starting Specter Logging Facility: Specter.
Errors were encountered while processing:
 specter
E: Sub-process /usr/bin/dpkg returned an error code (1)


A possible patch could be:

--- specter.orig	2009-05-14 17:21:28.000000000 +0200
+++ specter	2009-05-14 17:26:54.000000000 +0200
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/sh -e
 ### BEGIN INIT INFO
 # Provides:          specter
 # Required-Start:    $remote_fs $syslog
@@ -25,13 +25,23 @@
 case "$1" in
   start)
 	echo -n "Starting $DESC: "
-	start-stop-daemon --start --quiet --exec $DAEMON -- $DAEMON_OPTS
-	echo "$NAME."
+	if start-stop-daemon --stop --quiet --signal 0 --exec $DAEMON
+	then
+		echo "[already running]"
+	else
+		start-stop-daemon --start --quiet --exec $DAEMON -- $DAEMON_OPTS
+		echo "$NAME."
+	fi
 	;;
   stop)
 	echo -n "Stopping $DESC: "
-	start-stop-daemon --stop --quiet --exec $DAEMON
-	echo "$NAME."
+	if start-stop-daemon --stop --quiet --signal 0 --exec $DAEMON
+	then
+		start-stop-daemon --stop --quiet --exec $DAEMON
+		echo "$NAME."
+	else
+		echo "[not running]"
+	fi
 	;;
   reload)
 	 echo "Reloading $DESC configuration files."
@@ -39,15 +49,17 @@
   ;;
   restart|force-reload)
 	echo -n "Restarting $DESC: "
-	start-stop-daemon --stop --quiet --exec $DAEMON
-	sleep 1
+	if start-stop-daemon --stop --quiet --signal 0 --exec $DAEMON
+	then
+		start-stop-daemon --stop --quiet --exec $DAEMON
+		sleep 1
+	fi
 	start-stop-daemon --start --quiet --exec $DAEMON -- $DAEMON_OPTS
 	echo "$NAME."
 	;;
   *)
 	N=/etc/init.d/$NAME
 	echo "Usage: $N {start|stop|restart|reload|force-reload}" >&2
-	#echo "Usage: $N {start|stop|restart|force-reload}" >&2
 	exit 1
 	;;
 esac


-- System Information:
Debian Release: 5.0
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages specter depends on:
ii  adduser                       3.110      add and remove users and groups
ii  iptables                      1.4.2-6    administration tools for packet fi
ii  libc6                         2.9-4      GNU C Library: Shared libraries

specter recommends no packages.

Versions of packages specter suggests:
pn  specter-mysql                 <none>     (no description available)
pn  specter-pgsql                 <none>     (no description available)

-- no debconf information

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: specter
Source-Version: 1.4-4

We believe that the bug you reported is fixed in the latest version of
specter, which is due to be installed in the Debian FTP archive:

specter-mysql_1.4-4_i386.deb
  to pool/main/s/specter/specter-mysql_1.4-4_i386.deb
specter-pgsql_1.4-4_i386.deb
  to pool/main/s/specter/specter-pgsql_1.4-4_i386.deb
specter_1.4-4.diff.gz
  to pool/main/s/specter/specter_1.4-4.diff.gz
specter_1.4-4.dsc
  to pool/main/s/specter/specter_1.4-4.dsc
specter_1.4-4_i386.deb
  to pool/main/s/specter/specter_1.4-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 528669@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Barry deFreese <bdefreese@debian.org> (supplier of updated specter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 24 May 2009 10:24:18 -0400
Source: specter
Binary: specter specter-mysql specter-pgsql
Architecture: source i386
Version: 1.4-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Barry deFreese <bdefreese@debian.org>
Description: 
 specter    - packet logger for netfilter's ULOG target
 specter-mysql - packet logger for netfilter's ULOG target [mySQL]
 specter-pgsql - packet logger for netfilter's ULOG target [PostgreSQL]
Closes: 527532 528669
Changes: 
 specter (1.4-4) unstable; urgency=low
 .
   * QA upload.
   * 03_limits_h.dpatch - Add limits.h for PATH_MAX. (Closes: #527532).
     + Thanks to Peter Green for the fix.
   * debian/specter.init.d - Don't fail when already running or stopped.
     + Thanks to Rémi Laurent for the patch. (Closes: #528669).
   * Add watch file.
   * Bump debhelper build-dep and compat to 5.
   * Bump Standards Version to 3.8.1. (No changes needed).
Checksums-Sha1: 
 4090b373def9eca133acfb094d091c04558e151c 1068 specter_1.4-4.dsc
 de7cd1dd12f0eab29651a0dd64ce1623b8248fae 6502 specter_1.4-4.diff.gz
 911781ec974ccb1511c1283d349e67128b683bfb 98606 specter_1.4-4_i386.deb
 8dfa224687a68d096bb3e510f0b9266e88f04488 5282 specter-mysql_1.4-4_i386.deb
 312b1cdb805496a88168b5e50d7d75c57adf5928 5668 specter-pgsql_1.4-4_i386.deb
Checksums-Sha256: 
 0b4fc603d33890a344983fa46bd6438adca51db4f4d594d8c842f5878a6b9e23 1068 specter_1.4-4.dsc
 db3b751d3f58fa9e78c2a34b9b3cf7e34748f4282c91c41e3f28b55016b50752 6502 specter_1.4-4.diff.gz
 9aefd61a45abc5dd76d0cee7ca392f255ed9cde6c73448cee5e02ef1b23540eb 98606 specter_1.4-4_i386.deb
 53d2f3485c453badd3e78998efb53bf0fafb0bca15e2abf7ddcc420f34fe348c 5282 specter-mysql_1.4-4_i386.deb
 afeb49a056b7fc73d578ddd136e7b92af8d7988eeb37366addb56e3d3890e058 5668 specter-pgsql_1.4-4_i386.deb
Files: 
 c764cd33291fa7f8b882cd464d62ba80 1068 net optional specter_1.4-4.dsc
 44c68bf84839c8ac313a98a4de712b53 6502 net optional specter_1.4-4.diff.gz
 09a30145c670ac493727f86a8b082f8e 98606 net optional specter_1.4-4_i386.deb
 e07789e2c12e960476ce1934e4714068 5282 net optional specter-mysql_1.4-4_i386.deb
 c1fc9390c2cd08d139e1b045264755af 5668 net optional specter-pgsql_1.4-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoZXaMACgkQ5ItltUs5T34hLwCg8d152ByMXttCsRffJZ1L0hoG
n7gAoMIuNlKv+9w5IJMhZShuAkl7znuB
=AK4+
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: