[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#482844: marked as done (hping3: ignores -N (IP ID) command line argument)

Your message dated Sat, 16 May 2009 09:34:27 +0000
with message-id <E1M5GHj-00066S-Ec@ries.debian.org>
and subject line Bug#482844: fixed in hping3 3.a2.ds2-4
has caused the Debian Bug report #482844,
regarding hping3: ignores -N (IP ID) command line argument
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
482844: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482844
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: hping3
Version: 3.a2.ds2-2
Severity: normal
Tags: patch

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages hping3 depends on:
ii  libc6                         2.7-10     GNU C Library: Shared libraries
ii  libpcap0.8                    0.9.8-3    system interface for user-level pa
ii  tcl8.4                        8.4.19-2   Tcl (the Tool Command Language) v8

hping3 recommends no packages.

-- no debconf information

diff -Nru hping3-3.a2.ds2/docs/hping2.8 hping3-3.a2.ds2x/docs/hping2.8
--- hping3-3.a2.ds2/docs/hping2.8	2005-03-12 11:13:11.000000000 +0100
+++ hping3-3.a2.ds2x/docs/hping2.8	2008-05-25 13:48:21.000000000 +0200
@@ -343,7 +343,7 @@
 .I -N --id
 Set ip->id field. Default id is random but if fragmentation is turned on
 and id isn't specified it will be
-.BR "getpid() & 0xFF" ,
+.BR "getpid() & 0xFFFF" ,
 to implement a better solution is in TODO list.
 .TP
 .I -H --ipproto
@@ -714,4 +714,4 @@
 a solaris problem, as stated in the tcpdump-workers mailing list,
 so the libpcap can't do nothing to handle it properly.
 .SH SEE ALSO
-ping(8), traceroute(8), ifconfig(8), nmap(1)
\ No newline at end of file
+ping(8), traceroute(8), ifconfig(8), nmap(1)
diff -Nru hping3-3.a2.ds2/docs/hping3.8 hping3-3.a2.ds2x/docs/hping3.8
--- hping3-3.a2.ds2/docs/hping3.8	2005-03-12 11:13:11.000000000 +0100
+++ hping3-3.a2.ds2x/docs/hping3.8	2008-05-25 13:48:34.000000000 +0200
@@ -352,7 +352,7 @@
 .I -N --id
 Set ip->id field. Default id is random but if fragmentation is turned on
 and id isn't specified it will be
-.BR "getpid() & 0xFF" ,
+.BR "getpid() & 0xFFFF" ,
 to implement a better solution is in TODO list.
 .TP
 .I -H --ipproto
diff -Nru hping3-3.a2.ds2/hping2.h hping3-3.a2.ds2x/hping2.h
--- hping3-3.a2.ds2/hping2.h	2005-03-12 11:13:11.000000000 +0100
+++ hping3-3.a2.ds2x/hping2.h	2008-05-25 12:48:23.000000000 +0200
@@ -121,7 +121,7 @@
 #define DEFAULT_ICMP_IP_IHL		(IPHDR_SIZE >> 2)
 #define	DEFAULT_ICMP_IP_TOS		0
 #define DEFAULT_ICMP_IP_TOT_LEN		0 /* computed by send_icmp_*() */
-#define DEFAULT_ICMP_IP_ID		0 /* rand */
+#define DEFAULT_ICMP_IP_ID		-1 /* rand */
 #define DEFAULT_ICMP_CKSUM		-1 /* -1 means compute the cksum */
 #define DEFAULT_ICMP_IP_PROTOCOL	6 /* TCP */
 #define DEFAULT_RAW_IP_PROTOCOL		6 /* TCP */
diff -Nru hping3-3.a2.ds2/parseoptions.c hping3-3.a2.ds2x/parseoptions.c
--- hping3-3.a2.ds2/parseoptions.c	2005-03-12 11:13:11.000000000 +0100
+++ hping3-3.a2.ds2x/parseoptions.c	2008-05-25 13:16:11.000000000 +0200
@@ -463,6 +463,10 @@
 			break;
 		case OPT_ICMP_IPID:
 			icmp_ip_id = strtol(ago_optarg, NULL, 0);
+			if (icmp_ip_id < 0 || icmp_ip_id > 0xffff) {
+				fprintf(stderr, "Bad ICMP IP ID, resetting to random.\n");
+				icmp_ip_id = DEFAULT_ICMP_IP_ID;
+			}
 			break;
 		case OPT_ICMP_IPPROTO:
 			icmp_ip_protocol = strtol(ago_optarg, NULL, 0);
diff -Nru hping3-3.a2.ds2/sendicmp.c hping3-3.a2.ds2x/sendicmp.c
--- hping3-3.a2.ds2/sendicmp.c	2005-03-12 11:13:11.000000000 +0100
+++ hping3-3.a2.ds2x/sendicmp.c	2008-05-25 13:24:49.000000000 +0200
@@ -83,7 +83,7 @@
 	icmp->type = opt_icmptype;	/* echo replay or echo request */
 	icmp->code = opt_icmpcode;	/* should be indifferent */
 	icmp->checksum = 0;
-	icmp->un.echo.id = getpid() & 0xffff;
+	icmp->un.echo.id = icmp_ip_id == DEFAULT_ICMP_IP_ID ? getpid() & 0xffff : icmp_ip_id;
 	icmp->un.echo.sequence = _icmp_seq;
 
 	/* data */

--- End Message ---
--- Begin Message --- 
Source: hping3
Source-Version: 3.a2.ds2-4

We believe that the bug you reported is fixed in the latest version of
hping3, which is due to be installed in the Debian FTP archive:

hping3_3.a2.ds2-4.diff.gz
  to pool/main/h/hping3/hping3_3.a2.ds2-4.diff.gz
hping3_3.a2.ds2-4.dsc
  to pool/main/h/hping3/hping3_3.a2.ds2-4.dsc
hping3_3.a2.ds2-4_amd64.deb
  to pool/main/h/hping3/hping3_3.a2.ds2-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 482844@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillaume Delacour <gui@iroqwa.org> (supplier of updated hping3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 13 May 2009 16:39:41 +0000
Source: hping3
Binary: hping3
Architecture: source amd64
Version: 3.a2.ds2-4
Distribution: unstable
Urgency: low
Maintainer: Guillaume Delacour <gui@iroqwa.org>
Changed-By: Guillaume Delacour <gui@iroqwa.org>
Description: 
 hping3     - Active Network Smashing Tool
Closes: 482844 522830
Changes: 
 hping3 (3.a2.ds2-4) unstable; urgency=low
 .
   * New maintainer (Closes: #522830)
   * debian/control:
     + Bump Standards-Version to 3.8.1, no changes needed.
   * debian/copyright:
     + /usr/share/common-licenses -> /usr/share/common-licenses/GPL-2
   * debian/patches/80_ip_id_field.diff:
     + Fix -N command line argument (Closes: #482844).
Checksums-Sha1: 
 d8f624bc254fcd8c93ff5383a08c45e348579bc7 1165 hping3_3.a2.ds2-4.dsc
 98100d2ae203d6a72e8d0deb10aecbd39d55cece 9634 hping3_3.a2.ds2-4.diff.gz
 ef410cb24556bec311650fad66579011b34f38b1 100126 hping3_3.a2.ds2-4_amd64.deb
Checksums-Sha256: 
 167906ccb8fa2853ecb6af56c129b83f3a9ae8a50b6d1cfeb626552b21426261 1165 hping3_3.a2.ds2-4.dsc
 003cabbe35203b3ec03862a5fc2088a1002b08b921881b20c09a65242b6b6f3c 9634 hping3_3.a2.ds2-4.diff.gz
 039bc382cd3c440f151c36ede20f91e1e0b6dd38f6a75b588ff2e34a069913f4 100126 hping3_3.a2.ds2-4_amd64.deb
Files: 
 d493e4090ee0b1313ed9f1cca9243407 1165 net extra hping3_3.a2.ds2-4.dsc
 86b10ab42fb7fc55f8726cd92f3191e2 9634 net extra hping3_3.a2.ds2-4.diff.gz
 2347c64b0f27952cec45f42f3e5c2542 100126 net extra hping3_3.a2.ds2-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoOgaIACgkQ5TUK4GCH0vgx0gCgit1EiX+VQAmGYeOtvBWF9u0S
bBkAn2j6ivC/p6MLKt+FfkEButdUow0t
=f3pe
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: