[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#484056: marked as done (ncurses-hexedit: search is not working on 64 bit systems)

Your message dated Mon, 09 Mar 2009 12:17:04 +0000
with message-id <E1LgePo-0002fu-Ie@ries.debian.org>
and subject line Bug#484056: fixed in ncurses-hexedit 0.9.7-14
has caused the Debian Bug report #484056,
regarding ncurses-hexedit: search is not working on 64 bit systems
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

484056: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=484056
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: ncurses-hexedit
Version: 0.9.7-13
Tags: patch

search is not working on 64 bit systems because the function
boyer_moore_search() at search.c incorrectly assumes:
sizeof(int) == sizeof(long)

The code may still have some incoherences in some of the variable
types but the attached patch makes search work again on 64 bit

Maybe the best way to fix it would be to use memmem(3) function from glibc.
--- ncurses-hexedit/src/search.c~	1999-06-27 13:45:29.000000000 +0000
+++ ncurses-hexedit/src/search.c	2008-06-01 22:47:51.000000000 +0000
@@ -39,7 +39,7 @@
    if (!buf)
       return &found;
-   memset (l_table, 0, 256 * sizeof (int));
+   memset (l_table, 0, sizeof (l_table));
    i = 0;
    s = substr + len - 1;
    while (i < len)

--- End Message ---
--- Begin Message ---
Source: ncurses-hexedit
Source-Version: 0.9.7-14

We believe that the bug you reported is fixed in the latest version of
ncurses-hexedit, which is due to be installed in the Debian FTP archive:

  to pool/main/n/ncurses-hexedit/ncurses-hexedit_0.9.7-14.diff.gz
  to pool/main/n/ncurses-hexedit/ncurses-hexedit_0.9.7-14.dsc
  to pool/main/n/ncurses-hexedit/ncurses-hexedit_0.9.7-14_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 484056@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Manfred Lichtenstern <manfred@lichtenstern.biz> (supplier of updated ncurses-hexedit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Wed, 07 Jan 2009 20:03:22 +0100
Source: ncurses-hexedit
Binary: ncurses-hexedit
Architecture: source i386
Version: 0.9.7-14
Distribution: unstable
Urgency: low
Maintainer: Manfred Lichtenstern <manfred@lichtenstern.biz>
Changed-By: Manfred Lichtenstern <manfred@lichtenstern.biz>
 ncurses-hexedit - Edit files/disks in hex, ASCII and EBCDIC
Closes: 419075 484056 510952
 ncurses-hexedit (0.9.7-14) unstable; urgency=low
   * New Maintainer. (Closes: #419075)
   * Added patch from Eduardo Pérez Ureta <edpeur@gmail.com>
     to correct programing error in search.c (Closes: #484056).
   * update docs/hexeditor.1 and remove docs/hexedit.1 (Closes: #510952)
   * Conforms to Standards version 3.8.0
 8a607841fc4275038cd5e34045aed294e8ba3e0a 1058 ncurses-hexedit_0.9.7-14.dsc
 c78f9d842164561c606e097db25181a666b219c6 30317 ncurses-hexedit_0.9.7-14.diff.gz
 c64c51ae43b5a1ba4aa526ad5147b47b11e8c7e8 64732 ncurses-hexedit_0.9.7-14_i386.deb
 d2168b78b1f3c5a61e140f7cc0ead582476ccbd402a7684c68bffb7b65b60afd 1058 ncurses-hexedit_0.9.7-14.dsc
 40cd16005b1f14e1298bc940d8edf150c38c4b4d5222e89f7afe5a810f464f66 30317 ncurses-hexedit_0.9.7-14.diff.gz
 088804e793eee9b06ac0223a7179b8af5e21f0589cc530858ef923187fde5b06 64732 ncurses-hexedit_0.9.7-14_i386.deb
 144254e715186c64c3906cd1342e7ab5 1058 editors optional ncurses-hexedit_0.9.7-14.dsc
 d1f4e1df2e41db992b253a94e8160187 30317 editors optional ncurses-hexedit_0.9.7-14.diff.gz
 5b1c750ff089dc7e14d20c53e742b357 64732 editors optional ncurses-hexedit_0.9.7-14_i386.deb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: