[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#511342: marked as done (does not check for file creation errors)

Your message dated Thu, 15 Jan 2009 10:02:04 +0000
with message-id <E1LNP36-0006ND-6h@ries.debian.org>
and subject line Bug#511342: fixed in devtodo 0.1.20-4
has caused the Debian Bug report #511342,
regarding does not check for file creation errors
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

511342: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=511342
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: devtodo
Version: 0.1.19-3
Severity: grave
Justification: causes data loss

Here's how to reproduce:

| mowsiany@beczulka:/$ strace -t -o /tmp/tda-write-fail.log tda
| Enter text for the item you are adding.
| text> foo
| 1. veryhigh   2. high   3. medium   4. low   5. verylow   
| Enter a priority from those listed above.
| priority> medium
| Index of new item is 1
| todo: warning, created database (.todo) has group or world permissions
| mowsiany@beczulka:/$ echo $?
| 0
| mowsiany@beczulka:/$ ls -l .todo
| ls: .todo: No such file or directory
| mowsiany@beczulka:/$ 

Here's the relevant snippet from the strace log:

| 18:44:52 write(1, "\33[0m\33[32mIndex of new item is 1\33"..., 36) = 36
| 18:44:52 open(".todo", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 EACCES (Permission denied)
| 18:44:52 stat64(".todo", 0xbfe0b304)    = -1 ENOENT (No such file or directory)
| 18:44:52 write(2, "todo: warning, created database "..., 33) = 33
| 18:44:52 write(2, ".todo", 5)           = 5
| 18:44:52 write(2, ") has group or world permissions", 32) = 32
| 18:44:52 write(2, "\n", 1)              = 1
| 18:44:52 exit_group(0)                  = ?

Clearly the exit status nor the message do not reflect the fact that creating
the file failed, though apparently the program does pay attention to the fact
that open() failed, as there is no write() call visible.

Apart from the above, it would be good to check if the program correctly
detects write(), flush() and close() failures (e.g. when filesystem runs out of

Marcin Owsiany <porridge@debian.org>             http://marcin.owsiany.pl/
GnuPG: 1024D/60F41216  FE67 DA2D 0ACA FC5E 3F75  D6F6 3A0D 8AA0 60F4 1216

--- End Message ---
--- Begin Message ---
Source: devtodo
Source-Version: 0.1.20-4

We believe that the bug you reported is fixed in the latest version of
devtodo, which is due to be installed in the Debian FTP archive:

  to pool/main/d/devtodo/devtodo_0.1.20-4.diff.gz
  to pool/main/d/devtodo/devtodo_0.1.20-4.dsc
  to pool/main/d/devtodo/devtodo_0.1.20-4_amd64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 511342@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Ryan Niebur <ryanryan52@gmail.com> (supplier of updated devtodo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Wed, 14 Jan 2009 22:48:13 -0800
Source: devtodo
Binary: devtodo
Architecture: source amd64
Version: 0.1.20-4
Distribution: unstable
Urgency: low
Maintainer: Ryan Niebur <ryanryan52@gmail.com>
Changed-By: Ryan Niebur <ryanryan52@gmail.com>
 devtodo    - hierarchical, prioritised todo list manager
Closes: 470987 507418 511342
 devtodo (0.1.20-4) unstable; urgency=low
   * Adopt package (Closes: #507418)
   * Check for errors when creating the file to prevent data loss
     (Closes: #511342)
   * Include copyright information (Closes: #470987)
   * add watch file
   * remove usr/share/man/man1 from debian/dirs, it's not needed
     (usr/share/devtodo is, however, as if it's not there it FTBFS)
   * upgrade policy to 3.8.0
     - add Homepage header
   * don't ignore errors from make distclean
 17cdc3852cd895c298a5ce2ebc603c02da49d16a 1041 devtodo_0.1.20-4.dsc
 2536d9d9024c555fc10ef3628d6583d612425071 40776 devtodo_0.1.20-4.diff.gz
 a8a88c228e36db590e1f151949b5990645694110 152380 devtodo_0.1.20-4_amd64.deb
 b14fd61396b37bf18f8707b0647d3759d001e877e4a3686238f904efd0698728 1041 devtodo_0.1.20-4.dsc
 f0d119e8d524a1651cee0317984d8df37c5e6dc25d852a421d2ed9ec371feef8 40776 devtodo_0.1.20-4.diff.gz
 1098ebe96aa50777bb962f554538f32758d3b90216562350a0910027d577010e 152380 devtodo_0.1.20-4_amd64.deb
 04fd65c6a76b07e333dff20323747f6e 1041 utils optional devtodo_0.1.20-4.dsc
 c7450dedada1a8ed7bd91d7b79b03a0b 40776 utils optional devtodo_0.1.20-4.diff.gz
 a981febf80e01bcfdf86d9492634a84a 152380 utils optional devtodo_0.1.20-4_amd64.deb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: