[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#210760: marked as done (gcal: Czech holidays are wrong)



Your message dated Sat, 16 Aug 2008 09:32:04 +0000
with message-id <E1KUI8i-0001wP-3Z@ries.debian.org>
and subject line Bug#210760: fixed in gcal 3.01.1-7
has caused the Debian Bug report #210760,
regarding gcal: Czech holidays are wrong
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
210760: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=210760
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: gcal
Version: 3.01.1-5
Severity: normal

The Czech holidays listed in the Eternal Holiday List are out of date.
The following patch fixes that.


-- System Information
Debian Release: 3.0
Kernel Version: Linux albireo 2.4.19 #10 Wed Aug 6 20:16:11 CEST 2003 i586 unknown

Versions of the packages gcal depends on:
ii  libc6          2.2.5-11.5     GNU C Library: Shared libraries and Timezone
ii  libncurses5    5.2.20020112a- Shared libraries for terminal handling


--- hd-data2.c.mj	Sat Sep 13 13:52:28 2003
+++ hd-data2.c	Sat Sep 13 15:22:17 2003
@@ -3843,50 +3843,87 @@
 {
    register int  day;
 
-
    ptr_cc_id = "CZ";
-   holiday (*init_data, detected, _(hd_text[HD_ALL_SAINTS_DAY].ht_text),
-            ptr_cc_id, DIS_HLS_PREF, DAY_MIN, 11, year, hd_elems, fday, count);
    if (*init_data)
      *init_data = FALSE;
-   holiday (*init_data, detected, _(hd_text[HD_BOXING_DAY].ht_text),
-            ptr_cc_id, "#", 26, MONTH_MAX, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_CHRISTMAS_DAY].ht_text),
-            ptr_cc_id, "+", 25, MONTH_MAX, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_CHRISTMAS_EVE].ht_text),
-            ptr_cc_id, "+", 24, MONTH_MAX, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_DAY_OF_STUDENTS_REVOLT].ht_text),
-            ptr_cc_id, DIS_HLS_PREF, 17, 11, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_EASTER_MONDAY].ht_text),
-            ptr_cc_id, "+", easter+1, 0, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_EASTER_SUNDAY].ht_text),
-            ptr_cc_id, "+", easter, 0, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_KONSTANTIN_AND_METHODIUS].ht_text),
-            ptr_cc_id, "+", 5, 7, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_LABOUR_DAY].ht_text),
-            ptr_cc_id, "#", DAY_MIN, 5, year, hd_elems, fday, count);
+
+   /*
+    * Several important days which are not state holidays.
+    */
    day = eval_holiday (DAY_MIN, 5, year, DAY_MAX, TRUE) + DAY_MAX;
    holiday (*init_data, detected, _(hd_text[HD_MOTHERS_DAY].ht_text),
             ptr_cc_id, DIS_HLS_PREF, day, 5, year, hd_elems, fday, count);
-   holiday (*init_data, detected, _(hd_text[HD_NEW_YEARS_DAY].ht_text),
-            ptr_cc_id, "+", DAY_MIN, MONTH_MIN, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_PEOPLES_UPRISING_DAY].ht_text),
+            ptr_cc_id, DIS_HLS_PREF, 5, 5, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_ALL_SAINTS_DAY].ht_text),
+            ptr_cc_id, DIS_HLS_PREF, 1, 11, year, hd_elems, fday, count);
    holiday (*init_data, detected, _(hd_text[HD_ST_NICHOLAS_DAY].ht_text),
-            ptr_cc_id, DIS_HLS_PREF, 6, MONTH_MAX, year, hd_elems, fday, count);
+            ptr_cc_id, DIS_HLS_PREF, 6, 12, year, hd_elems, fday, count);
    holiday (*init_data, detected, _(hd_text[HD_SYLVESTER].ht_text), ptr_cc_id,
             DIS_HLS_PREF, dvec[MONTH_MAX-1], MONTH_MAX, year, hd_elems, fday, count);
-   if (year > 1414)
-     holiday (*init_data, detected, _(hd_text[HD_BURNING_OF_JAN_HUS].ht_text),
-              ptr_cc_id, "+", 6, 7, year, hd_elems, fday, count);
-   if (year > 1917)
+
+   /*
+    * I've tried to capture the somewhat complex evolution of the Czech holidays,
+    * but so far I have only a little information on the state before year 1975,
+    * so if you know more, please let me know.
+    *				Martin Mares <mj@ucw.cz>, September 2003
+    *
+    * This is a brief sketch of the history:
+    *
+    * Law:		56/75	141/88	167/90	204/90	218/91	245/00
+    * Effective:	23.6.75	21.9.88	10.5.90	18.5.90	31.5.91	9.8.00
+    *  1. 1.		+	+	+	+	+	+
+    *  Easter		+	+	+	+	+	+
+    *  1. 5.		+	+	+	+	+	+
+    *  5. 5.				
+    *  8. 5.						+	+
+    *  9. 5.		+	+	+	+
+    *  5. 7.				+	+	+	+
+    *  6. 7.					+	+	+
+    * 28. 9.							+
+    * 28.10.			+	+	+	+	+
+    * 17.11.							+
+    * 24.12.				+	+	+	+
+    * 25.12.		+	+	+	+	+	+
+    * 26.12.		+	+	+	+	+	+
+    */
+   holiday (*init_data, detected, _(hd_text[HD_NEW_YEARS_DAY].ht_text),
+            ptr_cc_id, "+", 1, 1, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_EASTER_MONDAY].ht_text),
+            ptr_cc_id, "+", easter+1, 0, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_EASTER_SUNDAY].ht_text),
+            ptr_cc_id, "+", easter, 0, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_LABOUR_DAY].ht_text),
+            ptr_cc_id, "+", 1, 5, year, hd_elems, fday, count);
+   if (year >= 1992)
+     holiday (*init_data, detected, _(hd_text[HD_LIBERATION_DAY].ht_text),
+              ptr_cc_id, "+", 8, 5, year, hd_elems, fday, count);
+   else
+     holiday (*init_data, detected, _(hd_text[HD_LIBERATION_DAY].ht_text),
+              ptr_cc_id, "+", 9, 5, year, hd_elems, fday, count);
+   if (year >= 1990)
+     {
+       holiday (*init_data, detected, _(hd_text[HD_KONSTANTIN_AND_METHODIUS].ht_text),
+                ptr_cc_id, "+", 5, 7, year, hd_elems, fday, count);
+       holiday (*init_data, detected, _(hd_text[HD_BURNING_OF_JAN_HUS].ht_text),
+                ptr_cc_id, "+", 6, 7, year, hd_elems, fday, count);
+     }
+   if (year >= 2000)
+     holiday (*init_data, detected, _(hd_text[HD_DAY_OF_CZECH_STATEHOOD].ht_text),
+              ptr_cc_id, "+", 28, 9, year, hd_elems, fday, count);
+   if (year >= 1988)
      holiday (*init_data, detected, _(hd_text[HD_INDEPENDENCE_DAY].ht_text),
               ptr_cc_id, "+", 28, 10, year, hd_elems, fday, count);
-   if (year > 1944)
-    {
-      holiday (*init_data, detected, _(hd_text[HD_PEOPLES_UPRISING_DAY].ht_text),
-               ptr_cc_id, DIS_HLS_PREF, 5, 5, year, hd_elems, fday, count);
-      holiday (*init_data, detected, _(hd_text[HD_LIBERATION_DAY].ht_text),
-               ptr_cc_id, "#", 8, 5, year, hd_elems, fday, count);
-    }
+   if (year >= 2000)
+     holiday (*init_data, detected, _(hd_text[HD_DAY_OF_STUDENTS_REVOLT].ht_text),
+              ptr_cc_id, "+", 17, 11, year, hd_elems, fday, count);
+   if (year >= 1990)
+     holiday (*init_data, detected, _(hd_text[HD_CHRISTMAS_EVE].ht_text),
+              ptr_cc_id, "+", 24, 12, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_CHRISTMAS_DAY].ht_text),
+            ptr_cc_id, "+", 25, 12, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_BOXING_DAY].ht_text),
+            ptr_cc_id, "+", 26, 12, year, hd_elems, fday, count);
 }
 
 
--- hd-defs.h.mj	Sat Sep 13 14:38:05 2003
+++ hd-defs.h	Sat Sep 13 14:38:02 2003
@@ -662,6 +662,7 @@
 #    define  HD_WHITSUN_EVE                        548
 #    define  HD_W_TUBMANS_BIRTHDAY                 549
 #    define  HD_YAP_DAY                            550
+#    define  HD_DAY_OF_CZECH_STATEHOOD             551
 #  endif /* !HD_TOP20CC */
 
 
--- hd-data.c.mj	Sat Sep 13 14:35:51 2003
+++ hd-data.c	Sat Sep 13 14:44:55 2003
@@ -1382,7 +1382,8 @@
   { HD_WEST_VIRGINIA_DAY,                 "West-Virginia-Tag" },
   { HD_WHITSUN_EVE,                       "Pfingstvorabend" },
   { HD_W_TUBMANS_BIRTHDAY,                "W. Tubmans Geburtstag" },
-  { HD_YAP_DAY,                           "Yap-Tag" }
+  { HD_YAP_DAY,                           "Yap-Tag" },
+  { HD_DAY_OF_CZECH_STATEHOOD,            "Tag der Tschechische Staatlichkeit" }
 #  endif /* !HD_TOP20CC */
 #else /* !USE_DE */
   /*
@@ -1948,7 +1949,8 @@
   { HD_WEST_VIRGINIA_DAY,                 N_("West Virginia Day") },
   { HD_WHITSUN_EVE,                       N_("Whitsun Eve") },
   { HD_W_TUBMANS_BIRTHDAY,                N_("W. Tubman's Birthday") },
-  { HD_YAP_DAY,                           N_("Yap Day") }
+  { HD_YAP_DAY,                           N_("Yap Day") },
+  { HD_DAY_OF_CZECH_STATEHOOD,            N_("Day of Czech Statehood") }
 #  endif /* !HD_TOP20CC */
 #endif /* !USE_DE */
 };


--- End Message ---
--- Begin Message ---
Source: gcal
Source-Version: 3.01.1-7

We believe that the bug you reported is fixed in the latest version of
gcal, which is due to be installed in the Debian FTP archive:

gcal_3.01.1-7.diff.gz
  to pool/main/g/gcal/gcal_3.01.1-7.diff.gz
gcal_3.01.1-7.dsc
  to pool/main/g/gcal/gcal_3.01.1-7.dsc
gcal_3.01.1-7_amd64.deb
  to pool/main/g/gcal/gcal_3.01.1-7_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 210760@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sandro Tosi <matrixhasu@gmail.com> (supplier of updated gcal package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 13 Aug 2008 20:22:00 +0200
Source: gcal
Binary: gcal
Architecture: source amd64
Version: 3.01.1-7
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Sandro Tosi <matrixhasu@gmail.com>
Description: 
 gcal       - program for calculating and printing calendars
Closes: 210760
Changes: 
 gcal (3.01.1-7) unstable; urgency=low
 .
   * QA upload.
   * debian/control
     - bump Standards-Version to 3.8.0 (no changes needed)
     - better short description
     - added texinfo build-dep, needed to provide makeinfo
   * src/{hd-data2.c,hd-defs.h,hd-data.c}
     - fixed Czech holidays; thanks to Martin Mares for the report and patch;
       Closes: #210760
   * src/hd-data.c
     - removed non ASCII char
   * po/Makefile.in.in
     - added --from-code=iso-8859-1
   * debian/rules
     - added -D_GNU_SOURCE to CFLAGS to prevent FTBFS with glibc 2.8; thanks to
       Albert Damen from Ubuntu package for the hint;
     - removed template header
     - removed unneeded or commented dh_* calls
     - updated clean rules to remove gcal.* files under doc/{de,en} since they
       are regenerated
Checksums-Sha1: 
 45a138e2afb809919f7f7541aa65684771b14258 1016 gcal_3.01.1-7.dsc
 d5b9065100a719a883338497611d2d048a2fc4c5 31911 gcal_3.01.1-7.diff.gz
 d62da5983e18b3de33c5fcaac23a80e48fcb3092 1103462 gcal_3.01.1-7_amd64.deb
Checksums-Sha256: 
 9357e8ec6d9ca264137b7ea9c9f50c8b0f3d1497acfdbed6a733c76214435cf0 1016 gcal_3.01.1-7.dsc
 ca6ebddc7767b15b8fd5f8c3770a5aff4e0b834fe8409561cc5640ce94b1632c 31911 gcal_3.01.1-7.diff.gz
 9172f3cc4d13044bea6a27c5443c86f5ea6a082a30fc0d63a537d6f9ce8429b7 1103462 gcal_3.01.1-7_amd64.deb
Files: 
 6c46e5853f2a2d629d05d85d34831428 1016 utils optional gcal_3.01.1-7.dsc
 4e0453fe74b1f000458020dcf569ee78 31911 utils optional gcal_3.01.1-7.diff.gz
 3eab5e8912bdc37ace00f84f58f1d744 1103462 utils optional gcal_3.01.1-7_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkimnDAACgkQKFvXofIqeU4wegCeNdi+4kPsyM2OKg/ruOLq3dda
6KgAoJ6j4hqg3ILQpZTLAkZf7/JlUZHz
=Iuwl
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: