[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#492402: marked as done (tla: implicit pointer conversions)

Your message dated Fri, 25 Jul 2008 22:47:08 +0000
with message-id <E1KMW44-0003L4-BU@ries.debian.org>
and subject line Bug#492402: fixed in tla 1.3.5+dfsg-12
has caused the Debian Bug report #492402,
regarding tla: implicit pointer conversions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

492402: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492402
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: tla
Version: 1.3.5+dfsg-10
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

  Function `arch_interpret_delta_path' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmd-apply-delta.c:304
  Function `arch_find_or_make_tmp_local_copy' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmdutils.c:571
  Function `tmp_dir' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libfsutils/tmp-files.c:84
  Function `arch_interpret_delta_path' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmd-apply-delta.c:304
  Function `arch_find_or_make_tmp_local_copy' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmdutils.c:571
  Function `tmp_dir' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libfsutils/tmp-files.c:84
  Function `arch_interpret_delta_path' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmd-apply-delta.c:304
  Function `arch_find_or_make_tmp_local_copy' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libarch/cmdutils.c:571
  Function `tmp_dir' implicitly converted to pointer at /build/buildd/tla-1.3.5+dfsg/src/tla/libfsutils/tmp-files.c:84

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions
diff -urpN tla-1.3.5+dfsg.orig/src/tla/libarch/cmd-apply-delta.c tla-1.3.5+dfsg/src/tla/libarch/cmd-apply-delta.c
--- tla-1.3.5+dfsg.orig/src/tla/libarch/cmd-apply-delta.c	2006-07-20 00:34:40.000000000 -0600
+++ tla-1.3.5+dfsg/src/tla/libarch/cmd-apply-delta.c	2008-07-25 13:34:38.000000000 -0600
@@ -31,6 +31,7 @@
 #include "tla/libarch/cmd-get.h"
 #include "tla/libarch/cmd-delta.h"
 #include "tla/libarch/cmd-apply-delta.h"
+#include "tla/libarch/cmdutils.h"
 /* __STDC__ prototypes for static functions */
diff -urpN tla-1.3.5+dfsg.orig/src/tla/libarch/cmdutils.c tla-1.3.5+dfsg/src/tla/libarch/cmdutils.c
--- tla-1.3.5+dfsg.orig/src/tla/libarch/cmdutils.c	2006-07-20 00:34:40.000000000 -0600
+++ tla-1.3.5+dfsg/src/tla/libarch/cmdutils.c	2008-07-25 11:59:55.000000000 -0600
@@ -16,6 +16,7 @@
 #include "hackerlab/char/str.h"
 #include "tla/libarch/cmdutils.h"
 #include "tla/libarch/libraries.h"
+#include "tla/libarch/local-cache.h"
 #include "tla/libarch/project-tree.h"
 #include "tla/libarch/patch-logs.h"
 #include "tla/libarch/pfs.h"
diff -urpN tla-1.3.5+dfsg.orig/src/tla/libfsutils/tmp-files.c tla-1.3.5+dfsg/src/tla/libfsutils/tmp-files.c
--- tla-1.3.5+dfsg.orig/src/tla/libfsutils/tmp-files.c	2006-07-20 00:34:40.000000000 -0600
+++ tla-1.3.5+dfsg/src/tla/libfsutils/tmp-files.c	2008-07-25 11:53:56.000000000 -0600
@@ -16,6 +16,7 @@
 #include "hackerlab/char/str-many.h"
 #include "hackerlab/vu/safe.h"
 #include "hackerlab/fs/file-names.h"
+#include "hackerlab/fs/tmp-files.h"
 #include "hackerlab/vu/safe.h"
 #include "tla/libfsutils/tmp-files.h"

--- End Message ---
--- Begin Message ---
Source: tla
Source-Version: 1.3.5+dfsg-12

We believe that the bug you reported is fixed in the latest version of
tla, which is due to be installed in the Debian FTP archive:

  to pool/main/t/tla/tla-doc_1.3.5+dfsg-12_all.deb
  to pool/main/t/tla/tla_1.3.5+dfsg-12.diff.gz
  to pool/main/t/tla/tla_1.3.5+dfsg-12.dsc
  to pool/main/t/tla/tla_1.3.5+dfsg-12_ia64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 492402@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
dann frazier <dannf@debian.org> (supplier of updated tla package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Fri, 25 Jul 2008 14:28:51 -0600
Source: tla
Binary: tla tla-doc
Architecture: source all ia64
Version: 1.3.5+dfsg-12
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: dann frazier <dannf@debian.org>
 tla        - GNU Arch revision control system
 tla-doc    - GNU Arch revision control system (documentation)
Closes: 492402
 tla (1.3.5+dfsg-12) unstable; urgency=low
   * Fix implicit pointer conversions (closes: #492402)
 b421990fd6c963fae6338e8369a6eb43536d6814 991 tla_1.3.5+dfsg-12.dsc
 00b72517e664d9aa7877f52efa9e2dfbcde693b9 32495 tla_1.3.5+dfsg-12.diff.gz
 aa6c6f4665ca1c55672ccb74c52e9f8ca810357f 50612 tla-doc_1.3.5+dfsg-12_all.deb
 2076eb552d6bd68ede570b52332e258ea2d7b308 641518 tla_1.3.5+dfsg-12_ia64.deb
 611f77db430fb001fb9b705f2ffc893fdcaf2a7d51a9b411251eea6a79913eea 991 tla_1.3.5+dfsg-12.dsc
 1fc2d79222e73da3c5d5b952579ad10fcb515d92d130c5a0b9a36a4bd76b18b5 32495 tla_1.3.5+dfsg-12.diff.gz
 671b6f6466a3f15b2165756cffc7c8fc12daeafd99ee41d7defe56040f195c7b 50612 tla-doc_1.3.5+dfsg-12_all.deb
 6083709ee4948b76ca6e2c28b1dbd2c934a9a0412806f942b4320e64fe7ff9f1 641518 tla_1.3.5+dfsg-12_ia64.deb
 50a186bb1938d18e1b96187a4764a765 991 devel optional tla_1.3.5+dfsg-12.dsc
 3d35c0b1bd17004b7cb0ce42059f1838 32495 devel optional tla_1.3.5+dfsg-12.diff.gz
 62f8ebe1c93ed79d7e03cfbf3d5c5d1e 50612 doc optional tla-doc_1.3.5+dfsg-12_all.deb
 9fbec201e5b23e2898384810e79da30a 641518 devel optional tla_1.3.5+dfsg-12_ia64.deb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: