[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#465376: varkon: bashism in /bin/sh script



tags 465376 + patch
thanks

Patch attached.


Regards,

-- 
Chris Lamb, UK                                       chris@chris-lamb.co.uk
                                                            GPG: 0x634F9A20
diff -urNad varkon-1.18A.orig/debian/varkon.sh varkon-1.18A/debian/varkon.sh
--- varkon-1.18A.orig/debian/varkon.sh	2008-04-22 15:58:57.000000000 +0100
+++ varkon-1.18A/debian/varkon.sh	2008-04-22 16:01:35.000000000 +0100
@@ -20,8 +20,8 @@
     while [ "$ans" != "y" -a "$ans" != "n" ] ; do
 	if [ "$ans" ] ; then echo "Please answer either \`y\' or \`n\'"; fi
 	echo "The directory where varkon stores the $2 does not exist."
-	echo -e "\t$1"
-	echo -n "Shall I create it? [Y|n] " > /dev/tty
+	printf "\t$1\n"
+	printf "Shall I create it? [Y|n] " > /dev/tty
 	read ans < /dev/tty
 	ans="`echo $ans | tr A-Z a-z`"
 	ans=${ans:-y}
@@ -180,10 +180,10 @@
 while [ $change = 1 ] ; do
     # Show the current configuration
     echo
-    echo -e "Configuration:\tcurrent  (old)"
-    echo -e "`if [ "$NEW_HTML_VIEWER" != "$HTML_VIEWER" ]; then echo -n '*'; else echo -n " "; fi`1 html_viewer:\t$NEW_HTML_VIEWER  ($HTML_VIEWER)"
-    echo -e "`if [ "$NEW_MBS_EDITOR" != "$MBS_EDITOR" ]; then echo -n '*'; else echo -n " "; fi`2 mbseditor:\t$NEW_MBS_EDITOR  ($MBS_EDITOR)"
-    echo -e "`if [ "$NEW_MBS_EMULATOR" != "$MBS_EMULATOR" ]; then echo -n '*'; else echo -n " "; fi`3 mbsemulator:\t$NEW_MBS_EMULATOR  ($MBS_EMULATOR)"
+    printf "Configuration:\tcurrent  (old)\n"
+    printf "`if [ "$NEW_HTML_VIEWER" != "$HTML_VIEWER" ]; then echo -n '*'; else echo -n " "; fi`1 html_viewer:\t$NEW_HTML_VIEWER  ($HTML_VIEWER)\n"
+    printf "`if [ "$NEW_MBS_EDITOR" != "$MBS_EDITOR" ]; then echo -n '*'; else echo -n " "; fi`2 mbseditor:\t$NEW_MBS_EDITOR  ($MBS_EDITOR)\n"
+    printf "`if [ "$NEW_MBS_EMULATOR" != "$MBS_EMULATOR" ]; then echo -n '*'; else echo -n " "; fi`3 mbsemulator:\t$NEW_MBS_EMULATOR  ($MBS_EMULATOR)\n"
 
     # Ask if user want to change anything
     ans=""
@@ -336,7 +336,7 @@
 
 # Source the system wide configuration
 if [ -f $SYSINI ]; then
-    source $SYSINI
+    . $SYSINI
 fi
 
 # Check for "-h|-?|--help" in command options

Attachment: signature.asc
Description: PGP signature


Reply to: