[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#467135: marked as done (pyflakes: Duplicated output)

Your message dated Sun, 23 Mar 2008 16:17:03 +0000
with message-id <E1JdSsZ-0003jx-9j@ries.debian.org>
and subject line Bug#467135: fixed in pyflakes 0.2.1+svn14502-2
has caused the Debian Bug report #467135,
regarding pyflakes: Duplicated output
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

467135: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467135
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: pyflakes
Version: 0.2.1+svn14502-1
Severity: important

PyFlakes prints warnings twice as illustrated by this simple test case:

  % echo 'print not_defiled' | pyflakes
  <stdin>:1: undefined name 'not_defiled'
  <stdin>:1: undefined name 'not_defiled'

I looked at the source package and found that some of the patches
applied are wrong. The set_exit_status.diff patch is the worst since it
prints the warnings twice using this code:

           w = checker.Checker(tree, filename)
           w.messages.sort(lambda a, b: cmp(a.lineno, b.lineno))
           for warning in w.messages:
               print warning
  +            if status == 0:
  +                status = 1
  +            for warning in w.messages:
  +                print warning
           return len(w.messages)

The nested for-loop is the problem. It would be clearer if the status
variable was simply set like this:

           w = checker.Checker(tree, filename)
           w.messages.sort(lambda a, b: cmp(a.lineno, b.lineno))
           for warning in w.messages:
               print warning
  +        if status == 0 and len(w.messages) > 0:
  +            status = 1
           return len(w.messages)

The patch pyflakes_unicode.diff is wrong and does almost the same as
check_encoding_errors.diff. I think pyflakes_unicode.diff should simply
be dropped.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-k7 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages pyflakes depends on:
ii  python                        2.4.4-6    An interactive high-level object-o
ii  python-central                0.5.15-0.1 register and build utility for Pyt

pyflakes recommends no packages.

-- no debconf information

Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multi-Party Computation) to Python. See: http://viff.dk/.

Attachment: pgpGviVF_TkR6.pgp
Description: PGP signature

--- End Message ---
--- Begin Message ---
Source: pyflakes
Source-Version: 0.2.1+svn14502-2

We believe that the bug you reported is fixed in the latest version of
pyflakes, which is due to be installed in the Debian FTP archive:

  to pool/main/p/pyflakes/pyflakes_0.2.1+svn14502-2.diff.gz
  to pool/main/p/pyflakes/pyflakes_0.2.1+svn14502-2.dsc
  to pool/main/p/pyflakes/pyflakes_0.2.1+svn14502-2_all.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 467135@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Varun Hiremath <varun@debian.org> (supplier of updated pyflakes package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Sun, 23 Mar 2008 21:42:53 +0530
Source: pyflakes
Binary: pyflakes
Architecture: source all
Version: 0.2.1+svn14502-2
Distribution: unstable
Urgency: low
Maintainer: Python Applications Packaging Team <python-apps-team@lists.alioth.debian.org>
Changed-By: Varun Hiremath <varun@debian.org>
 pyflakes   - simple Python source checker
Closes: 453462 467135 472021
 pyflakes (0.2.1+svn14502-2) unstable; urgency=low
   [ Varun Hiremath ]
   * debian/control
     - change Build-Depends: python-central (>= 0.6)
     - fix lintian spelling-error-in-description: s/python/Python/
   * debian/rules
     - remove /usr/lib directory removal (Closes: #472021)
   * debian/patches/set_exit_status.diff
     - fixed duplicated output, thanks to  Martin Geisler <mg@daimi.au.dk>
       (Closes: #467135)
   [ Sandro Tosi ]
   * Adopting for PAPT (Closes: #453462)
   * debian/control
     - added Vcs-{Svn,Browser} fields
     - set PAPT as maintainer
     - set Tristan, Varun and me as uploaders
     - removed empty lines at endfile
 1dc14e9bc62fc70be3a0c90fb38b03dc 1065 python optional pyflakes_0.2.1+svn14502-2.dsc
 d1465ca1c143711048ca80b1c187f5c8 4091 python optional pyflakes_0.2.1+svn14502-2.diff.gz
 20603bc9a3dba49bdbbaca8750ec096f 10000 python optional pyflakes_0.2.1+svn14502-2_all.deb

Version: GnuPG v1.4.6 (GNU/Linux)


--- End Message ---

Reply to: