[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#443711: marked as done (FTBFS: Uses deprecated GTK+ features)

Your message dated Mon, 22 Oct 2007 04:17:03 +0000
with message-id <E1Ijoit-0000Oa-3D@ries.debian.org>
and subject line Bug#443711: fixed in d4x 2.5.7.1-5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: d4x
Version: 2.5.7.1-4
Severity: serious
Tags: patch

d4x fails to build because it uses some deprecated GTK+ features and
defines GTK_DISABLE_DEPRECATED:

if i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../..   -I/usr/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -include ../../config.h  -O2 -Wall -MT fsched.o -MD -MP -MF ".deps/fsched.Tpo" -c -o fsched.o fsched.cc; \
	then mv -f ".deps/fsched.Tpo" ".deps/fsched.Po"; else rm -f ".deps/fsched.Tpo"; exit 1; fi
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc:45: warning: deprecated conversion from string constant to 'char*'
fsched.cc: In function 'GtkWidget* d4x_scheduler_init()':
fsched.cc:251: error: 'gtk_widget_ref' was not declared in this scope
fsched.cc: In function 'void my_gtk_aeditor_browse_ok(GtkWidget*, MyGtkAEditor*)':
fsched.cc:295: error: 'GTK_FILE_SELECTION' was not declared in this scope
fsched.cc:295: error: 'gtk_file_selection_get_filename' was not declared in this scope
fsched.cc: In function 'void my_gtk_aeditor_browse(GtkWidget*, MyGtkAEditor*)':
fsched.cc:309: error: 'gtk_file_selection_new' was not declared in this scope
fsched.cc:312: error: 'GTK_FILE_SELECTION' was not declared in this scope
fsched.cc:312: error: 'gtk_file_selection_set_filename' was not declared in this scope
fsched.cc:314: error: 'GTK_FILE_SELECTION' was not declared in this scope
fsched.cc: At global scope:
fsched.cc:113: warning: 'gint compare_nodes2(const void*, const void*)' defined but not used

The attached patch fixes this by not defining GTK_DISABLE_DEPRECATED.

-- 
Matt

diff -ru d4x-2.5.7.1~/configure.ac d4x-2.5.7.1/configure.ac
--- d4x-2.5.7.1~/configure.ac	2007-09-23 08:14:19.000000000 -0700
+++ d4x-2.5.7.1/configure.ac	2007-09-23 08:22:22.000000000 -0700
@@ -298,7 +298,6 @@
 
 # Other needed defines
 AC_DEFINE(_REENTRANT, , [Enable reenrant code of glibc])
-AC_DEFINE(GTK_DISABLE_DEPRECATED, , [Enable warnings about deprecated functions usage])
 AC_DEFINE(_FILE_OFFSET_BITS, 64, [To support files over 2GB])
 
 # Prepare all requiered flags
diff -ru d4x-2.5.7.1~/configure d4x-2.5.7.1/configure
--- d4x-2.5.7.1~/configure	2007-09-23 08:14:19.000000000 -0700
+++ d4x-2.5.7.1/configure	2007-09-23 08:22:28.000000000 -0700
@@ -18398,11 +18398,6 @@
 
 
 cat >>confdefs.h <<\_ACEOF
-#define GTK_DISABLE_DEPRECATED
-_ACEOF
-
-
-cat >>confdefs.h <<\_ACEOF
 #define _FILE_OFFSET_BITS 64
 _ACEOF
 
diff -ru d4x-2.5.7.1~/main/face/list.cc d4x-2.5.7.1/main/face/list.cc
--- d4x-2.5.7.1~/main/face/list.cc	2007-09-23 08:14:19.000000000 -0700
+++ d4x-2.5.7.1/main/face/list.cc	2007-09-23 08:33:55.000000000 -0700
@@ -8,7 +8,6 @@
  *	but WITHOUT ANY WARRANTY; without even the implied warranty of
  *	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
  */
-#define GTK_DISABLE_DEPRECATED
 
 #include <stdio.h>
 #include <gtk/gtk.h>

--- End Message ---
--- Begin Message --- 
Source: d4x
Source-Version: 2.5.7.1-5

We believe that the bug you reported is fixed in the latest version of
d4x, which is due to be installed in the Debian FTP archive:

d4x-common_2.5.7.1-5_all.deb
  to pool/main/d/d4x/d4x-common_2.5.7.1-5_all.deb
d4x_2.5.7.1-5.diff.gz
  to pool/main/d/d4x/d4x_2.5.7.1-5.diff.gz
d4x_2.5.7.1-5.dsc
  to pool/main/d/d4x/d4x_2.5.7.1-5.dsc
d4x_2.5.7.1-5_i386.deb
  to pool/main/d/d4x/d4x_2.5.7.1-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 443711@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matt Kraai <kraai@debian.org> (supplier of updated d4x package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 21 Oct 2007 21:01:40 -0700
Source: d4x
Binary: d4x-common d4x
Architecture: source i386 all
Version: 2.5.7.1-5
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Matt Kraai <kraai@debian.org>
Description: 
 d4x        - graphical download manager
 d4x-common - graphical download manager - common files
Closes: 443711
Changes: 
 d4x (2.5.7.1-5) unstable; urgency=low
 .
   * QA upload.
   * Do not define GTK_DISABLE_DEPRECATED (Closes: #443711)
Files: 
 61c1f4786cb07158a145bb36cb9c6dfd 707 net optional d4x_2.5.7.1-5.dsc
 e5995d63f53d9ebd39fdd3eea200d0fe 43494 net optional d4x_2.5.7.1-5.diff.gz
 0be71c384870b5aea71489c2e3ef03db 672456 net optional d4x-common_2.5.7.1-5_all.deb
 0914968695ba2ce68d5fb77a6a4ac976 724968 net optional d4x_2.5.7.1-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHHCLufNdgYxVXvBARAsr8AKC2v0oAZpZNqf6Z3iszpViPoCFBcwCgqweA
nFWPP7ly9pRuAdL6aXkDq0E=
=A5yk
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: