[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#440182: marked as done (Gnump3d fails to generate m3u's with seconds included.)

Your message dated Thu, 18 Oct 2007 18:17:03 +0000
with message-id <E1IiZvb-0000dy-Hz@ries.debian.org>
and subject line Bug#440182: fixed in gnump3d 3.0-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: gnump3d

It's seems that when giving a root directory for gnump3d with and
ending slash, e.g. '/opt/music/' lookups in the tag-cache will fail
when m3u files a generated in advanced_playlists are used.
The reason for this is that the tag-cache lookup strips double '/',
and when generating the m3u files the hash-lookup on the cache's
return value fails, since the key (the filename) is stored with
double-'/' stripped, and the lookup still contains the double '/''s.

Patch attached.

Kind regards
Jesper L. Nielsen
--- usr/bin/gnump3d	2006-11-04 19:19:27.000000000 +0100
+++ /usr/bin/gnump3d	2007-08-30 15:25:05.000000000 +0200
@@ -1584,10 +1584,10 @@
         $tags = getSongDisplay( $file ) . "\n";
         if ( not ( $tags =~ /^#EXTINF/ ) )
-	         # fall back to just getting the length and filename
-	         $tagCache->setFormatString( "#EXTINF:\$SECONDS,\$FILENAME" );
+	        # fall back to just getting the length and filename
+	        $tagCache->setFormatString( "#EXTINF:\$SECONDS,\$FILENAME" );
-             $tags = getSongDisplay( $file ) . "\n";
+            $tags = getSongDisplay( $file ) . "\n";
 	     # Remove any leading path
@@ -2762,6 +2762,15 @@
   my ( $file, $format ) = ( @_ );
+  # Remove double slashes, needed because the formatMultipleSongTags
+  # does this, and if we don't the $TAGS{ $file } lookup will fail
+  # because the filename stored (without double '/') doesn't match
+  # the $file variable here (possibly containing double '/').
+  while( $file =~ /\/\// )
+  {
+      $file =~ s/\/\//\//g;
+  }
   # If we're hiding song tags just display the filename
   if ( $hide_song_tags )

--- End Message ---
--- Begin Message ---
Source: gnump3d
Source-Version: 3.0-1

We believe that the bug you reported is fixed in the latest version of
gnump3d, which is due to be installed in the Debian FTP archive:

  to pool/main/g/gnump3d/gnump3d_3.0-1.diff.gz
  to pool/main/g/gnump3d/gnump3d_3.0-1.dsc
  to pool/main/g/gnump3d/gnump3d_3.0-1_all.deb
  to pool/main/g/gnump3d/gnump3d_3.0.orig.tar.gz

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 440182@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Steve Kemp <skx@debian.org> (supplier of updated gnump3d package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Thu, 18 Oct 2007 18:54:19 +0000
Source: gnump3d
Binary: gnump3d
Architecture: source all
Version: 3.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Steve Kemp <skx@debian.org>
 gnump3d    - A streaming server for MP3 and OGG files
Closes: 426076 440182
 gnump3d (3.0-1) unstable; urgency=low
   * New upstream release.
     - Removes password authentication.
     - Fixes display of files using $FILENAME.
     - Removes several warnings.
   * Updated debconf translations:
     - Spanish (Closes: #426076)
   * Correctly generate .m3u files with seconds. (Closes: #440182)
     - Thanks to Jesper L. Nielsen for the report & patch.
 68a90179d543c3f8b7c7587844e077ae 564 sound optional gnump3d_3.0-1.dsc
 d2b665c3267253cc8cae29659131b9b4 671376 sound optional gnump3d_3.0.orig.tar.gz
 adcc0a56a9e16ce8b52b6fb5e06f3d90 14144 sound optional gnump3d_3.0-1.diff.gz
 d51cf8dbf01cc3a34c74582a010a6f71 637226 sound optional gnump3d_3.0-1_all.deb

Version: GnuPG v1.4.6 (GNU/Linux)


--- End Message ---

Reply to: