[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#436498: axel: not handling nostrip build option (policy 10.1) sid/i386



tags 436498 +patch
thanks

On 07/08/07 23:06 +0200, Julien Danjou said ...
> If you call dh_strip correctly in debian/rules, this may mean that upstream

axel doesn't use debhelper, so dh_strip is not called.

> >  -> Building the package
> > Setting DEB_BUILD_OPTIONS=nostrip
> > 
> > ./configure --i18n=1 --debug=0 --prefix=/usr --etcdir=/etc
> > The strip option is enabled. This should not be a problem usually, but on some
> > systems it breaks stuff.

The --strip option can be passed to configure and it is enabled by
default:

 $ ./configure --help
 [snip...]
 --debug=0/1     Disable/enable debugging                0
 --strip=0/1     Disable/enable binary stripping         1

The attached patch looks for debug/nostrip in DEB_BUILD_OPTIONS and sets
the options passed to configure appropriately.

> > strip -R .comment -R .note debian/axel/usr/bin/axel

I've left this strip in the debian/rules as is.

Giridhar

-- 
Y Giridhar Appaji Nag | http://www.appaji.net/
diff -Nur axel-1.0b/debian/rules axel-1.0b.new/debian/rules
--- axel-1.0b/debian/rules	2007-09-12 17:41:35.000000000 +0530
+++ axel-1.0b.new/debian/rules	2007-09-14 13:07:34.470447000 +0530
@@ -1,9 +1,21 @@
 #!/usr/bin/make -f
 
+confopts = --i18n=1 --prefix=/usr --etcdir=/etc
+ifeq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
+	confopts += --debug=0
+else
+	confopts += --debug=1
+endif
+ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
+	confopts += --strip=1
+else
+	confopts += --strip=0
+endif
+
 build: build-stamp
 build-stamp:
 	if [ ! -d debian ]; then exit 1; fi
-	./configure --i18n=1 --debug=0 --prefix=/usr --etcdir=/etc
+	./configure $(confopts)
 	$(MAKE) DESTDIR=`pwd`/debian/axel
 	touch build-stamp
 

Attachment: signature.asc
Description: Digital signature


Reply to: