[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#423712: marked as done (wmacpi 2.1-6 always redraws X window)

Your message dated Thu, 19 Jul 2007 17:47:27 +0000
with message-id <E1IBa63-0004uE-Ve@ries.debian.org>
and subject line Bug#423712: fixed in wmacpi 2.2~rc1-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: wmacpi
Version: 2.1-6

Wmacpi has a subtle bug which renders alot of its redundant-drawing-avoidance
logic pointless, and contributes significantly to it's excessive CPU usage.

The problem is on line 418 of wmacpi.c:
    enum panel_states power = PS_NULL;

it should be:
    static enum panel_states power = PS_NULL;

Every time set_power_panel() is called (every iteration of the main loop)
the power variable is initialized to PS_NULL.  This causes the following 
set_power_panel() logic to determine the power status has changed, the glyph is
then redrawn erroneously and thus the whole X window gets updated.

Adding the static prefix causes the power variable to be initialized once to
PS_NULL.  Then the state of the power varible persists across calls, which is
clearly the intended design.

I didnt bother with a proper patch since it's literally one line changed.

I've cc'd the upstream maintainer as well.

Vito Caputo

--- End Message ---
--- Begin Message ---
Source: wmacpi
Source-Version: 2.2~rc1-1

We believe that the bug you reported is fixed in the latest version of
wmacpi, which is due to be installed in the Debian FTP archive:

  to pool/main/w/wmacpi/wmacpi_2.2~rc1-1.diff.gz
  to pool/main/w/wmacpi/wmacpi_2.2~rc1-1.dsc
  to pool/main/w/wmacpi/wmacpi_2.2~rc1-1_amd64.deb
  to pool/main/w/wmacpi/wmacpi_2.2~rc1.orig.tar.gz

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 423712@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Julien BLACHE <jblache@debian.org> (supplier of updated wmacpi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Tue, 17 Jul 2007 00:50:04 +0200
Source: wmacpi
Binary: wmacpi
Architecture: source amd64
Version: 2.2~rc1-1
Distribution: unstable
Urgency: low
Maintainer: Julien BLACHE <jblache@debian.org>
Changed-By: Julien BLACHE <jblache@debian.org>
 wmacpi     - ACPI battery monitor for WindowMaker
Closes: 280495 293546 420091 423712 429698
 wmacpi (2.2~rc1-1) unstable; urgency=low
   * Adopting wmacpi (closes: #420091).
   * New upstream release.
     + Now more friendly with non-WindowMaker window managers
       (closes: #280495, #293546).
     + Fixed redraw logic (closes: #423712).
   * debian/copyright:
     + Updated download URL (closes: #429698).
     + Updated author's email address.
   * debian/control:
     + Updated URL.
     + Build-Depends: dpatch.
   * debian/rules:
     + Add dpatch stuff.
   * debian/menu:
     + Moved menu entry to Applications/System/Monitoring.
   * debian/patches/10_man_no_acpi.dpatch:
     + Added; acpi is not shipped in the package, so don't document it.
 2c5319d888d8d38f047c87830ac19d5e 667 x11 extra wmacpi_2.2~rc1-1.dsc
 753c2df376de7f9e943bf779f16f7f0c 30265 x11 extra wmacpi_2.2~rc1.orig.tar.gz
 28e4f39febb294f916aef04c02b54c7e 5704 x11 extra wmacpi_2.2~rc1-1.diff.gz
 9c17f486785886e063e80b0a2499458d 30296 x11 extra wmacpi_2.2~rc1-1_amd64.deb

Version: GnuPG v1.4.6 (GNU/Linux)


--- End Message ---

Reply to: