[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#408104: Broken 'diff' function in the VCS::Cvs::Version perl module (bug & fix)



"Gleb Rubanau" <g.rubanau@gmail.com> writes:

[...]
> --- Version.pm.0.6.orig	2007-01-23 15:59:24.000000000 +0200
> +++ Version.pm	2007-01-23 16:00:04.000000000 +0200
> @@ -48,7 +48,7 @@
>     my $text = '';
>     if (ref($other) eq ref($self)) {
>         my $cmd =
> -	    'chdir ' . dirname($self->path) .
> +	    'cd ' . dirname($self->path) .
>             " && $DIFF_CMD " .
>             join (' ', (map { "-r$_" } $self->version, $other->version)) .
>             " '" . basename($self->path) . "' |";

It should also be fixed to quote arguments properly.

Cheers,

Matej



Reply to: