[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#366728: marked as done (tla: FTBFS when using sudo: $(PWD) reset)

Your message dated Sun, 23 Jul 2006 10:04:07 +0200
with message-id <[🔎] 20060723080407.GB20363@localhost.localdomain>
and subject line Fix confirmed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: tla
Version: 1.3.3-3.2
Severity: serious

Since the sudo behaviour change to strip most environment variables,
$(PWD) no longer is set during package build, but debian/rules relies on
it:

| /usr/bin/sudo debian/rules binary-arch
|dh_testdir
|dh_testroot
|dh_clean -k
|dh_installdirs
|/usr/bin/make -C /debian/build install destdir=/debian/tmp
|make: *** /debian/build: No such file or directory.  Stop.
|make: *** [install] Error 2

This happens on all buildds using sudo, i.e. alpha, mips and mipsel
currently I believe.

A full build log can e.g. be found at
http://buildd.debian.org/fetch.php?pkg=tla%26ver=1.3.3-3.2%26arch=alpha%26stamp=1145084722%26file=log

The problem is in debian/rules

|SRC     := $(PWD)/src
|BUILD   := $(PWD)/debian/build
|TARGET  := $(PWD)/debian/tmp
|[...]
|install: debian/build-stamp
|        dh_testdir
|        dh_testroot
|        dh_clean -k
|        dh_installdirs
|
|        $(MAKE) -C $(BUILD) install destdir=$(TARGET)

As binary-arch is run with sudo, the install target is as well, and the
$(BUILD variable only gets expanded to /debian/build in this case as
$(PWD) was stripped by sudo.  The solution is to use e.g. $(curdir)
instead of $(PWD).


Michael

-- 
Michael Banck
Debian Developer
mbanck@debian.org
http://www.advogato.org/person/mbanck/diary.html

--- End Message ---
--- Begin Message --- 
Thanks for the fix, it is now integrated in the new version.
Closing the bug :)

https://savannah.nongnu.org/projects/arch4debian/

--- End Message ---
Reply to: