[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#404235: segfault patch for 404235

Hi Nico,

On Fri, Dec 29, 2006 at 07:08:29PM +0100, Nico Golde wrote:
> I attached 2 patches for trr_update and trr_format which 
> should fix this.
> Please test them before you upload the changes since I don't 
> use emacs and have no idea of the program.

thanks for the patch.

> +++ trr_format.c	2006-12-29 18:27:26.000000000 +0100
>  main(int argc, char **argv){
> -  char textfile[256], formattedfile[256], lockfile[256], *tmpfname;
> -  char command[256], line[1024];
> +  char textfile[_POSIX_PATH_MAX], formattedfile[_POSIX_PATH_MAX], lockfile[_POSIX_PATH_MAX], *tmpfname;
> +  char command[_POSIX_PATH_MAX], line[_POSIX_PATH_MAX];

Please note that this will probably not work with the Hurd. This system
tries to avoid all useless limitations and _POSIX_PATH_MAX is one of
these. The proper solution is to create the buffers dynamically ...


Reply to: