[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#356252: marked as done (libpng: Please add add udeb: lines to shlibs file)

Your message dated Mon, 16 Oct 2006 02:05:44 -0700
with message-id <E1GZOPo-0008Db-HF@spohr.debian.org>
and subject line Bug#356252: fixed in libpng 1.2.8rel-7
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: libpng
Version: 1.2.8rel-5
Severity: wishlist
Tags: patch, d-i

Let's call this an important wishlist bug (important for Debian Installer 
anyway :-)

Please add the following line to your shlibs file:
udeb: libpng12 0 libpng12-0-udeb (>= 1.2.8rel)

This will allow dpkg/debhelper to properly set the dependencies for udebs 
that depend on libpng.
Please see #345472 and #345475 for further info on this.

It would be very much appreciated if this change could be implemented

The attached patch implements the necessary changes:
- add --add-udeb option for dh_makeshlibs which autogenerates the
  udeb: lines for the shlibs file
- this requires debhelper 5.0.22
- add the udeb line also to debian/libpng12-0.shlibs as this currently
  overrules whatever is generated by dh_makeshlibs [1]
- drop the Provides: libpng12-0

I've also updated debian/compat to level 5, in line with the debhelper 

I've checked the debdiff for the libpng12-0 deb and udeb against current 
versions and there were no unexpected changes.

Frans Pop

[1] To be honest I fail to see why you include that file at all: if I
    remove it, the generated shlibs is identical to the one you include.
    Packaging error?
diff -u libpng-1.2.8rel/debian/control libpng-1.2.8rel/debian/control
--- libpng-1.2.8rel/debian/control
+++ libpng-1.2.8rel/debian/control
@@ -2,7 +2,7 @@
 Section: libs
 Priority: optional
 Maintainer: Josselin Mouette <joss@debian.org>
-Build-Depends: debhelper (>= 4.2), zlib1g-dev, cdbs, mawk
+Build-Depends: debhelper (>= 5.0.22), zlib1g-dev, cdbs, mawk
 Standards-Version: 3.6.2
 Package: libpng12-0
@@ -49,8 +49,7 @@
 XC-Package-Type: udeb
 Section: debian-installer
 Architecture: any
-Depends: zlib1g-udeb
-Provides: libpng12-0
+Depends: ${shlibs:Depends}
 Description: PNG library - minimal runtime library
  libpng is a library implementing an interface for reading and writing
  PNG (Portable Network Graphics) format files.
diff -u libpng-1.2.8rel/debian/libpng12-0.shlibs libpng-1.2.8rel/debian/libpng12-0.shlibs
--- libpng-1.2.8rel/debian/libpng12-0.shlibs
+++ libpng-1.2.8rel/debian/libpng12-0.shlibs
@@ -1,0 +2 @@
+udeb: libpng12 0 libpng12-0-udeb (>= 1.2.8rel)
diff -u libpng-1.2.8rel/debian/rules libpng-1.2.8rel/debian/rules
--- libpng-1.2.8rel/debian/rules
+++ libpng-1.2.8rel/debian/rules
@@ -29,6 +29,7 @@
 DEB_INSTALL_DOCS_libpng12-dev := --no-act
 DEB_INSTALL_CHANGELOGS_libpng3 := --no-act
 DEB_INSTALL_CHANGELOGS_libpng12-dev := --no-act
+DEB_DH_MAKESHLIBS_ARGS_libpng12-0 := --add-udeb="$(UPACKAGE)"
 	dh_installdocs -plibpng12-dev -Xcopyright
diff -u libpng-1.2.8rel/debian/compat libpng-1.2.8rel/debian/compat
--- libpng-1.2.8rel/debian/compat
+++ libpng-1.2.8rel/debian/compat
@@ -1 +1 @@

Attachment: pgpJwyhyqyxss.pgp
Description: PGP signature

--- End Message ---
--- Begin Message ---
Source: libpng
Source-Version: 1.2.8rel-7

We believe that the bug you reported is fixed in the latest version of
libpng, which is due to be installed in the Debian FTP archive:

  to pool/main/libp/libpng/libpng12-0-udeb_1.2.8rel-7_i386.udeb
  to pool/main/libp/libpng/libpng12-0_1.2.8rel-7_i386.deb
  to pool/main/libp/libpng/libpng12-dev_1.2.8rel-7_i386.deb
  to pool/main/libp/libpng/libpng3_1.2.8rel-7_all.deb
  to pool/main/libp/libpng/libpng_1.2.8rel-7.diff.gz
  to pool/main/libp/libpng/libpng_1.2.8rel-7.dsc

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 356252@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Anibal Monsalve Salazar <anibal@debian.org> (supplier of updated libpng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Mon, 16 Oct 2006 17:34:58 +1000
Source: libpng
Binary: libpng12-dev libpng12-0 libpng12-0-udeb libpng3
Architecture: source i386 all
Version: 1.2.8rel-7
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Changed-By: Anibal Monsalve Salazar <anibal@debian.org>
 libpng12-0 - PNG library - runtime
 libpng12-0-udeb - PNG library - minimal runtime library (udeb)
 libpng12-dev - PNG library - development
 libpng3    - PNG library - runtime
Closes: 356252 377298 378463 393109
 libpng (1.2.8rel-7) unstable; urgency=low
   * New maintainer. Closes: #393109.
   * ACK NMUs. Closes: #378463, #377298, #356252.
   * debian/control:
     - set Standards-Version to 3.7.2.
     - set Priority to extra for libpng12-0-udeb.
     - added ${misc:Depends} to libpng12-0 and libpng12-0-udeb
       dependency lists.
   * Added debian/watch file.
 b38c66c97edadcc58fdb5cb42fa3cef5 700 libs optional libpng_1.2.8rel-7.dsc
 dee626d9d29a5d678f25b7ff76e446fc 16517 libs optional libpng_1.2.8rel-7.diff.gz
 d36c73ff5c40ce33dfe82bad704705b5 874 oldlibs optional libpng3_1.2.8rel-7_all.deb
 4839089a435dc41e837cb30dcc6f0cf9 114820 libs optional libpng12-0_1.2.8rel-7_i386.deb
 024f27ea6235032769bae584dfc86c40 243100 libdevel optional libpng12-dev_1.2.8rel-7_i386.deb
 0203db8529775f092ca2d38f77f8997f 70226 debian-installer extra libpng12-0-udeb_1.2.8rel-7_i386.udeb
Package-Type: udeb

Version: GnuPG v1.4.3 (GNU/Linux)


--- End Message ---

Reply to: