[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#287687: marked as done (asmounter does not work when mount points have similar paths)

Your message dated Mon, 14 Aug 2006 08:32:03 -0700
with message-id <E1GCeQ7-0000VV-O6@spohr.debian.org>
and subject line Bug#287687: fixed in asmounter 0.3-5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: asmounter
Version: 0.3-3
Tags: patch

Hi !

Debian asmounter has the following bug in Woody and Sid :
- matching in /proc/mounts is poorly coded so on similar mount points, 
asmounter thinks the FS is already mounted and it won't let you mount it.

- I use the /usb mount point
- but /proc/bus/usb is mounted
- so asmounter thinks /usb is mounted and I cannot mount /usb !

Similar problems can occur, if you use /mnt/cdr and /mnt/cdrom for example...

A trivial fix is included: it add spaces around the string to match to
make sure that it won't match a substring.

Also the URL in the debian/copyright file is dead.


Ludovic Drolez.

http://www.palmopensource.com       - The PalmOS Open Source Portal
http://www.drolez.com      - Personal site - Linux and PalmOS stuff
--- asmounter.c.orig	Wed Dec 29 15:13:03 2004
+++ asmounter.c	Wed Dec 29 15:15:27 2004
@@ -798,6 +798,7 @@
 	FILE *fd;
 	char buf[MAX_STR_SIZE] = "\0";
 	bool found = FALSE;
+	char search_mntpoint[256];
 	/* Open MOUNTS file to search */
 	if (NULL == (fd = fopen(MOUNTS, "r"))) {
@@ -807,8 +808,9 @@
 	/* Search for mountpoint ... */
+	snprintf(search_mntpoint, 255, " %s ", mntpoint);
 	while (NULL != fgets(buf, MAX_STR_SIZE, fd)) {
-		found = (NULL != strstr(buf,mntpoint));
+		found = (NULL != strstr(buf,search_mntpoint));
 		if (found) break;

--- End Message ---
--- Begin Message ---
Source: asmounter
Source-Version: 0.3-5

We believe that the bug you reported is fixed in the latest version of
asmounter, which is due to be installed in the Debian FTP archive:

  to pool/main/a/asmounter/asmounter_0.3-5.diff.gz
  to pool/main/a/asmounter/asmounter_0.3-5.dsc
  to pool/main/a/asmounter/asmounter_0.3-5_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 287687@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Matej Vela <vela@debian.org> (supplier of updated asmounter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Mon, 14 Aug 2006 17:09:06 +0200
Source: asmounter
Binary: asmounter
Architecture: source i386
Version: 0.3-5
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Matej Vela <vela@debian.org>
 asmounter  - Mount point manager for AfterStep
Closes: 287687 309808
 asmounter (0.3-5) unstable; urgency=low
   * QA upload.
   * Fix false positives when matching mount points.  Closes: #287687.
   * Mention AfterStep in the description.  Closes: #309808.
   * asmounter.man: Fix section header.
   * Switch to debhelper 5.
   * Convert ad-hoc patch system to dpatch.
   * debian/rules:
     - Configure with `--disable-jpeg' since libjpeg isn't actually used.
     - Add support for DEB_BUILD_OPTIONS=noopt.
   * debian/README.Debian: Already covered in the description; remove.
   * debian/watch: Add.
   * Conforms to Standards version 3.7.2.
 0ae54bb04d82df96b6c2c1508fb9cbe6 610 x11 optional asmounter_0.3-5.dsc
 53ca350704a9bc0789043134afbcb608 3509 x11 optional asmounter_0.3-5.diff.gz
 4a22a5e71e86dcfe8c0084c9df664c33 19774 x11 optional asmounter_0.3-5_i386.deb

Version: GnuPG v1.4.5 (GNU/Linux)


--- End Message ---

Reply to: