[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#372251: marked as done (General cleanup: fixing CFLAGS, compiler warnings, lintian errors, ...)

Your message dated Wed, 14 Jun 2006 05:02:09 -0700
with message-id <E1FqU4X-00013v-RQ@spohr.debian.org>
and subject line Bug#372251: fixed in cutter 1.03-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: cutter
Severity: normal
Tags: patch

The attached diff fixes the passing of CFLAGS from debian/rules to
the main Makefile. Without this fix, the CFLAGS set in debian/rules
(-Wall -g -O2) are not communicated down.

It also fixes an error in the manpage cutter(8), which produced an
error message in the `man` output.

Futher it updates the FSF address in debian/copyright.

It also cleans up the code a bit, fixing several compiler warnings.
3 correlated ones remain, though they are harmless, and the fix
looks rather stupid to me.

Lastly it updates Standards-Version to 3.7.2, no changes are
required AFAICS.

With this patch cutter is lintian and linda clean again.

Christian Aichinger

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-rc6-vs2.1.0-pre1-r20050817
Locale: LANG=de_AT.UTF-8@euro, LC_CTYPE=de_AT.UTF-8@euro (charmap=UTF-8)
diff -Nur cutter-1.02.old/cutter.8 cutter-1.02/cutter.8
--- cutter-1.02.old/cutter.8	2006-06-09 06:20:02.000000000 +0200
+++ cutter-1.02/cutter.8	2006-06-09 07:11:25.000000000 +0200
@@ -5,7 +5,7 @@
 .B cutter
 .IR ipaddress1 \ [ \ port1 \ [ \ ipaddress2 \ [ \ port2 
-.R ] \ ] \ ]
+\ ] \ ] \ ]
 .B Cutter
diff -Nur cutter-1.02.old/cutter.c cutter-1.02/cutter.c
--- cutter-1.02.old/cutter.c	2003-06-16 21:35:02.000000000 +0200
+++ cutter-1.02/cutter.c	2006-06-09 06:42:29.000000000 +0200
@@ -57,6 +57,7 @@
 #include <arpa/inet.h>
 #include <net/if.h>
 #include <errno.h>
+#include <time.h>
 #define ETHHDR	 sizeof(struct ethhdr)
 #define TCPHDR	 sizeof(struct tcphdr)
@@ -149,7 +150,6 @@
 int getmac(in_addr_t ip, uchar *mac)
 	FILE *id = fopen( "/proc/net/arp", "r" );
-	union { uchar c[4]; in_addr_t n; } ipu;
 	in_addr_t ipn;
 	int mac0, mac1, mac2, mac3, mac4, mac5;
 	int hwtype, flags;
@@ -240,7 +240,7 @@
 	u_short toport
-	int i_result, raw_sock, rtn;
+	int i_result, raw_sock;
 	in_addr_t gateway_ip;
 	struct sockaddr_ll myaddr, hisaddr;
 	struct tpack tpack;
@@ -377,7 +377,7 @@
 	for ( ; time(0) < tstart + 15; ) {	// give the peer 15 seconds to respond
 		struct sockaddr_ll gotaddr;
-		int addrlen = sizeof(gotaddr);
+		unsigned int addrlen = sizeof(gotaddr);
 		fd_set readfds;
 		struct timeval tv;
diff -Nur cutter-1.02.old/debian/control cutter-1.02/debian/control
--- cutter-1.02.old/debian/control	2006-06-09 06:20:02.000000000 +0200
+++ cutter-1.02/debian/control	2006-06-09 07:14:44.000000000 +0200
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Blars Blarson <blarson@blars.org>
 Build-Depends: debhelper (>= 4.0.0)
-Standards-Version: 3.6.1
+Standards-Version: 3.7.2
 Package: cutter
 Architecture: any
diff -Nur cutter-1.02.old/debian/copyright cutter-1.02/debian/copyright
--- cutter-1.02.old/debian/copyright	2006-06-09 06:20:02.000000000 +0200
+++ cutter-1.02/debian/copyright	2006-06-09 07:16:50.000000000 +0200
@@ -19,9 +19,9 @@
    GNU General Public License for more details.
    You should have received a copy of the GNU General Public License
-   along with this package; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
-   02111-1307, USA.
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301  USA
 On Debian GNU/Linux systems, the complete text of the GNU General
 Public License can be found in `/usr/share/common-licenses/GPL'.
diff -Nur cutter-1.02.old/debian/rules cutter-1.02/debian/rules
--- cutter-1.02.old/debian/rules	2006-06-09 06:20:02.000000000 +0200
+++ cutter-1.02/debian/rules	2006-06-09 06:34:53.000000000 +0200
@@ -33,7 +33,7 @@
 	# Add here commands to compile the package.
-	$(MAKE)
 	touch build-stamp

Attachment: signature.asc
Description: Digital signature

--- End Message ---
--- Begin Message ---
Source: cutter
Source-Version: 1.03-1

We believe that the bug you reported is fixed in the latest version of
cutter, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cutter/cutter_1.03-1.diff.gz
  to pool/main/c/cutter/cutter_1.03-1.dsc
  to pool/main/c/cutter/cutter_1.03-1_amd64.deb
  to pool/main/c/cutter/cutter_1.03.orig.tar.gz

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 372251@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Michael Ablassmeier <abi@debian.org> (supplier of updated cutter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Wed, 14 Jun 2006 09:37:08 +0200
Source: cutter
Binary: cutter
Architecture: source amd64
Version: 1.03-1
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Michael Ablassmeier <abi@debian.org>
 cutter     - disconnect routed IP connections
Closes: 372251
 cutter (1.03-1) unstable; urgency=low
   * QA Upload
   * New upstream release.
   * Move cutter.8 to debian/
   * Conforms with new standards version
   * Update debian/copyright (new FSF Address)
   * Pass CFLAGS to Makefile
   * Fix Manpage
 	 + Most changes stripped from a patch  provided by Christian
 	   Aichinger, thanks.  (Closes: #372251)
 979b534a4bbfc06d817809b96b971f88 560 net optional cutter_1.03-1.dsc
 b777685c0e260c551b7cbd27c261ed15 13142 net optional cutter_1.03.orig.tar.gz
 343caeef703dae76fd7eb35fc612a4af 4383 net optional cutter_1.03-1.diff.gz
 80474e71d09ac3e0ad45ae2511d9954a 11310 net optional cutter_1.03-1_amd64.deb

Version: GnuPG v1.4.3 (GNU/Linux)


--- End Message ---

Reply to: