Bug#152128: vcg: xvcg dies with segfault when opening a vcg file
On Thu, Mar 09, 2006 at 11:19:38AM +0100, Matej Vela wrote:
> Justin Pryzby <firstname.lastname@example.org> writes:
> > On Tue, Mar 07, 2006 at 11:47:25PM +0100, Matej Vela wrote:
> >> I think I've tracked this down to a memory overrun in src/X11dev.c.
> >> Does the attached patch work for you?
> > That's awesome :) How did you find it?
> I set a bunch of breakpoints to see where the stack got corrupted, i.e.
> where backtrace started printing question marks. It turned out the code
> was using an XAnyEvent (size 20) in place of an XEvent (size 96); thus
> the overrun.
Saw that ..
> > I note that there's still a number of valgrind warnings :/
> Mostly harmless as far as I can tell, but patches are always welcome. ;)
What leads you to believe that they are harmless? Sorry, just trying
to learn something (else) :)