Bug#237837: marked as done (bbpager: windows list leak in void WMInterface::windowAttributeChange(Window win))
Your message dated Wed, 14 Sep 2005 18:17:04 -0700
with message-id <E1EFiN6-0006GF-00@spohr.debian.org>
and subject line Bug#237837: fixed in bbpager 0.4.1b1-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 13 Mar 2004 18:37:28 +0000
>From cedric.pradalier@inrialpes.fr Sat Mar 13 10:37:28 2004
Return-path: <cedric.pradalier@inrialpes.fr>
Received: from master.debian.org [146.82.138.7]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B2E0m-0003n5-00; Sat, 13 Mar 2004 10:37:28 -0800
Received: from alyon-209-1-1-201.w80-14.abo.wanadoo.fr (ceruse.tomsawyer) [80.14.93.201]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B2E0k-0000Ua-00; Sat, 13 Mar 2004 12:37:26 -0600
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: =?iso-8859-15?q?C=E9dric_Pradalier?= <cedric.pradalier@inrialpes.fr>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: bbpager: windows list leak in void WMInterface::windowAttributeChange(Window
win)
Bcc: =?iso-8859-15?q?C=E9dric_Pradalier?= <cedric.pradalier@inrialpes.fr>
X-Mailer: reportbug 2.48
Date: Sat, 13 Mar 2004 19:37:22 +0100
Message-Id: <E1B2E0k-0000Ua-00@master.debian.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_12
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.0 required=4.0 tests=BAYES_30,HAS_PACKAGE,
OUR_MTA_MSGID autolearn=no version=2.60-bugs.debian.org_2004_03_12
X-Spam-Level:
Package: bbpager
Version: 0.3.1-2
Severity: important
Tags: patch
There is a leak of windows in bbtool->windowList in
void WMInterface::windowAttributeChange(Window win)
addSticky (line 278) is called much more often than removeSticky.
I use bbpager with 6 WindowMaker withdrawn window in the slit, and 5 desktops.
After some time (changing desktop, creating/closing windows), bbpager takes
more and more processor when changing desktop.
After some investigation with fnccheck and printfs, I found that removeSticky
was nearly never called. So the windowList size increases very fast until
containing thousands of windows (even with only 15 real existing windows).
I solved this by surrounding the following lines (wminterface.cc:278)
tmp->sticky=True;
addSticky(tmp);
with
if (!tmp->sticky){
tmp->sticky=True;
addSticky(tmp);
}
This solves the leak, even if sometimes some sticky windows are not drawn in
bbpager.
I'm not sure that this is an optimal solution though.
Regards.
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (500, 'testing')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.3-ben2
Locale: LANG=C, LC_CTYPE=C (ignored: LC_ALL set to C)
Versions of packages bbpager depends on:
ii blackbox 0.65.0-1.2 Window manager for X
ii libc6 2.3.2.ds1-11 GNU C Library: Shared libraries an
ii libgcc1 1:3.3.3-1 GCC support library
ii libstdc++5 1:3.3.3-1 The GNU Standard C++ Library v3
ii xlibs 4.2.1-12.1 X Window System client libraries
-- no debconf information
---------------------------------------
Received: (at 237837-close) by bugs.debian.org; 15 Sep 2005 01:18:25 +0000
>From katie@spohr.debian.org Wed Sep 14 18:18:25 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EFiN6-0006GF-00; Wed, 14 Sep 2005 18:17:04 -0700
From: Stan Vasilyev <stan.vasilyev@csun.edu>
To: 237837-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#237837: fixed in bbpager 0.4.1b1-1
Message-Id: <E1EFiN6-0006GF-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Wed, 14 Sep 2005 18:17:04 -0700
Delivered-To: 237837-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 3
Source: bbpager
Source-Version: 0.4.1b1-1
We believe that the bug you reported is fixed in the latest version of
bbpager, which is due to be installed in the Debian FTP archive:
bbpager_0.4.1b1-1.diff.gz
to pool/main/b/bbpager/bbpager_0.4.1b1-1.diff.gz
bbpager_0.4.1b1-1.dsc
to pool/main/b/bbpager/bbpager_0.4.1b1-1.dsc
bbpager_0.4.1b1-1_i386.deb
to pool/main/b/bbpager/bbpager_0.4.1b1-1_i386.deb
bbpager_0.4.1b1.orig.tar.gz
to pool/main/b/bbpager/bbpager_0.4.1b1.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 237837@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stan Vasilyev <stan.vasilyev@csun.edu> (supplier of updated bbpager package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 14 Sep 2005 21:29:20 +0000
Source: bbpager
Binary: bbpager
Architecture: source i386
Version: 0.4.1b1-1
Distribution: unstable
Urgency: low
Maintainer: Stan Vasilyev <stan.vasilyev@csun.edu>
Changed-By: Stan Vasilyev <stan.vasilyev@csun.edu>
Description:
bbpager - Pager for the Blackbox window manager
Closes: 101217 178163 219345 237837 259583 322306
Changes:
bbpager (0.4.1b1-1) unstable; urgency=low
.
* New maintainer. (Closes: #259583: ITA: bbpager -- Pager for the
Blackbox window manager - Debian Bug report logs)
* New upstream release
* Updated Free Software Foundation address in Debian copyright
* Updated homepage in package description
* Changed Depends: blackbox (>= 0.60.2) | openbox | fluxbox to
Suggests: blackbox (>= 0.70) | openbox | fluxbox since this version of
bbpager is compatible with KDE and other window managers
* Closes: #322306: bbpager fails to start under blackbox and fluxbox
(possibly others)
* Closes: #237837: windows list leak in void
WMInterface::windowAttributeChange(Window win)
* Closes: #101217: bbpager cannot find blackbox style file
* Closes: #178163: bbpager does not parse ~ in resource file
* Closes: #219345: Always showing sticky windows closed under fluxbox
* Added Depends: libbt and Build-Depends: libbt-dev
Files:
39dba6cb39c5eed2bc86c12822d8b92e 625 x11 optional bbpager_0.4.1b1-1.dsc
1143bfc7539810b37081f3961876eea4 163099 x11 optional bbpager_0.4.1b1.orig.tar.gz
89cd3c8bfe87a6b05729131a177ff72d 3794 x11 optional bbpager_0.4.1b1-1.diff.gz
19617239eeb4ba645d7b2bbe27d1fff0 134354 x11 optional bbpager_0.4.1b1-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDKMlQxa93SlhRC1oRAutzAJ4zdVnWKzhNV+a47Q9Cr0SIaainMgCcDNC1
f0ZJU68X7oZCfQZmz4nSIRk=
=ULp3
-----END PGP SIGNATURE-----
Reply to: