Bug#161294: marked as done (libgtk-perl: return value from function for menu popup trashed)
Your message dated Wed, 07 Sep 2005 18:47:06 -0700
with message-id <E1EDBVK-0003Xx-00@spohr.debian.org>
and subject line Bug#161294: fixed in libgtk-perl 0.7009-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Sep 2002 07:45:20 +0000
>From oskar@osk.mine.nu Wed Sep 18 02:45:20 2002
Return-path: <oskar@osk.mine.nu>
Received: from as2-1-6.lh.m.bonet.se (alpha) [194.236.130.162] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 17rZWS-0001mb-00; Wed, 18 Sep 2002 02:45:20 -0500
Received: from oskar ([192.168.1.2] ident=mail)
by alpha with esmtp (Exim 3.35 #1 (Debian))
id 17rZUD-0007Sm-00
for <submit@bugs.debian.org>; Wed, 18 Sep 2002 09:43:01 +0200
Received: from usel by oskar with local (Exim 3.36 #1 (Debian))
id 17rZWO-0000Pe-00; Wed, 18 Sep 2002 09:45:16 +0200
From: Oskar Liljeblad <oskar@osk.mine.nu>
Subject: libgtk-perl: return value from function for menu popup trashed
To: submit@bugs.debian.org
X-Mailer: bug 3.3.10.1
Message-Id: <E17rZWO-0000Pe-00@oskar>
Date: Wed, 18 Sep 2002 09:45:16 +0200
Delivered-To: submit@bugs.debian.org
Package: libgtk-perl
Version: 0.7008-1.5
Severity: normal
This bug has been in the bugzilla.gnome.org database for 5 months now
and nothing whatsoever has happened. I find this strange since it
includes (1) test case and (2) simple patch. (Maybe this is related to
the fact that I can't even find by looking at open bugs for gnome-perl
it unless I specify its number...)
This is a copy of
http://bugzilla.gnome.org/show_bug.cgi?id=78947:
When calling gtk_menu_popup you can specify a function that will be called
later to return the position where the menu should pop up. In perl this
function should return two values, x and y position. But there's a bug in
Gtk/xs/GtkMenu.xs which causes the y position to be ignored and set to 0
every time.
Below is a patch to fix it. I don't know if it is correct, but it works
here. Note that the patch also fixes a case when the menu position in perl
would return an array of size 0, which would lead to a Segmentation fault.
Here's a program to test everything:
#! /usr/bin/perl
use Gtk;
init Gtk;
$menu = new Gtk::Menu();
$item = new Gtk::MenuItem('Just An Item');
$menu->append($item);
$item->show();
$window = new Gtk::Window();
$button = new Gtk::Button('Click Me');
$button->signal_connect('clicked', sub {
$menu->popup(undef,undef,0,0,\&menu_pos) });
$window->add($button);
$window->show_all();
main Gtk;
sub menu_pos {
my ($widget,$x,$y) = @_;
return ($x+10,$y-10);
}
When pressing the "Click Me" button, the popup menu should appear near the
cursor.
Oskar Liljeblad (oskar@osk.mine.nu)
--- GtkMenu.xs Sun Jun 17 18:24:19 2001
+++ GtkMenuFixed.xs Wed Apr 17 15:25:07 2002
@@ -32,9 +32,9 @@
croak("MenuPosFunc must return two or less values");
if (i==1)
POPs;
- else {
- *x = SvIV(POPs);
- *y = SvIV(POPs);
+ else if (i==2) {
+ *y = POPi;
+ *x = POPi;
}
PUTBACK;
---------------------------------------
Received: (at 161294-close) by bugs.debian.org; 8 Sep 2005 01:48:47 +0000
>From katie@spohr.debian.org Wed Sep 07 18:48:47 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EDBVK-0003Xx-00; Wed, 07 Sep 2005 18:47:06 -0700
From: Matej Vela <vela@debian.org>
To: 161294-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#161294: fixed in libgtk-perl 0.7009-4
Message-Id: <E1EDBVK-0003Xx-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Wed, 07 Sep 2005 18:47:06 -0700
Delivered-To: 161294-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: libgtk-perl
Source-Version: 0.7009-4
We believe that the bug you reported is fixed in the latest version of
libgtk-perl, which is due to be installed in the Debian FTP archive:
libgladexml-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgladexml-perl_0.7009-4_i386.deb
libgnome-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgnome-perl_0.7009-4_i386.deb
libgnome-print-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgnome-print-perl_0.7009-4_i386.deb
libgtk-imlib-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgtk-imlib-perl_0.7009-4_i386.deb
libgtk-perl_0.7009-4.diff.gz
to pool/main/libg/libgtk-perl/libgtk-perl_0.7009-4.diff.gz
libgtk-perl_0.7009-4.dsc
to pool/main/libg/libgtk-perl/libgtk-perl_0.7009-4.dsc
libgtk-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgtk-perl_0.7009-4_i386.deb
libgtk-pixbuf-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgtk-pixbuf-perl_0.7009-4_i386.deb
libgtkglarea-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgtkglarea-perl_0.7009-4_i386.deb
libgtkxmhtml-perl_0.7009-4_i386.deb
to pool/main/libg/libgtk-perl/libgtkxmhtml-perl_0.7009-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 161294@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matej Vela <vela@debian.org> (supplier of updated libgtk-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 8 Sep 2005 03:37:34 +0200
Source: libgtk-perl
Binary: libgnome-perl libgtk-pixbuf-perl libgtk-imlib-perl libgladexml-perl libgtk-perl libgnome-print-perl libgtkglarea-perl libgtkxmhtml-perl
Architecture: source i386
Version: 0.7009-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Matej Vela <vela@debian.org>
Description:
libgladexml-perl - Perl module for the libglade library
libgnome-perl - Perl module for the gnome and zvt libraries
libgnome-print-perl - Perl module for the gnome print library
libgtk-imlib-perl - Perl module for the gdkimlib library
libgtk-perl - Perl module for the gtk+ library
libgtk-pixbuf-perl - Perl module for the gdkpixbuf library
libgtkglarea-perl - Perl module for the gtkglarea library
libgtkxmhtml-perl - Perl module for the libgtkxmhtml library
Closes: 161294
Changes:
libgtk-perl (0.7009-4) unstable; urgency=low
.
* QA upload.
* Gtk/xs/GtkMenu.xs (menu_pos_func): Handle callback return values.
Thanks to Oskar Liljeblad for the patch. Closes: #161294.
* debian/copyright: Update FSF address.
* Conforms to Standards version 3.6.2.
Files:
1a29a51d6a8b2b8e201026f74be28bd6 991 perl optional libgtk-perl_0.7009-4.dsc
d1018124656f67e384ed0193d92dbebe 113064 perl optional libgtk-perl_0.7009-4.diff.gz
16ccda55e5e5e51e72a08f5fe642b288 805044 perl optional libgtk-perl_0.7009-4_i386.deb
aa045c740f0c5be7e0da03d47f1cc045 57994 perl optional libgtk-imlib-perl_0.7009-4_i386.deb
b4400317a5ada1b06ce489320e8b7009 55590 perl optional libgtk-pixbuf-perl_0.7009-4_i386.deb
aef0939011370b14d2eb3cac63d58a96 271256 perl optional libgnome-perl_0.7009-4_i386.deb
4f91ae8a70f30fb42d6ae7f3cbb1323c 83142 perl optional libgnome-print-perl_0.7009-4_i386.deb
37efa76a0dcbc4c732ed20b883b77802 48412 perl optional libgtkglarea-perl_0.7009-4_i386.deb
fe1233d151783de890e847570d7298e1 48900 perl optional libgladexml-perl_0.7009-4_i386.deb
ef500f11111a241029d51cb5ebe76cb7 46652 perl optional libgtkxmhtml-perl_0.7009-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDH5aBxBYivKllgY8RAsbtAKDmJ1wOzZySwPXCsg6Yra8a0EFzTwCgvwXe
ZcDSju8a6RW+fd1EwtSubTM=
=y8wm
-----END PGP SIGNATURE-----
Reply to: