Bug#280569: marked as done (libtangram-perl: Tangram::PerlDump {normalize} typo)
Your message dated Fri, 02 Sep 2005 16:12:26 -0700
with message-id <87d5nrukrp.fsf@becket.becket.net>
and subject line Officially fixed
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 10 Nov 2004 09:46:16 +0000
>From jeri@bingo.dnsalias.org Wed Nov 10 01:46:16 2004
Return-path: <jeri@bingo.dnsalias.org>
Received: from adsl-63-195-16-136.dsl.chic01.pacbell.net (bingo.localdomain) [63.195.16.136]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CRp3Q-00008Z-00; Wed, 10 Nov 2004 01:46:16 -0800
Received: from jeri by bingo.localdomain with local (Exim 4.34)
id 1CRp2v-0000Kx-Cs; Wed, 10 Nov 2004 01:45:45 -0800
Content-Type: multipart/mixed; boundary="===============0168787477=="
MIME-Version: 1.0
From: Jeremiah Mahler <jeri@bingo.dnsalias.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: libtangram-perl: Tangram::PerlDump {normalize} typo
X-Mailer: reportbug 3.2
Date: Wed, 10 Nov 2004 01:45:45 -0800
Message-Id: <E1CRp2v-0000Kx-Cs@bingo.localdomain>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============0168787477==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: libtangram-perl
Version: 2.04-3.1
Severity: important
Tags: patch
As is shown by the script output below, a
schema that uses Tangram::PerlDump will not
work using a hash ref to define the perl_dump
field if 'col' is left undefined.
This is caused by a typo (normalize -> {normalize})
as is shown and fixed by the included patch.
Script started on Wed Nov 10 01:34:42 2004
jeri@bingo Tangram$ cat Tangram-normalize-col-BUG.pl
#!/usr/bin/perl
use strict;
use Tangram;
use Tangram::PerlDump;
package main;
my $schema = Tangram::Schema->new({
classes => [
Foo => {
fields => {
perl_dump => {
notok => {
sql => 'STRING',
},
ok => {
col => 'works',
sql => 'STRING',
}
},
},
},
],
});
print "OK\n";
jeri@bingo Tangram$ ./Tangram-normalize-col-BUG.pl
Can't locate object method "normalize" via package "Tangram::Schema" at /usr/sha
re/perl5/Tangram/PerlDump.pm line 46.
jeri@bingo Tangram$ exit
exit
Script done on Wed Nov 10 01:35:11 2004
### PATCH start ####
--- PerlDump.notok.pm 2001-09-21 10:47:22.000000000 -0700
+++ PerlDump.ok.pm 2004-11-10 01:30:12.000000000 -0800
@@ -43,7 +43,7 @@
die ref($self), ": $class\:\:$field: unexpected $refdef"
unless $refdef eq 'HASH';
- $def->{col} ||= $schema->normalize->($field, 'colname');
+ $def->{col} ||= $schema->{normalize}->($field, 'colname');
$def->{sql} ||= 'VARCHAR(255)';
$def->{indent} ||= 0;
$def->{terse} ||= 1;
### PATCH end ####
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.26-1-k7-smp
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages libtangram-perl depends on:
ii libdbi-perl 1.45-1 The Perl5 Database Interface by Ti
ii libset-object-perl 1.05-1 Collection of objects without dupl
ii perl 5.8.4-4 Larry Wall's Practical Extraction
-- no debconf information
--===============0168787477==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="Tangram-PerlDump.patch"
--- PerlDump.notok.pm 2001-09-21 10:47:22.000000000 -0700
+++ PerlDump.ok.pm 2004-11-10 01:30:12.000000000 -0800
@@ -43,7 +43,7 @@
die ref($self), ": $class\:\:$field: unexpected $refdef"
unless $refdef eq 'HASH';
- $def->{col} ||= $schema->normalize->($field, 'colname');
+ $def->{col} ||= $schema->{normalize}->($field, 'colname');
$def->{sql} ||= 'VARCHAR(255)';
$def->{indent} ||= 0;
$def->{terse} ||= 1;
--===============0168787477==--
---------------------------------------
Received: (at 280569-done) by bugs.debian.org; 2 Sep 2005 23:12:26 +0000
>From tb@becket.net Fri Sep 02 16:12:26 2005
Return-path: <tb@becket.net>
Received: from vp085189.reshsg.uci.edu (becket.becket.net) [128.195.85.189]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EBKhu-0000Vh-00; Fri, 02 Sep 2005 16:12:26 -0700
Received: from tb by becket.becket.net with local (Exim 4.52)
id 1EBKhu-0005ae-8t
for 280569-done@bugs.debian.org; Fri, 02 Sep 2005 16:12:26 -0700
From: Thomas Bushnell BSG <tb@becket.net>
To: 280569-done@bugs.debian.org
Subject: Officially fixed
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
X-Reply-Permission: Posted or emailed replies to this message constitute
permission for an emailed response.
X-PGP-Fingerprint: 1F0A1E51 63 28 EB DA E6 44 E5 5E EC F3 04 26 4E BF 1A 92
X-Tom-Swiftie: "Who drank the last beer?" Tom asked, hopping mad
Date: Fri, 02 Sep 2005 16:12:26 -0700
Message-ID: <87d5nrukrp.fsf@becket.becket.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: 280569-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 3
Version: 2.07-1
This NMU-fixed bug became closed when QA took over the package.
Reply to: