[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#202164: marked as done (stop using obsolete libweakref-perl module)



Your message dated Fri, 02 Sep 2005 16:12:55 -0700
with message-id <87br3bukqw.fsf@becket.becket.net>
and subject line Officially fixed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 20 Jul 2003 11:11:48 +0000
>From joey@kitenet.net Sun Jul 20 06:11:46 2003
Return-path: <joey@kitenet.net>
Received: from client132.fre.communitycolo.net (kitenet.net) [64.62.161.42] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19eC6T-0003ZX-00; Sun, 20 Jul 2003 06:11:45 -0500
Received: from dragon.kitenet.net (s95.ifi.uio.no [129.240.72.95])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(Client CN "Joey Hess", Issuer "Joey Hess" (verified OK))
	by kitenet.net (Postfix) with ESMTP id 230DCAA61A
	for <submit@bugs.debian.org>; Sun, 20 Jul 2003 11:11:45 +0000 (GMT)
Received: from joey by dragon.kitenet.net with local (Exim 3.35 #1 (Debian))
	id 19eC7i-0005Db-00
	for <submit@bugs.debian.org>; Sun, 20 Jul 2003 13:13:02 +0200
Date: Sun, 20 Jul 2003 13:13:01 +0200
From: Joey Hess <joey@kitenet.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: stop using obsolete libweakref-perl module
Message-ID: <20030720111301.GD19797@dragon.kitenet.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="orO6xySwJI16pVnm"
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Sender: Joey Hess <joey@dragon.kitenet.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-9.3 required=4.0
	tests=BAYES_01,PGP_SIGNATURE_2,USER_AGENT_MUTT
	version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20 (1.174.2.15-2003-03-30-exp)


--orO6xySwJI16pVnm
Content-Type: multipart/mixed; boundary="ZARJHfwaSJQLOEUz"
Content-Disposition: inline


--ZARJHfwaSJQLOEUz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: libtangram-perl
Version: unavailable; reported 2003-07-18
Severity: normal
Tags: patch

[ This is a resend, an expired TLS key caused the original to get lost. ]

The libweakref-perl module is obsolete, supersceded by Scalar::Utils's
weaken function in the perl core. We'd like to remove libweakref-perl
=66rom unstable, as soon as the two packages that use it are converted
over to use Scalar::Utils. Here is a patch that should do this, not very
well tested.

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux dragon 2.4.21 #1 Fri Jun 13 21:33:56 EDT 2003 i686
Locale: LANG=3DC, LC_CTYPE=3DC

--=20
see shy jo

--ZARJHfwaSJQLOEUz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="tangram.diff"
Content-Transfer-Encoding: quoted-printable

diff -ur old/libtangram-perl-2.04/Tangram/Storage.pm libtangram-perl-2.04/T=
angram/Storage.pm
--- old/libtangram-perl-2.04/Tangram/Storage.pm	2001-09-21 19:47:23.0000000=
00 +0200
+++ libtangram-perl-2.04/Tangram/Storage.pm	2003-07-18 10:07:40.000000000 +=
0200
@@ -10,14 +10,22 @@
=20
 BEGIN {
=20
-  eval { require 'WeakRef.pm' };
+  eval { use Scalar::Util };
=20
   if ($@) {
-    *Tangram::weaken =3D sub { };
-    $Tangram::no_weakrefs =3D 1;
-  } else {
-    *Tangram::weaken =3D \&WeakRef::weaken;
-    $Tangram::no_weakrefs =3D 0;
+    eval { require 'WeakRef.pm' };
+ =20
+    if ($@) {
+      *Tangram::weaken =3D sub { };
+      $Tangram::no_weakrefs =3D 1;
+    } else {
+      *Tangram::weaken =3D \&WeakRef::weaken;
+      $Tangram::no_weakrefs =3D 0;
+    }
+  }
+  else {
+      *Tangram::weaken =3D \&Scalr::Util::weaken;
+      $Tangram::no_weakrefs =3D 0;
   }
 }
=20
diff -ur old/libtangram-perl-2.04/debian/changelog libtangram-perl-2.04/deb=
ian/changelog
--- old/libtangram-perl-2.04/debian/changelog	2003-07-18 10:01:23.000000000=
 +0200
+++ libtangram-perl-2.04/debian/changelog	2003-07-18 10:08:35.000000000 +02=
00
@@ -1,3 +1,11 @@
+libtangram-perl (2.04-4) unstable; urgency=3Dlow
+
+  * Use Scalar::Utils for weakrefs when possible. Dropped suggests of obso=
lete
+    libweakref-perl package. Perl 5.8 is needed for Scalar::Utils, but did=
 not
+    change the dependency.
+
+ -- Joey Hess <joeyh@debian.org>  Fri, 18 Jul 2003 10:07:44 +0200
+
 libtangram-perl (2.04-3) unstable; urgency=3Dlow
=20
   * Really add Suggests: libweakref-ref to debian/control
diff -ur old/libtangram-perl-2.04/debian/control libtangram-perl-2.04/debia=
n/control
--- old/libtangram-perl-2.04/debian/control	2003-07-18 10:01:23.000000000 +=
0200
+++ libtangram-perl-2.04/debian/control	2003-07-18 10:02:26.000000000 +0200
@@ -8,7 +8,6 @@
 Package: libtangram-perl
 Architecture: all
 Depends: ${perl:Depends}, libset-object-perl, libdbi-perl
-Suggests: libweakref-perl
 Description: Orthogonal Object Persistence in Relational Databases
  Tangram is an object-relational mapper. It makes objects persist in
  relational databases, and provides powerful facilities for retrieving

--ZARJHfwaSJQLOEUz--

--orO6xySwJI16pVnm
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/Gnk93xwsXJZQhyMRAk/YAJ9I07lgqbQ+/dmXLOp2K+5rFFpIPwCfSm/E
7Nr7/UEcPqf1D5/U3+FYT2g=
=D+oF
-----END PGP SIGNATURE-----

--orO6xySwJI16pVnm--

---------------------------------------
Received: (at 202164-done) by bugs.debian.org; 2 Sep 2005 23:12:55 +0000
>From tb@becket.net Fri Sep 02 16:12:55 2005
Return-path: <tb@becket.net>
Received: from vp085189.reshsg.uci.edu (becket.becket.net) [128.195.85.189] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EBKiN-0000j4-00; Fri, 02 Sep 2005 16:12:55 -0700
Received: from tb by becket.becket.net with local (Exim 4.52)
	id 1EBKiN-0005aj-Re
	for 202164-done@bugs.debian.org; Fri, 02 Sep 2005 16:12:55 -0700
From: Thomas Bushnell BSG <tb@becket.net>
To: 202164-done@bugs.debian.org
Subject: Officially fixed
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
X-Reply-Permission: Posted or emailed replies to this message constitute
		 permission for an emailed response.
X-PGP-Fingerprint: 1F0A1E51  63 28 EB DA E6 44 E5 5E  EC F3 04 26 4E BF 1A 92
X-Tom-Swiftie: "Who drank the last beer?" Tom asked, hopping mad
Date: Fri, 02 Sep 2005 16:12:55 -0700
Message-ID: <87br3bukqw.fsf@becket.becket.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: 202164-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2


Version: 2.07-1

This NMU-fixed bug became closed when QA took over the package.



Reply to: