Bug#316648: marked as done (spell broken on ppc)
Your message dated Fri, 30 Sep 2005 14:56:32 +0200
with message-id <87r7b6iuin.fsf@diziet.irb.hr>
and subject line Bug#316648: fixed in spell 1.0-14
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Jul 2005 14:55:14 +0000
>From mostrows@watson.ibm.com Sat Jul 02 07:55:13 2005
Return-path: <mostrows@watson.ibm.com>
Received: from igw2.watson.ibm.com [129.34.20.6]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DojOj-0003DG-00; Sat, 02 Jul 2005 07:55:13 -0700
Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com [129.34.20.41])
by igw2.watson.ibm.com (8.13.1/8.13.1/8.13.1-2005-04-25 igw) with ESMTP id j62Eu8wl012240
for <submit@bugs.debian.org>; Sat, 2 Jul 2005 10:56:08 -0400
Received: from sp1n293en1.watson.ibm.com (localhost [127.0.0.1])
by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/01-14-2004_2) with ESMTP id j62Esg249038
for <submit@bugs.debian.org>; Sat, 2 Jul 2005 10:54:42 -0400
Received: from mgsmtp00.watson.ibm.com (mgsmtp00.watson.ibm.com [9.2.40.58])
by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/01-14-2004_1) with ESMTP id j62Esfl49036
for <submit@bugs.debian.org>; Sat, 2 Jul 2005 10:54:41 -0400
Received: from kitch0.watson.ibm.com ([9.2.224.107])
by mgsmtp00.watson.ibm.com (IMF.2005.06.27.0750.haw)
with SMTP ID IMFd1120315834.33866; Sat, 02 Jul 2005 10:50:34 -0400
Received: from brick.watson.ibm.com (brick.watson.ibm.com [9.2.216.48])
by kitch0.watson.ibm.com (AIX5.1/8.11.6p2/8.11.0/03-06-2002) with ESMTP id j62EseW45620
for <submit@bugs.debian.org>; Sat, 2 Jul 2005 10:54:40 -0400
Date: Sat, 2 Jul 2005 10:54:39 -0400
From: Michal Ostrowski <mostrows@watson.ibm.com>
To: submit@bugs.debian.org
Subject: spell broken on ppc
Message-ID: <20050702105439.10b315f0@brick.watson.ibm.com>
X-Mailer: Sylpheed-Claws 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/signed;
boundary=Signature_Sat__2_Jul_2005_10_54_39_-0400_KUjM+5_y7r9FgMfI;
protocol="application/pgp-signature"; micalg=pgp-sha1
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--Signature_Sat__2_Jul_2005_10_54_39_-0400_KUjM+5_y7r9FgMfI
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Package: spell
Version: 1.0-12
Spell use char type variables to store results from getopt_long and
getc, which are supposed to return int types. This results in error
conditions (such as EOF) not being detected properly. As a result,
spell hangs in an infinite loop (either due to failure to detect end of
options from getopt_long, or failre to detect EOF from getc). Patch
below fixes problems for me.
--- spell-1.0/spell.c 1996-04-10 00:41:09.000000000 -0400
+++ spell-1.0.local/spell.c 2005-07-02 10:49:54.000000000 -0400
@@ -159,7 +159,7 @@
int
main (int argc, char **argv)
{
- char opt =3D 0; /* Current option. */
+ int opt =3D 0; /* Current option. */
int opt_error =3D 0; /* Whether an option error occurred. */
int show_help =3D 0; /* Display help (--help, -h). */
int show_version =3D 0; /* Display the version (--version=
, -V). */
Only in spell-1.0.local/: spell.o
diff -r -u spell-1.0/str.c spell-1.0.local/str.c
--- spell-1.0/str.c 2005-07-02 10:50:29.000000000 -0400
+++ spell-1.0.local/str.c 2005-07-02 10:41:54.000000000 -0400
@@ -136,12 +136,12 @@
=20
while (1)
{
- register char c =3D getc (stream);
+ register int c =3D getc (stream);
=20
if (c =3D=3D EOF || ferror (stream))
return ADD_LINE_EOF;
- str_add_char (str, c);
- if (c =3D=3D '\n')
+ str_add_char (str, (char)c);
+ if ((char)c =3D=3D '\n')
break;
}
=20
--=20
Michal Ostrowski
--Signature_Sat__2_Jul_2005_10_54_39_-0400_KUjM+5_y7r9FgMfI
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFCxqqwDMDCqU5zPMARAqHeAKCNGQ12FZU3NzEGpPPu+ZBU7Wr2mACffVVV
6mklN+cFHaB4r22t7LM+nlQ=
=jq9E
-----END PGP SIGNATURE-----
--Signature_Sat__2_Jul_2005_10_54_39_-0400_KUjM+5_y7r9FgMfI--
---------------------------------------
Received: (at 316648-done) by bugs.debian.org; 30 Sep 2005 12:56:35 +0000
>From vela@debian.org Fri Sep 30 05:56:35 2005
Return-path: <vela@debian.org>
Received: from mail.irb.hr [161.53.22.8] (UNKNOWN)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1ELKRG-0003Im-00; Fri, 30 Sep 2005 05:56:34 -0700
Received: from diziet.irb.hr (diziet.irb.hr [161.53.22.31])
by mail.irb.hr (8.13.3/8.13.3/Debian-6) with ESMTP id j8UCuUNC009759
for <316648-done@bugs.debian.org>; Fri, 30 Sep 2005 14:56:30 +0200
Received: from diziet.irb.hr (localhost [127.0.0.1])
by diziet.irb.hr (8.13.5/8.13.5/Debian-1) with ESMTP id j8UCuWMT010113
for <316648-done@bugs.debian.org>; Fri, 30 Sep 2005 14:56:32 +0200
Received: (from mvela@localhost)
by diziet.irb.hr (8.13.5/8.13.5/Submit) id j8UCuWrI010111;
Fri, 30 Sep 2005 14:56:32 +0200
X-Authentication-Warning: diziet.irb.hr: mvela set sender to vela@debian.org using -f
From: Matej Vela <vela@debian.org>
To: 316648-done@bugs.debian.org
Subject: Bug#316648: fixed in spell 1.0-14
Date: Fri, 30 Sep 2005 14:56:32 +0200
Message-ID: <87r7b6iuin.fsf@diziet.irb.hr>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Scanned-By: MIMEDefang 2.51 on 161.53.22.8
Delivered-To: 316648-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: spell
Source-Version: 1.0-14
Hi,
Your patch was applied in spell 1.0-14.
Thanks!
Matej
Reply to: