[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#217029: marked as done (laptop-netconf: should use memcmp(), not strncmp(), to compare MAC addresses)

Your message dated Mon, 12 Sep 2005 17:32:03 -0700
with message-id <E1EEyiR-0001Ck-00@spohr.debian.org>
and subject line Bug#217029: fixed in laptop-netconf
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 22 Oct 2003 09:32:30 +0000
>From Sergio.Gelato@astro.su.se Wed Oct 22 04:32:30 2003
Return-path: <Sergio.Gelato@astro.su.se>
Received: from smtp2.su.se [] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ACFLx-0006qS-00; Wed, 22 Oct 2003 04:32:30 -0500
Received: from localhost (smtp2.su.se [])
	by smtp2.su.se (Postfix) with ESMTP id B7FD4200351
	for <submit@bugs.debian.org>; Wed, 22 Oct 2003 11:32:28 +0200 (CEST)
Received: from smtp2.su.se ([])
 by localhost (smtp2.su.se []) (amavisd-new, port 10024) with ESMTP
 id 28745-10 for <submit@bugs.debian.org>;
 Wed, 22 Oct 2003 11:32:28 +0200 (CEST)
Received: from as.astro.su.se (as.astro.su.se [])
	by smtp2.su.se (Postfix) with SMTP id 7FC8120034C
	for <submit@bugs.debian.org>; Wed, 22 Oct 2003 11:32:28 +0200 (CEST)
Received: (qmail 15505 invoked by alias); 22 Oct 2003 09:32:28 -0000
Received: (qmail 15498 invoked from network); 22 Oct 2003 09:32:28 -0000
Received: from hanuman.astro.su.se (user44091@
  by as.astro.su.se with SMTP; 22 Oct 2003 09:32:28 -0000
Received: from gelato by hanuman.astro.su.se with local (MasqMail
 0.1.16) id 1ACFLv-0Wh-00 for submit@bugs.debian.org; Wed, 22 Oct 2003
 11:32:27 +0200
Date: Wed, 22 Oct 2003 11:32:27 +0200
From: Sergio Gelato <Sergio.Gelato@astro.su.se>
To: submit@bugs.debian.org
Subject: laptop-netconf: should use memcmp(), not strncmp(), to compare MAC addresses
Message-ID: <20031022093227.GC1181@hanuman.astro.su.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Virus-Scanned: by amavisd-new at su.se
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_10_21 (

Package: laptop-netconf
Version: 0.9.6

There is a bug in laptop-netconf (both version 0.9.6 in testing/unstable,
and version 0.9-1.1 in woody) which can cause two different hardware
addresses to compare as equal.

laptop_netconf uses
	strncmp (cycle->hardware_address, arp_header->ar_sha, 6)
to compare hardware addresses. However, it is not uncommon for
MAC addresses to contain null bytes, especially in the first or
second position. In such cases, subsequent bytes will not be
looked at by strncmp().

The fix? Use memcmp() instead.

Received: (at 217029-close) by bugs.debian.org; 13 Sep 2005 00:38:05 +0000
>From katie@spohr.debian.org Mon Sep 12 17:38:05 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EEyiR-0001Ck-00; Mon, 12 Sep 2005 17:32:03 -0700
From: Matej Vela <vela@debian.org>
To: 217029-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#217029: fixed in laptop-netconf
Message-Id: <E1EEyiR-0001Ck-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Mon, 12 Sep 2005 17:32:03 -0700
Delivered-To: 217029-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: laptop-netconf

We believe that the bug you reported is fixed in the latest version of
laptop-netconf, which is due to be installed in the Debian FTP archive:

  to pool/main/l/laptop-netconf/laptop-netconf_0.9.6.3.dsc
  to pool/main/l/laptop-netconf/laptop-netconf_0.9.6.3.tar.gz
  to pool/main/l/laptop-netconf/laptop-netconf_0.9.6.3_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 217029@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Matej Vela <vela@debian.org> (supplier of updated laptop-netconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Tue, 13 Sep 2005 02:22:30 +0200
Source: laptop-netconf
Binary: laptop-netconf
Architecture: source i386
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Matej Vela <vela@debian.org>
 laptop-netconf - network detection and configuration program for laptops
Closes: 217029 327109
 laptop-netconf ( unstable; urgency=low
   * QA upload.
   * laptop-netconf.c (receive_arp_replies): Compare binary addresses
     using memcmp rather than strncmp.  Thanks to Sergio Gelato.
     Closes: #217029.
   * debian/po/cs.po: Add translation by Miroslav Kure.  Closes: #327109.
   * Conforms to Standards version 3.6.2.
 c2de2c72b7d1703d99414afafca886f8 552 net extra laptop-netconf_0.9.6.3.dsc
 26b452f164f23b8297086685ef7c5530 12545 net extra laptop-netconf_0.9.6.3.tar.gz
 41421f9c3d8bf7710553a4a7c224eba8 14068 net extra laptop-netconf_0.9.6.3_i386.deb

Version: GnuPG v1.4.1 (GNU/Linux)


Reply to: