Bug#321852: [Fwd: Log for successful build of guppi_0.40.3-12 (dist=unstable)]
Package: guppi
Version: 0.40.3-12
Severity: important
Tags: patch
Our automated buildd log filter[1] detected a problem that will cause
your package to segfault on architectures where the size of a pointer is
greater than the size of an integer, such as ia64.
guppi_seq_boolean_new() isn't defined in any header files I can find. I
do see a guppi_seq_boolean_new_aligned in
src/libguppidata/guppi-seq-boolean.c, but it is wrapped in an #ifdef 0.
Google finds a suggested fix here:
http://mail.gnome.org/archives/guppi-list/2004-February/msg00002.html
Though I can't remark on its correctness. The patch below implements
this suggestion and has been compile-tested.
[1]http://people.debian.org/~dannf/check-implicit-pointer-functions
--- guppi-0.40.3/plug-ins/plot/scatter/guppi-scatter-state.c~ 2002-01-20 19:35:16.000000000 -0700
+++ guppi-0.40.3/plug-ins/plot/scatter/guppi-scatter-state.c 2005-08-07 14:11:13.824384219 -0600
@@ -526,7 +526,7 @@
return;
if (mask_data == NULL) {
- mask_data = GUPPI_SEQ_BOOLEAN (guppi_seq_boolean_new ());
+ mask_data = GUPPI_SEQ_BOOLEAN (guppi_type_new (GUPPI_TYPE_SEQ_BOOLEAN));
guppi_scatter_state_set_mask_data (ss, mask_data);
}
@@ -571,7 +571,7 @@
return;
if (mask_data == NULL) {
- mask_data = GUPPI_SEQ_BOOLEAN (guppi_seq_boolean_new ());
+ mask_data = GUPPI_SEQ_BOOLEAN (guppi_type_new (GUPPI_TYPE_SEQ_BOOLEAN));
guppi_scatter_state_set_mask_data (ss, mask_data);
}
--
dann frazier <dannf@hp.com>
--- Begin Message ---
Function `guppi_seq_boolean_new' implicitly converted to pointer at guppi-scatter-state.c:529
--- End Message ---
Reply to: