[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#300669: marked as done (newspost: unexpected server response)



Your message dated Wed, 23 Mar 2005 04:32:36 -0500
with message-id <E1DE2E8-0001i7-00@newraff.debian.org>
and subject line Bug#300669: fixed in newspost 2.1.1-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Mar 2005 01:15:00 +0000
>From anibal@nukak.apana.org.au Sun Mar 20 17:14:59 2005
Return-path: <anibal@nukak.apana.org.au>
Received: from cpe-138-217-160-143.vic.bigpond.net.au (nukak.apana.org.au) [138.217.160.143] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DDBVT-0005cz-00; Sun, 20 Mar 2005 17:14:59 -0800
Received: by nukak.apana.org.au (Postfix, from userid 1000)
	id A43947B6CD; Mon, 21 Mar 2005 12:14:56 +1100 (EST)
Date: Mon, 21 Mar 2005 12:14:56 +1100
From: Anibal Monsalve Salazar <anibal@debian.org>
To: submit@bugs.debian.org
Subject: newspost: unexpected server response
Message-ID: <20050321011456.GM23313@debianrules.debiancolombia.org>
References: <20050321003832.41499.qmail@web13801.mail.yahoo.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="AQNmCumFClRcGgHG"
Content-Disposition: inline
In-Reply-To: <20050321003832.41499.qmail@web13801.mail.yahoo.com>
X-Debbugs-CC: Tong Sun <suntong001@yahoo.com>
User-Agent: Mutt/1.5.6+20040907i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--AQNmCumFClRcGgHG
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: newspost
Owner: Tong Sun <suntong001@yahoo.com>

On Sun, Mar 20, 2005 at 04:38:32PM -0800, Tong Sun wrote:
>--- Tong Sun <suntong001@yahoo.com> wrote:
>>First of all, thanks for this wonderful piece of tool.  I've tried
>
>Hi again Jim,
>
>Over a month ago, I reported a posting problem with newspost and
>teranews. The problem comes so often that I decided to look into it.
>The result, I have now a fix for a more robust newspost that will
>survive some insane news server status.
>
>The symptom was:
>
>-----
>| WARNING: unexpected server response: 240 Article Posted
>| Retrying
>| WARNING: unexpected server response: 240 Article Posted
>| Retrying
>| Socket error: Broken pipe
>`-----
>
>The "Broken pipe" error, causes the whole posting to a stop.=20
>
>The reason is that, the unexpected server response, "240 Article
>Posted" was not after the article posted, but right after issuing the
>POST command.=20
>
>I modified the base/nntp.c to reveal the error:
>
>- - - - >8 - - - -
>	if (strncmp(response, NNTP_PROCEED_WITH_POST, 3) !=3D 0) {
>		/* this shouldn't really happen */
>		fprintf(stderr,	"\ncase1 %02x %02x %02x, %s",
>			response[0], response[1], response[2], response);
>		ui_nntp_unknown_response(response);
>		return NORMAL;
>		return POSTING_FAILED;
>	}
>- - - - >8 - - - -
>
>- - - - >8 - - - -
>Posting part 67 of 78: done.                   =20
> case1 32 34 30, WARNING: unexpected server response: 240 Article
>Posted
>Posting part 68 of 78: done.                   =20
> case1 32 34 30, WARNING: unexpected server response: 240 Article
>Posted
>Posting part 69 of 78: done.                   =20
>[..]
>Posting part 71 of 78: done.                   =20
> case1 32 34 30, WARNING: unexpected server response: 240 Article
>Posted
>Posting part 72 of 78: done.                   =20
>
>Socket error: Broken pipe
>- - - - >8 - - - -
>
>The "case2" is before the other place that calls the "unexpected server
>response" procedure, which was never hit.
>
>You can see once the news server gets into this insane status, waiting
>and retrying won't help. So I change the program to reconnect if this
>"shouldn't really happen" happens.
>
>I kept the modification to the minimum, which is attached in the email.
>
>The minimum modification have proven to be very effective. I've noticed
>that it can resume posting successfully as many times as it requires
>during my post:
>
>Posting part 24 of 45: done.                   =20
>Posting part 25 of 45: done.                   =20
>
> 32 34 30, WARNING: unexpected server response: 240 Article Posted
>Retrying
>Connecting to free.teranews.com... done.
>Logging on to free.teranews.com... done.
>Posting part 26 of 45: done.                   =20
>
>Posting part 31 of 45: done.                   =20
>
> 32 34 30, WARNING: unexpected server response: 240 Article Posted
>Retrying
>Connecting to free.teranews.com... done.
>Logging on to free.teranews.com... done.
>Posting part 32 of 45: done.                   =20
>
>Posting part 82 of 86: done.                   =20
>
> 32 34 30, WARNING: unexpected server response: 240 Article Posted
>Retrying
>Connecting to free.teranews.com... done.
>Logging on to free.teranews.com... done.
>Posting part 83 of 86: done.                   =20
>
>I hope you can incorporate my modification in future version of
>newspost, so others can benefit from the modification also.=20
>
>Debian QA Group, I didn't get any feed back from Jim last time, could
>you help me correspond with me, or at least incorporate my modification
>in Debian please, since the last version was several years old, so it
>is safe to do so.
>
>thanks
>
>tong
>
>Content-Description: newspost-2.1.1-base-nntp.c.diff
>--- newspost-2.1.1/base/nntp.c	2003-04-23 11:33:23.000000000 -0400
>+++ ../newspost-2.1.1/base/nntp.c	2005-03-08 11:07:01.000000000 -0500
>@@ -80,2 +80,31 @@
> 	      boolean no_ui_updates) {
>+	int retval =3D _nntp_post(subject, data, buffer, length, no_ui_updates);
>+
>+	if (retval =3D=3D POSTING_FAILED-64) {
>+		/* try log out then back in */
>+		ui_nntp_posting_retry();
>+		nntp_logoff();
>+		socket_close();
>+		sleep(5);
>+
>+		/* create the socket */
>+		ui_socket_connect_start(data->address->data);
>+		retval =3D socket_create(data->address->data, data->port);
>+		if (retval < 0)
>+			return retval;
>+		ui_socket_connect_done();
>+
>+		ui_nntp_logon_start(data->address->data);
>+		if (nntp_logon(data) =3D=3D FALSE)
>+			return POSTING_FAILED;
>+		ui_nntp_logon_done();
>+
>+		retval =3D _nntp_post(subject, data, buffer, length, no_ui_updates);
>+		}
>+	return retval;
>+}
>+
>+int _nntp_post(const char *subject, newspost_data *data,=20
>+	      const char *buffer, long length,
>+	      boolean no_ui_updates) {
> 	char response[STRING_BUFSIZE];
>@@ -97,3 +126,3 @@
> 		ui_nntp_unknown_response(response);
>-		return POSTING_FAILED;
>+		return POSTING_FAILED-64;
> 	}

Anibal Monsalve Salazar
--
 .''`. Debian GNU/Linux
: :' : Free Operating System
`. `'  http://debian.org/
  `-   http://v7w.com/anibal

--AQNmCumFClRcGgHG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFCPiAQipBneRiAKDwRAquHAKCewtqorj94YtGypjgMJSrc4PSqPwCfREQ2
s1I3CLaIzBZLATFDO7XhuAA=
=B4T8
-----END PGP SIGNATURE-----

--AQNmCumFClRcGgHG--

---------------------------------------
Received: (at 300669-close) by bugs.debian.org; 23 Mar 2005 09:55:09 +0000
>From katie@ftp-master.debian.org Wed Mar 23 01:55:08 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DE2Zw-0007pk-00; Wed, 23 Mar 2005 01:55:08 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DE2E8-0001i7-00; Wed, 23 Mar 2005 04:32:36 -0500
From: Anibal Monsalve Salazar <anibal@debian.org>
To: 300669-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#300669: fixed in newspost 2.1.1-3
Message-Id: <E1DE2E8-0001i7-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 23 Mar 2005 04:32:36 -0500
Delivered-To: 300669-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: newspost
Source-Version: 2.1.1-3

We believe that the bug you reported is fixed in the latest version of
newspost, which is due to be installed in the Debian FTP archive:

newspost_2.1.1-3.diff.gz
  to pool/main/n/newspost/newspost_2.1.1-3.diff.gz
newspost_2.1.1-3.dsc
  to pool/main/n/newspost/newspost_2.1.1-3.dsc
newspost_2.1.1-3_i386.deb
  to pool/main/n/newspost/newspost_2.1.1-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 300669@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <anibal@debian.org> (supplier of updated newspost package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 23 Mar 2005 19:52:04 +1100
Source: newspost
Binary: newspost
Architecture: source i386
Version: 2.1.1-3
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Anibal Monsalve Salazar <anibal@debian.org>
Description: 
 newspost   - Usenet binary autoposter
Closes: 300669
Changes: 
 newspost (2.1.1-3) unstable; urgency=low
 .
   * QA Upload.
   * Fixed "unexpected server response", closes: #300669.
     Patch by Tong Sun <suntong001@yahoo.com>.
Files: 
 222d4fede7f4c742972d2d48035e5e70 571 news optional newspost_2.1.1-3.dsc
 c3df90c0955aed2337166aad2eb18dc3 2859 news optional newspost_2.1.1-3.diff.gz
 57a66c82544f0186f8626a0cff355cef 39758 news optional newspost_2.1.1-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFCQTNugY5NIXPNpFURAsxVAJ9c9hubQS4K+BnlwOPH4+6DLtQt0ACgnSc7
vJISvMKkfc7MCAMSJviGdFQ=
=pjKu
-----END PGP SIGNATURE-----



Reply to: