[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#235875: marked as done (rdiff-backup: AttributeError occurs when backup target is subdir of source)

Your message dated Wed, 16 Feb 2005 13:17:26 -0500
with message-id <E1D1Tjq-0002LY-00@newraff.debian.org>
and subject line Bug#235875: fixed in rdiff-backup 0.13.4-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 2 Mar 2004 22:35:54 +0000
>From mike@metalogue.com Tue Mar 02 14:35:54 2004
Return-path: <mike@metalogue.com>
Received: from c-24-118-136-148.mn.client2.attbi.com (rocky.home.metalogue.com) [] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AyIUU-0002vI-00; Tue, 02 Mar 2004 14:35:54 -0800
Received: from mike by rocky.home.metalogue.com with local (Exim 4.30)
	id 1AyIUQ-0002zd-Sw; Tue, 02 Mar 2004 16:35:50 -0600
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Mike McCallister <mike+debian@metalogue.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: rdiff-backup: AttributeError occurs when backup target is subdir of source
X-Mailer: reportbug 2.49
Date: Tue, 02 Mar 2004 16:35:50 -0600
Message-Id: <E1AyIUQ-0002zd-Sw@rocky.home.metalogue.com>
Sender: Mike McCallister <mike@metalogue.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_01 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 

Package: rdiff-backup
Version: 0.13.3.jgoerzen-3
Severity: normal

rdiff-backup appears to be coded to warn the user when the backup
destination is contained in the backup source.  Unfortunately, the
code that displays that error message seems to contain a typo or
thinko, because instead of the intended warning message, the user sees
the following text:

--------------------[ Start Error Text ]--------------------
########## /tmp/dirA /tmp
########## /tmp /tmp
Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 23, in ?
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 247, in Main
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 218, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 255, in Backup
    backup_check_dirs(rpin, rpout)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 301, in backup_check_dirs
    backup_warn_if_infinite_regress(rpin, rpout)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 334, in backup_warn_if_infinite_regress
    if Globals.backup_reader.Globals.select_source.Select(rpout): Log(
AttributeError: 'module' object has no attribute 'select_source'
--------------------[ End Error Text ]--------------------

To create output above, I used the following sequence of commands:

cd /tmp
mkdir dirA
mkdir dirA/backup
touch dirA/important_file
rdiff-backup --exclude dirA/backup dirA dirA/backup/folder

I don't understand Python code well enough to know what the proper fix
is, but looking at Globals.py, I see an attribute named
"backup_reader" and I see one named "select_mirror", but I don't see
one named "select_source".


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.22

Versions of packages rdiff-backup depends on:
ii  libc6                       2.3.2.ds1-10 GNU C Library: Shared libraries an
ii  librsync1                   0.9.6-8      Binary diff library based on the r
ii  python2.3                   2.3.3-6      An interactive high-level object-o
ii  rdiff                       0.9.6-8      Binary diff tool for signature-bas

-- no debconf information

Received: (at 235875-close) by bugs.debian.org; 16 Feb 2005 18:23:15 +0000
>From katie@ftp-master.debian.org Wed Feb 16 10:23:15 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1D1TpT-0000mq-00; Wed, 16 Feb 2005 10:23:15 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1D1Tjq-0002LY-00; Wed, 16 Feb 2005 13:17:26 -0500
From: Daniel Baumann <daniel.baumann@panthera-systems.net>
To: 235875-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#235875: fixed in rdiff-backup 0.13.4-4
Message-Id: <E1D1Tjq-0002LY-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 16 Feb 2005 13:17:26 -0500
Delivered-To: 235875-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 3

Source: rdiff-backup
Source-Version: 0.13.4-4

We believe that the bug you reported is fixed in the latest version of
rdiff-backup, which is due to be installed in the Debian FTP archive:

  to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4.diff.gz
  to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4.dsc
  to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 235875@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Daniel Baumann <daniel.baumann@panthera-systems.net> (supplier of updated rdiff-backup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Tue, 15 Feb 2005 18:29:00 +0100
Source: rdiff-backup
Binary: rdiff-backup
Architecture: source i386
Version: 0.13.4-4
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <daniel.baumann@panthera-systems.net>
Changed-By: Daniel Baumann <daniel.baumann@panthera-systems.net>
 rdiff-backup - incremental backups using binary deltas
Closes: 225471 225485 235875 241906 252960 256266 260018 261578 270715 277044
 rdiff-backup (0.13.4-4) unstable; urgency=low
   * New maintainer (Closes: #261578).
   * Took over Alec Berrymans <alec@thened.net> interim package.
   * debian/* redone and updated to new policy.
   * debian/control: added correct python depency (Closes: #252960).
   * Added rdiff-backup-hardlinks.dpatch to insure flag '--no-hard-links' is not
     overridden by filesystem abilities and to fix handling of hard links on Mac
     OS X (Thanks to Dave Vasilevsky <djvasi@gmail.com>).
   * Added typo-fix.dpatch to fix an error message typo (Thanks to Thomas Jarosch
   * Added patch from CVS to fix broken '--calculate-average' flag (Thanks to
     Dean Gaudet <dean@arctic.org>, Closes: #241906, #225471, #225485).
   * Patched hard link test with afs-hardlinks.dpatch to only enable hard links
     if able to link across directories. AFS only allows hard links within a
     directory (Closes: #260018).
   * Patched error message thrown when invoking after an unsuccessful backup with
     typo-fix-2.dpatch (Closes: #256266).
   * Added patch backup_warn_if_infinite_regress.dpatch backported from CVS to
     fix handling of destination directory as subdirectories of source directory
     (Closes: #235875).
   * Patched types of files not to be compressed with no-compress-regexp.dpatch
     (Closes: #270715).
   * Added patch restrict-read-only.dpatch to correct the behavior of the
     '--restrict-read-only' flag to bring it in line with the documented behavior
     (Thanks to Dean Gaudet <dean@arctic.org>, Closes: #277044).
 a06092300c15b2b5530eebe828eade39 724 utils optional rdiff-backup_0.13.4-4.dsc
 ba4818732f83a92a3acd4decd2b6ddba 7849 utils optional rdiff-backup_0.13.4-4.diff.gz
 22d0f5daf9a6aa93b2951787602ed375 31142 utils optional rdiff-backup_0.13.4-4_i386.deb

Version: GnuPG v1.2.5 (GNU/Linux)


Reply to: