Bug#188612: marked as done (ucbmpeg: bashism in debian/rules file)
Your message dated Sat, 27 Nov 2004 23:31:45 +0100
with message-id <20041127223145.GA9115@fermi.df7cb.de>
and subject line Bug#188612: ucbmpeg: bashism in debian/rules file
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Apr 2003 16:58:49 +0000
>From undefined@pobox.com Fri Apr 11 11:58:48 2003
Return-path: <undefined@pobox.com>
Received: from snipe.mail.pas.earthlink.net [207.217.120.62]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 1941rU-0000F6-00; Fri, 11 Apr 2003 11:58:48 -0500
Received: from dialup-67.31.253.140.dial1.dallas1.level3.net ([67.31.253.140] helo=localhost.localdomain)
by snipe.mail.pas.earthlink.net with esmtp (Exim 3.33 #1)
id 1941rS-0002qR-00
for submit@bugs.debian.org; Fri, 11 Apr 2003 09:58:46 -0700
Subject: ucbmpeg: bashism in debian/rules file
From: Corey Wright <undefined@pobox.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Content-Type: multipart/mixed; boundary="=-Z725RS6aKItAEsW0YDg0"
X-Mailer: Ximian Evolution 1.0.5
Date: 11 Apr 2003 11:58:44 -0500
Message-Id: <1050080326.5891.4.camel@deuteronomy>
Mime-Version: 1.0
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-1.1 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SPAM_PHRASE_02_03
version=2.44
X-Spam-Level:
--=-Z725RS6aKItAEsW0YDg0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Package: ucbmpeg
Version: 1r2-9
Severity: important
Tags: patch
the debian/rules make file contains at least one bashism. this is fine except
that debian policy allows for ash to provide /bin/sh, and ash does not support
bashisms.
the specific bashism i encountered was the use of brace expansion (see bash
manpage).
to allow for bashisms, in the patch i simply explicitly told make to use bash
by setting the SHELL environment variable.
the more cumbersome (but portable) solution would be to remove the bashism(s).
thanks for your hard work on this package.
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux deuteronomy 2.4.18-printer #1 Mon Feb 24 23:19:31 CST 2003 i686
Locale: LANG=C, LC_CTYPE=C
Versions of packages ucbmpeg depends on:
ii libc6 2.2.5-11.2 GNU C Library: Shared libraries an
ii netpbm 2:9.20-8.2 Graphics conversion tools.
ii tcl8.0 8.0.5-6 The Tool Command Language (TCL) v8
ii tk8.0 8.0.5-9 The Tk toolkit for TCL and X11 v8.
ii xlibs 4.1.0-16 X Window System client libraries
--=-Z725RS6aKItAEsW0YDg0
Content-Disposition: attachment; filename=ucbmpeg_1r2-9.patch
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; name=ucbmpeg_1r2-9.patch; charset=ISO-8859-15
--- ucbmpeg-1r2.orig/debian/rules Fri Apr 11 11:44:12 2003
+++ ucbmpeg-1r2/debian/rules Fri Apr 11 11:35:23 2003
@@ -2,6 +2,8 @@
# Made with the aid of debmake, by Christoph Lameter,
# based on the sample debian/rules file for GNU hello by Ian Jackson.
=20
+SHELL=3D/bin/bash
+
package=3Ducbmpeg
=20
CCOPTS =3D -O2 -DSIG_ONE_PARAM
--=-Z725RS6aKItAEsW0YDg0--
---------------------------------------
Received: (at 188612-done) by bugs.debian.org; 27 Nov 2004 22:32:37 +0000
>From cb@fermi.df7cb.de Sat Nov 27 14:32:37 2004
Return-path: <cb@fermi.df7cb.de>
Received: from indyio.rz.uni-saarland.de [134.96.7.3]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CYB7M-0005J8-00; Sat, 27 Nov 2004 14:32:37 -0800
Received: from fermi.dyndns.info (mars.rz.uni-saarland.de [134.96.7.4])
by indyio.rz.uni-saarland.de (8.12.10/8.12.10) with ESMTP id iARMW3c825162640
for <188612-done@bugs.debian.org>; Sat, 27 Nov 2004 23:32:04 +0100 (CET)
Received: by fermi.dyndns.info (Postfix, from userid 1000)
id D675A7E5FA; Sat, 27 Nov 2004 22:31:45 +0000 (UTC)
Date: Sat, 27 Nov 2004 23:31:45 +0100
From: Christoph Berg <cb@df7cb.de>
To: 188612-done@bugs.debian.org
Subject: Re: Bug#188612: ucbmpeg: bashism in debian/rules file
Message-ID: <20041127223145.GA9115@fermi.df7cb.de>
Mail-Followup-To: Christoph Berg <cb@df7cb.de>,
188612-done@bugs.debian.org
References: <1050080326.5891.4.camel@deuteronomy> <20030412075947.GA20797@chrystal.opal.dhs.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
In-Reply-To: <20030412075947.GA20797@chrystal.opal.dhs.org>
User-Agent: Mutt/1.5.6+20040907i
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.1 (indyio.rz.uni-saarland.de [134.96.7.3]); Sat, 27 Nov 2004 23:32:04 +0100 (CET)
X-AntiVirus: checked by AntiVir Milter 1.0.6; AVE 6.28.0.19; VDF 6.28.0.93
Delivered-To: 188612-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Re: Ola Lundqvist in <20030412075947.GA20797@chrystal.opal.dhs.org>
> Thanks for the patch.
This was fixed in 1r2-10 but not noted in the changelog.
Christoph
--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iQCVAwUBQakAULRrkjttir5xAQFplgP+KyNH13kujfq+A/XA0EXXPAZoUKY/ZUez
OAqo3Luem6dWH2FU5P1t5Izs3qBm0DLUvwXQ+CrZe6cy1Bqvt9Rjp5DojxtnsT28
8U32qgRgC2zb8Lfl2w1K67fmO/RHlWuVVNKZDMviD+WSJiQ7qbuijvxcF0ABGfuz
AAKq2OeH7IM=
=rqGk
-----END PGP SIGNATURE-----
--Kj7319i9nmIyA2yE--
Reply to: