Bug#188230: marked as done (bug in xtrlock)
Your message dated 07 Aug 2004 22:04:19 -0700
with message-id <87ekmikyp8.fsf@becket.becket.net>
and subject line bug in xtrlock
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Apr 2003 17:57:32 +0000
>From srakyi@centrum.cz Tue Apr 08 12:57:31 2003
Return-path: <srakyi@centrum.cz>
Received: from mail1.centrum.cz [62.84.131.173]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 192xLe-0006uO-00; Tue, 08 Apr 2003 12:57:31 -0500
Received: by mail.centrum.cz id <S1603465AbTDHR4a>;
Tue, 8 Apr 2003 19:56:30 +0200
Date: Tue, 08 Apr 2003 19:56:30 +0200
From: <srakyi@centrum.cz>
To: <submit@bugs.debian.org>
X-Mailer: Centrum Mail 1.0
MIME-Version: 1.0
X-Priority: 3
Subject: bug in xtrlock
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Message-Id: <20030408175632Z1603465-2468+5555@mail.centrum.cz>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-0.1 required=4.0
tests=HAS_PACKAGE,NO_REAL_NAME,PATCH_UNIFIED_DIFF,
SPAM_PHRASE_01_02,SUPERLONG_LINE
version=2.44
X-Spam-Level:
Package: xtrlock
Version: 2.0
When the screen is locked and you write a "bit more" characters (e.g. by holding some key for about 2 minutes) and press Enter after that, xtrlock crashes hence the screen is unlocked now.
I thing the problem is in rlen, that is increased on any keypress and after LF is to rbuf[rlen] written 0. But rlen can be real great number at this moment and rbuf[rlen] can point to part of memory we hadn't access ..
Following patch should fix the bug:
####BEGINING OF THE PATCH####
--- xtrlock.c 1997-10-22 12:32:28.000000000 +0200
+++ xtrlock.c 2003-04-08 19:41:12.000000000 +0200
@@ -14,6 +14,9 @@
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
+ *
+ * .. overflow bug patched by srakyi (http://srakyi.modry.cz) - no warranty
+ *
*/
#include <X11/X.h>
@@ -191,8 +194,10 @@
break;
default:
if (clen != 1) break;
- if (rlen < sizeof(rbuf)) rbuf[rlen]= cbuf[0];
- rlen++;
+ if (rlen < sizeof(rbuf)) {
+ rbuf[rlen]= cbuf[0];
+ rlen++;
+ }
break;
}
break;
####END OF THE PATCH####
---------------------------------------
Received: (at 188230-done) by bugs.debian.org; 8 Aug 2004 05:04:19 +0000
>From tb@becket.net Sat Aug 07 22:04:19 2004
Return-path: <tb@becket.net>
Received: from vp085189.reshsg.uci.edu (becket.becket.net) [128.195.85.189]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Btfr1-00032A-00; Sat, 07 Aug 2004 22:04:19 -0700
Received: from tb by becket.becket.net with local (Exim 4.34)
id 1Btfr1-0001Oa-1l; Sat, 07 Aug 2004 22:04:19 -0700
To: 188230-done@bugs.debian.org, srakyi@centrum.cz
Subject: bug in xtrlock
X-Reply-Permission: Posted or emailed replies to this message constitute
permission for an emailed response.
X-PGP-Fingerprint: 1F0A1E51 63 28 EB DA E6 44 E5 5E EC F3 04 26 4E BF 1A 92
X-Tom-Swiftie: "I just sharpened my pencil," Tom said pointedly
From: Thomas Bushnell BSG <tb@becket.net>
Date: 07 Aug 2004 22:04:19 -0700
Message-ID: <87ekmikyp8.fsf@becket.becket.net>
Lines: 5
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: 188230-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
This bug was fixed in version 2.0-6.1 of xtrlock.
Thomas
Reply to: