[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#217800: marked as done (metalog: bad management of init scripts in control files)



Your message dated Wed, 14 Jan 2004 23:03:19 +0000
with message-id <20040114230319.GA9054@deprecation.cyrius.com>
and subject line Removed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Oct 2003 14:17:17 +0000
>From gpcarrubba@libero.it Mon Oct 27 08:17:16 2003
Return-path: <gpcarrubba@libero.it>
Received: from ppp-56-154.24-151.libero.it (cancan) [151.24.154.56] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AE8BD-00048c-00; Mon, 27 Oct 2003 08:17:16 -0600
Received: from king.fdc (king.fdc [192.168.1.250])
	by cancan (Postfix) with ESMTP
	id C48C52A081; Mon, 27 Oct 2003 15:16:42 +0100 (CET)
Received: from gpiero by king.fdc with local (Exim 3.36 #1 (Debian))
	id 1AE8Al-0003I7-00; Mon, 27 Oct 2003 15:16:43 +0100
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Gian Piero Carrubba <gpcarrubba@libero.it>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: metalog: bad management of init scripts in control files
X-Mailer: reportbug 2.35
Date: Mon, 27 Oct 2003 15:16:43 +0100
Message-Id: <E1AE8Al-0003I7-00@king.fdc>
Sender: Gian Piero Carrubba <gpiero@king.fdc>
X-BadReturnPath: gpiero@king.fdc rewritten as gpcarrubba@libero.it
  using "From" header
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0
	tests=HAS_PACKAGE
	version=2.53-bugs.debian.org_2003_10_21
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_10_21 (1.174.2.15-2003-03-30-exp)

Package: metalog
Version: 0.7beta-3
Severity: normal

Sorry if i report 2 bugs in 1 message, but they seem to me someway
correlate.

First of all, the package seems not to use invoke-rc.d:

$ grep -n /etc/init.d/ /var/lib/dpkg/info/metalog.p*
/var/lib/dpkg/info/metalog.postinst:7:  /etc/init.d/metalog start >&2
/var/lib/dpkg/info/metalog.postinst:11:         /etc/init.d/metalog restart >&2
/var/lib/dpkg/info/metalog.prerm:6:     /etc/init.d/metalog stop

It's not a serious policy violation as it's not a "must" or a "should",
but use of invoke-rc.d is "strongly recommended" (debian policy 3.6.10,
par. 9.3.3.2).

Second and more "serious" bug:

$ grep -n update-rc.d /var/lib/dpkg/info/metalog.postinst
6:      update-rc.d metalog start 10 0 1 2 3 4 5 6 . stop 90 0 1 2 3 4 5 6 . >/dev/null 2>&1

$ ls /etc/rc?.d/*metalog
/etc/rc0.d/K90metalog  /etc/rc2.d/S10metalog  /etc/rc5.d/K90metalog
/etc/rc0.d/S10metalog  /etc/rc3.d/K90metalog  /etc/rc5.d/S10metalog
/etc/rc1.d/K90metalog  /etc/rc3.d/S10metalog  /etc/rc6.d/K90metalog
/etc/rc1.d/S10metalog  /etc/rc4.d/K90metalog  /etc/rc6.d/S10metalog
/etc/rc2.d/K90metalog  /etc/rc4.d/S10metalog

Unless perhaps for a bug in the binary (but i haven't found trace of
it), there should not be any reason to stop and restart the daemon every
time you change runlevel. However, rl 0 and 6 should contain only one
symlink, otherwise the init script is called twice (both with stop
action, as in these runlevels the S or K prefix isn't relevant).

I think line 6 in metalog.postinst could be substituted by:
update-rc.d metalog defaults 10 90 >/dev/null 2>&1


Thanks,
Gian Piero.

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux king 2.4.22 #1 lun set 29 16:17:11 CEST 2003 i686
Locale: LANG=it_IT@euro, LC_CTYPE=it_IT@euro

Versions of packages metalog depends on:
ii  libc6                         2.3.2-8    GNU C Library: Shared libraries an
ii  libpcre3                      4.3-3      Philip Hazel's Perl 5 Compatible R

-- no debconf information


---------------------------------------
Received: (at 217800-done) by bugs.debian.org; 14 Jan 2004 23:03:54 +0000
>From tbm@cyrius.com Wed Jan 14 17:03:54 2004
Return-path: <tbm@cyrius.com>
Received: from bangpath.uucico.de [195.71.9.197] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Agu3G-0004Ki-00; Wed, 14 Jan 2004 17:03:54 -0600
Received: by bangpath.uucico.de (Postfix, from userid 10)
	id A22E426B9E; Thu, 15 Jan 2004 00:03:53 +0100 (CET)
Received: by deprecation.cyrius.com (Postfix, from userid 1000)
	id C348AFF05; Wed, 14 Jan 2004 23:03:19 +0000 (GMT)
Date: Wed, 14 Jan 2004 23:03:19 +0000
From: Martin Michlmayr <tbm@cyrius.com>
To: 168900-done@bugs.debian.org, 168902-done@bugs.debian.org,
	182753-done@bugs.debian.org, 182754-done@bugs.debian.org,
	188389-done@bugs.debian.org, 209219-done@bugs.debian.org,
	217800-done@bugs.debian.org, 218723-done@bugs.debian.org,
	222848-done@bugs.debian.org
Subject: Removed
Message-ID: <20040114230319.GA9054@deprecation.cyrius.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Delivered-To: 217800-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_01_14 
	(1.212-2003-09-23-exp) on master.debian.org
X-Spam-Status: No, hits=3.8 required=4.0 tests=SORTED_RECIPS autolearn=no 
	version=2.60-bugs.debian.org_2004_01_14
X-Spam-Level: ***

This package has been removed from Debian unstable because it was
unmaintained, old and according to the maintainer quite obsolte and
useless.

-- 
Martin Michlmayr
tbm@cyrius.com



Reply to: