Bug#173015: marked as done (jpegoptim: Several minor code problems)
Your message dated Wed, 14 Jan 2004 23:03:05 +0000
with message-id <20040114230305.GA9038@deprecation.cyrius.com>
and subject line Removed
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Dec 2002 11:00:25 +0000
>From kreutzm@itp.uni-hannover.de Sat Dec 14 05:00:24 2002
Return-path: <kreutzm@itp.uni-hannover.de>
Received: from mgate3.rrzn.uni-hannover.de [130.75.2.31] (root)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18NA1v-0001D9-00; Sat, 14 Dec 2002 05:00:23 -0600
Received: from wega.itp.uni-hannover.de (wega.itp.uni-hannover.de [130.75.25.64])
by mgate3.rrzn.uni-hannover.de (8.12.6/8.12.6) with ESMTP id gBEB0Iau028466;
Sat, 14 Dec 2002 12:00:18 +0100 (MET)
Received: from mirzam.itp.uni-hannover.de (mirzam.itp.uni-hannover.de [130.75.25.94])
by wega.itp.uni-hannover.de (AIX4.3/UCB 8.8.8/8.8.8) with ESMTP id MAA22760;
Sat, 14 Dec 2002 12:00:17 +0100
Received: (from kreutzm@localhost)
by mirzam.itp.uni-hannover.de (8.11.6/8.9.3) id gBEB0Hm14270;
Sat, 14 Dec 2002 12:00:17 +0100
Date: Sat, 14 Dec 2002 12:00:17 +0100
From: Helge Kreutzmann <kreutzm@itp.uni-hannover.de>
To: submit@bugs.debian.org
Cc: Timo <tjko@jyu.fi>
Subject: jpegoptim: Several minor code problems
Message-ID: <20021214110017.GA14197@itp.uni-hannover.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-Public-Key-URL: http://www.itp.uni-hannover.de/~kreutzm/data/kreutzm.gpg
X-homepage: http://www.itp.uni-hannover.de/~kreutzm
X-Scanned-By: MIMEDefang 2.24 (www . roaringpenguin . com / mimedefang)
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-7.8 required=5.0
tests=PATCH_UNIFIED_DIFF,SIGNATURE_SHORT_DENSE,SPAM_PHRASE_00_01,
USER_AGENT,USER_AGENT_MUTT
version=2.41
X-Spam-Level:
Package: jpegoptim
Version: 1.1-1
Severity: normal
Tags: patch
While compiling this package on alpha, I noted some assignement
problems (64 bit issues). To track them down I added -Wall and fixed
all errors reported/I understood.
The patch does the following
a) enable -Wall (I think it's usefull, but you can of course leave it as is)
b) Consequently enable debug - it makes no sense to honor -g but to
always strip the binary
c) ligen.h is also needed on linux
d) file_size must return long
e) fgetpos has some int/long issues which I couldn't track down; this
is fixed by using ftell; but please double check it
f) Some printf's had wrong formating identifiers; fixed.
I still get lots of
jpegoptim.c:228: warning: variable `total_save' might be clobbered by
`longjmp' or `vfork'
but I've no idea what they want to tell me.
-- System Information
Debian Release: 3.0
Architecture: alpha
Kernel: Linux sixtyfor 2.4.17 #1 Mon Feb 25 21:41:29 CET 2002 alpha
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro
Versions of packages jpegoptim depends on:
ii libc6.1 2.2.5-11.2 GNU C Library: Shared libraries an
ii libjpeg62 6b-5 The Independent JPEG Group's JPEG
diff -ur jpegoptim-1.1.orig/Makefile jpegoptim-1.1.new/Makefile
--- jpegoptim-1.1.orig/Makefile Wed Dec 11 21:44:36 2002
+++ jpegoptim-1.1.new/Makefile Tue Dec 10 21:02:06 2002
@@ -27,7 +27,7 @@
LIBDIRS = # -L/usr/local/lib
CC = gcc
-CFLAGS = -O2 $(DEFINES) $(INCLUDES) # -N
+CFLAGS = -O2 -Wall $(DEFINES) $(INCLUDES) # -N
LIBS = -ljpeg $(LIBDIRS)
STRIP = strip
diff -ur jpegoptim-1.1.orig/Makefile.Linux jpegoptim-1.1.new/Makefile.Linux
--- jpegoptim-1.1.orig/Makefile.Linux Wed Dec 11 21:44:36 2002
+++ jpegoptim-1.1.new/Makefile.Linux Tue Dec 10 21:02:06 2002
@@ -27,7 +27,7 @@
LIBDIRS = # -L/usr/local/lib
CC = gcc
-CFLAGS = -O2 $(DEFINES) $(INCLUDES) # -N
+CFLAGS = -O2 -Wall $(DEFINES) $(INCLUDES) # -N
LIBS = -ljpeg $(LIBDIRS)
STRIP = strip
diff -ur jpegoptim-1.1.orig/debian/rules jpegoptim-1.1.new/debian/rules
--- jpegoptim-1.1.orig/debian/rules Wed Dec 11 21:44:36 2002
+++ jpegoptim-1.1.new/debian/rules Tue Dec 10 21:34:59 2002
@@ -53,7 +53,9 @@
dh_installdirs
# Add here commands to install the package into debian/jpegoptim.
+ifeq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
$(MAKE) strip
+endif
$(MAKE) install DESTDIR=$(CURDIR)/debian/jpegoptim
@@ -69,7 +71,9 @@
dh_installman
dh_installchangelogs
dh_link
+ifeq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
dh_strip
+endif
dh_compress
dh_fixperms
dh_makeshlibs
diff -ur jpegoptim-1.1.orig/jpegoptim.c jpegoptim-1.1.new/jpegoptim.c
--- jpegoptim-1.1.orig/jpegoptim.c Thu Oct 24 14:04:47 1996
+++ jpegoptim-1.1.new/jpegoptim.c Wed Dec 11 21:17:25 2002
@@ -25,6 +25,9 @@
#ifdef SGI
#include <libgen.h>
#endif
+#ifdef LINUX
+#include <libgen.h>
+#endif
#define VERSIO "1.1"
@@ -146,14 +149,19 @@
return retval;
}
-int file_size(FILE *fp)
+long file_size(FILE *fp)
{
long size=0,save=0;
-
- fgetpos(fp,&save);
+
+ save=ftell(fp);
fseek(fp,0L,SEEK_END);
- fgetpos(fp,&size);
+ size=ftell(fp);
fseek(fp,save,SEEK_SET);
+
+// fgetpos(fp,&save);
+// fseek(fp,0L,SEEK_END);
+// fgetpos(fp,&size);
+// fseek(fp,save,SEEK_SET);
return size;
}
@@ -469,7 +478,7 @@
retry=0;
ratio=(insize-outsize)*100.0/insize;
- printf("%d --> %d bytes (%0.2lf%%), ",insize,outsize,ratio);
+ printf("%li --> %li bytes (%0.2f%%), ",insize,outsize,ratio);
average_count++;
average_rate+=(ratio<0 ? 0.0 : ratio);
@@ -496,8 +505,8 @@
if (noaction && file_exists(outfname)) delete_file(outfname);
if (totals_mode&&!quiet_mode)
- printf("Average ""compression"" (%ld files): %0.2lf%% (%0.0lfk)\n",
- average_count, average_rate/average_count, total_save);
+ printf("Average ""compression"" (%ld files): %0.2f%% (%0.0fk)\n",
+ average_count, (double)average_rate/average_count, total_save);
jpeg_destroy_decompress(&dinfo);
jpeg_destroy_compress(&cinfo);
return 0;
--
Helge Kreutzmann, Dipl.-Phys. Helge.Kreutzmann@itp.uni-hannover.de
gpg signed mail preferred gpg-key: finger kreutzm@rigel.itp.uni-hannover.de
64bit GNU powered http://www.itp.uni-hannover.de/~kreutzm
Help keep free software "libre": http://www.freepatents.org/
---------------------------------------
Received: (at 173015-done) by bugs.debian.org; 14 Jan 2004 23:03:41 +0000
>From tbm@cyrius.com Wed Jan 14 17:03:40 2004
Return-path: <tbm@cyrius.com>
Received: from bangpath.uucico.de [195.71.9.197]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Agu32-0004Cz-00; Wed, 14 Jan 2004 17:03:40 -0600
Received: by bangpath.uucico.de (Postfix, from userid 10)
id CB55926B9E; Thu, 15 Jan 2004 00:03:39 +0100 (CET)
Received: by deprecation.cyrius.com (Postfix, from userid 1000)
id E8011FF05; Wed, 14 Jan 2004 23:03:05 +0000 (GMT)
Date: Wed, 14 Jan 2004 23:03:05 +0000
From: Martin Michlmayr <tbm@cyrius.com>
To: 173015-done@bugs.debian.org, 171262-done@bugs.debian.org,
202700-done@bugs.debian.org, 222961-done@bugs.debian.org
Subject: Removed
Message-ID: <20040114230305.GA9038@deprecation.cyrius.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Delivered-To: 173015-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_01_14
(1.212-2003-09-23-exp) on master.debian.org
X-Spam-Status: No, hits=0.0 required=4.0 tests=none autolearn=no
version=2.60-bugs.debian.org_2004_01_14
X-Spam-Level:
This package has been removed from Debian unstable because it was
unmaintained, old and according to the maintainer quite obsolte and
useless.
--
Martin Michlmayr
tbm@cyrius.com
Reply to: