[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#226711: [PATCH] fix off-by-one-line behavior in example bot after saving



Matt Behrens wrote:
> > > --- /usr/share/doc/megahal/examples/Hal.pm      2000-09-01 13:36:58.000000000 -0400
> > > +++ Hal.pm      2004-01-07 16:04:26.000000000 -0500
> > > @@ -86,7 +86,7 @@
> > >  # Save brain.
> > >  sub save {
> > >         $wselect->can_write();
> > > -       syswrite(WRITE,"#save\n\n",8);
> > > +       syswrite(WRITE,"#quiet\n\n#save\n\n#quiet\n\n");
> 
> > According to http://www.perldoc.com/perl5.8.0/pod/func/syswrite.html the
> > third value is optional. I'd like to verify that loading the brain works
> > before we add this upstream.
> 
> It has for me; I've been running a megahal bot on a little IRC
> server a friend runs for a couple days now and have already moved
> it between three machines, brain intact.
> 
> I did catch the bit about the optional param, which is why I omitted
> it.  Joey, if you can remember writing this script (from the megahal
> examples directory), was there a reason syswrite's third parameter
> was needed?

syswrite has never been a part of perl I was comfortable with; I
probably added the parameter because I thought it behaved like write().
It's also possible that perl used to require the length parameter.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: