[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#189391: fwanalog: Non-Bourneism in /usr/sbin/fwanalog

Package: fwanalog
Version: 0.5.1-1
Severity: important
Tags: patch

People whose /bin/sh is bash won't have noticed this problem, but my /bin/sh
is ash which helps to spot mistakes like this. /usr/sbin/fwanalog contains:
  source /etc/fwanalog/fwanalog.opts
'source' is a csh command (which happens to also be implemented in some
other shells, but shouldn't be relied on if the #! says /bin/sh)
The correct sh command is . (dot) 

--- fwanalog.orig       Fri Mar 29 06:11:09 2002
+++ fwanalog    Fri Apr 18 11:30:09 2003
@@ -672,7 +672,7 @@
 #      echo "Note: rotating is not necessary anymore!"
        # Load the user-settable options from the config file
-       source /etc/fwanalog/fwanalog.opts
+       . /etc/fwanalog/fwanalog.opts
        # Month and year as they appear in the web server log
        grepdate=`$date +/%b/%Y:`

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux schottky 2.4.19 #2 Wed Apr 16 10:29:15 BST 2003 i586

Versions of packages fwanalog depends on:
ii  analog           2:5.23-0woody1          analyzes logfiles from web servers
ii  debconf          1.0.32                  Debian configuration management sy
ii  grep             2.4.2-3                 GNU grep, egrep and fgrep.
ii  gzip             1.3.2-3                 The GNU compression utility.
ii  mailx            1:8.1.2-0.20020411cvs-1 A simple mail user agent.
ii  perl             5.6.1-8.2               Larry Wall's Practical Extraction 
ii  textutils        2.0-12                  The GNU text file processing utili

Reply to: