[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#166498: websec: patches



Package: websec
Version: 1.3.4-9
Severity: wishlist

Here are some of the patches I have received while being maintainer
of the websec package. For completeness, I am submitting them to the BTS.


Return-Path: eperez@dei.inf.uc3m.es
Return-Path: <eperez@dei.inf.uc3m.es>
X-XS4ALL-To: <pa4tu@maildrop.xs4all.nl>
Received: from mxzilla2.xs4all.nl (mxzilla2.xs4all.nl [194.109.6.50])
	by maildrop8.xs4all.nl (8.11.6/8.11.1) with ESMTP id g6NBPRR98395
	for <pa4tu@maildrop.xs4all.nl>; Tue, 23 Jul 2002 13:25:27 +0200 (CEST)
	(envelope-from eperez@dei.inf.uc3m.es)
Received: from master.debian.org (master.debian.org [65.125.64.135])
	by mxzilla2.xs4all.nl (8.12.3/8.12.3) with ESMTP id g6NBPQk7013681
	for <pa4tu@xs4all.nl>; Tue, 23 Jul 2002 13:25:27 +0200 (CEST)
Received: from smtp01.uc3m.es (smtp.uc3m.es) [163.117.136.121] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 17WxnC-0004E2-00; Tue, 23 Jul 2002 06:25:26 -0500
Received: from smtp01.uc3m.es (localhost [127.0.0.1])
	by smtp.uc3m.es (Postfix) with ESMTP id A38FD431AF
	for <pa3aba@debian.org>; Tue, 23 Jul 2002 13:25:21 +0200 (CEST)
Received: from localhost.localdomain (cucaracha.it.uc3m.es [163.117.140.53])
	by smtp01.uc3m.es (Postfix) with SMTP id 692D299E06
	for <pa3aba@debian.org>; Tue, 23 Jul 2002 13:25:21 +0200 (CEST)
Date: Tue, 23 Jul 2002 11:25:49 +0000
From: eperez@dei.inf.uc3m.es
To: pa3aba@debian.org
Subject: debian: websec: patches
Message-ID: <20020723112549@localhost.localdomain>
Mime-Version: 1.0
Content-Type: multipart/mixed;
  boundary="UugvWAfsgieZRqgk"
Content-Disposition: inline
Status: RO
X-Status: A


--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: 

Hi,

Here are some patches I use with websec, apply the ones you want.

websec_default_url_list_fix.diff
There is no need to use ~/.websec//url.list
with ~/.websec/url.list is sufficient
this is why no one recommends variable expansion in strings

websec_iso8601.diff
Using ISO8601 standard date/format as a default is a good idea and a
must for Debian packages
http://www.cl.cam.ac.uk/~mgk25/iso-time.html

websec_nodateinsubject.diff
There's no need to put the date at all in the subject as the email has a date
header.

websec_notdiscriminantuseragent.diff
I tend to use a more general user agent as some sites I check with
websec don't like robots.

Regards,

                Eduardo

--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="websec_default_url_list_fix.diff"
Subject: 

--- websec~
+++ websec
@@ -77,7 +77,7 @@
 # Default return code
 $rc = 0;
 
-open ARGV, "$base/url.list" unless exists $ARGV[0];
+open ARGV, $base . "url.list" unless exists $ARGV[0];
 
 # Loop through input file and process all sites listed
 while(<>)

--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="websec_iso8601.diff"
Subject: 

--- websec~
+++ websec
@@ -35,7 +35,7 @@
 print "By Chew Wei Yih Copyleft (c) 1998\n\n";
 
 # Get today's date in the format we want.
-$today = strftime "%d %B %Y (%a)", localtime;
+$today = strftime "%Y-%m-%d", gmtime;
 
 # Prepare pathnames.
 $base= $ENV{HOME} . "/.websec/";

--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="websec_nodateinsubject.diff"
Subject: 

--- websec~
+++ websec
@@ -28,15 +28,11 @@
 #################################################################################
 
 use LWP::UserAgent;
-use POSIX qw(strftime);
 
 # Print introduction
 print "Web Secretary Ver 1.3.4\n";
 print "By Chew Wei Yih Copyleft (c) 1998\n\n";
 
-# Get today's date in the format we want.
-$today = strftime "%d %B %Y (%a)", localtime;
-
 # Prepare pathnames.
 $base= $ENV{HOME} . "/.websec/";
 $archive = "archive/";
@@ -112,7 +108,7 @@
 if (@digest)
 {
     $linkmsg = "The contents of the following URLs have changed:\n\n" . join("\n",@digest) . "\n";
-    $subj = "[websec] - $today";
+    $subj = "[websec]";
     &MailMessage($linkmsg, $subj, $digestEmail);
 }
 
@@ -195,7 +191,7 @@
     $page_previousExists = 1;
     open(FILE, $page_previous) or $page_previousExists = 0;
     close(FILE);
-    $subj = "$addsubject $name - $today";
+    $subj = "$addsubject $name";
     $webdiff =
         "webdiff -archive $page_previous -current $page_current -out $outgoing " .
         "-hicolor $hicolor -ignore $ignore -ignoreurl $ignoreurl -tmin $tmin -tmax $tmax";

--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="websec_notdiscriminantuseragent.diff"
Subject: 

--- websec~
+++ websec
@@ -202,7 +202,7 @@
 
     # Download URL using LWP
     $ua = new LWP::UserAgent;
-    $ua->agent("websec/1.0");
+    $ua->agent("Mozilla/4.0 (compatible; MSIE 5.0; Windows 98; DigExt)");
     $ua->timeout($timeout);
     $ua->env_proxy;
     if ($proxy ne "") { $ua->proxy(http => $proxy); }

--UugvWAfsgieZRqgk--


Regards,
Joop
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux pc3 2.4.19 #1 di aug 13 23:40:19 CEST 2002 i686 AMD Athlon(tm) Processor AuthenticAMD GNU/Linux

Versions of the packages websec depends on:
ii  libwww-perl    5.65-0.1       WWW client/server library for Perl
ii  perl           5.8.0-13       Larry Wall's Practical Extraction and Report



Reply to: