[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#138822: marked as done (Bad filename output)



Your message dated Fri, 29 Mar 2002 11:32:18 -0500
with message-id <E16qzIY-0003nc-00@auric.debian.org>
and subject line Bug#138822: fixed in playmidi 2.4-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Mar 2002 00:33:45 +0000
>From seneca@slemish.com Sun Mar 17 18:33:45 2002
Return-path: <seneca@slemish.com>
Received: from fep02-mail.bloor.is.net.cable.rogers.com [66.185.86.72] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 16ml5s-00027a-00; Sun, 17 Mar 2002 18:33:44 -0600
Received: from IBM01 ([24.101.91.83])
          by fep02-mail.bloor.is.net.cable.rogers.com
          (InterMail vM.5.01.04.06 201-253-122-122-106-20020109) with ESMTP
          id <20020318003313.JDJI8307.fep02-mail.bloor.is.net.cable.rogers.com@IBM01>
          for <submit@bugs.debian.org>; Sun, 17 Mar 2002 19:33:13 -0500
From: "Seneca Cunningham" <seneca@slemish.com>
To: <submit@bugs.debian.org>
Subject: Bad filename output
Date: Sun, 17 Mar 2002 19:33:48 -0500
Message-ID: <NFBBJBMFILNNFOMKFGFBIEFMCJAA.seneca@slemish.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0)
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2615.200
X-Authentication-Info: Submitted using SMTP AUTH LOGIN at fep02-mail.bloor.is.net.cable.rogers.com from [24.101.91.83] using ID <seneca-cunningham@rogers.com> at Sun, 17 Mar 2002 19:33:12 -0500
Delivered-To: submit@bugs.debian.org

Package: playmidi
Version: 2.4-3

If a file with a long (> COLS - 53) name is next to a file with long
karaoke text in a playlist, when running playmidi -r, the last line of
karaoke text appears as the line under the filename.

diff -ur playmidi-2.4.orig/io_ncurses.c playmidi-2.4/io_ncurses.c
--- playmidi-2.4.orig/io_ncurses.c	Sat Mar 16 23:11:55 2002
+++ playmidi-2.4/io_ncurses.c		Sun Mar 17 18:59:14 2002
@@ -311,6 +311,8 @@
 	    mvprintw(i + 2, 0, "Channel %2d  ³", i + 1);
 	tmp = strrchr(filename, '/');
 	strncpy(textbuf, (tmp == NULL ? filename : tmp + 1), COLS - 53);
+	if (strlen(textbuf) > COLS - 53)
+	    textbuf[COLS - 53] = '\0';
 	attrset(A_BOLD);
 	mvaddstr(0, 53, textbuf);
 	mvaddch(1, 41, 'P');

textbuf is used for the output of karaoke text in addition to the
filename, but is not cleared after use. Originally, when the file has a
long name, '\0' is not appended to the end of the copied segment by
strncpy, so it is the null at the end of the old karaoke text that forms
the end of the "filename". The changes check the length of the
"filename", and if it's too long, it appends a null to where the end is
meant to be.

Kernel: 2.4.19-pre3
glibc:  2.2.5-3

libncurses5 version:	5.2.20020112a-3
libxaw7 version:		4.1.0-13
svgalibg1 version:		1.4.3-4
xlibs version:		4.1.0-13
debconf version:		1.0.25

Seneca
seneca@slemish.com


---------------------------------------
Received: (at 138822-close) by bugs.debian.org; 29 Mar 2002 16:45:17 +0000
>From katie@auric.debian.org Fri Mar 29 10:45:17 2002
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] (mail)
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 16qzV7-0008FF-00; Fri, 29 Mar 2002 10:45:17 -0600
Received: from katie by auric.debian.org with local (Exim 3.12 1 (Debian))
	id 16qzIY-0003nc-00; Fri, 29 Mar 2002 11:32:18 -0500
From: Colin Watson <cjwatson@debian.org>
To: 138822-close@bugs.debian.org
X-Katie: $Revision: 1.10 $
Subject: Bug#138822: fixed in playmidi 2.4-4
Message-Id: <E16qzIY-0003nc-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Fri, 29 Mar 2002 11:32:18 -0500
Delivered-To: 138822-close@bugs.debian.org

We believe that the bug you reported is fixed in the latest version of
playmidi, which is due to be installed in the Debian FTP archive:

playmidi_2.4-4.diff.gz
  to pool/main/p/playmidi/playmidi_2.4-4.diff.gz
playmidi_2.4-4.dsc
  to pool/main/p/playmidi/playmidi_2.4-4.dsc
playmidi_2.4-4_i386.deb
  to pool/main/p/playmidi/playmidi_2.4-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 138822@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated playmidi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 29 Mar 2002 16:11:20 +0000
Source: playmidi
Binary: playmidi
Architecture: source i386
Version: 2.4-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 playmidi   - MIDI player
Closes: 130084 137678 138822 138993
Changes: 
 playmidi (2.4-4) unstable; urgency=low
 .
   * QA upload.
   * Add German debconf translation (thanks, Sebastian Feltel and Christian
     Kurz; closes: #130084).
   * Add Russian debconf translation (thanks, Ilgiz Kalmetev;
     closes: #137678).
   * Seneca Cunningham:
     - Null-terminate filenames in playlist display (closes: #138822).
     - Use line-drawing functions rather than box-drawing characters for
       better display in xterms (closes: #138993).
Files: 
 f1668c0bd0b28d0f45e02374194c8d2e 712 sound optional playmidi_2.4-4.dsc
 4e1394cc45463b1df253b0b99e54cd5f 10768 sound optional playmidi_2.4-4.diff.gz
 73e8ef0a6423e9003cf15052e8d56fe2 152364 sound optional playmidi_2.4-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iD8DBQE8pJOb9t0zAhD6TNERAo2IAJ9xuXVCFZutyRbJw3huuPEVa6nMKQCfQJbT
dR6eVhzyMKUWMEeWxPvjmjY=
=YcqU
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to debian-qa-packages-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org



Reply to: