[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#126654: circlepack: Missing malloc() prototype could cause segfaults on ia64

Package: circlepack
Version: N/A; reported 2001-12-27
Severity: normal
Tags: patch

Unprototyped functions are presumed to return 32-bit integers;
on ia64, pointers occupy 64 bits, and can be corrupted without
a prototype.

There are over 200 unprototyped functions in the circlepack
source, but malloc is the only one I've identified as returning
a 64-bit value.

diff -aur circlepack.orig/sph_math.c circlepack-4.0.1/sph_math.c
--- circlepack.orig/sph_math.c  Tue Jan  6 16:42:23 1998
+++ circlepack-4.0.1/sph_math.c Thu Dec 27 16:40:54 2001
@@ -4,6 +4,7 @@
 #include <stdio.h>
 #include <math.h>
+#include <stdlib.h>  /* malloc(3) */
 #include "complex_math.h"
 #include "hyp_math.h"
 #include "eucl_math.h"

-- System Information
Debian Release: 3.0
Architecture: ia64
Kernel: Linux butthead.progeny.com 2.4.9-itanium-smp #1 SMP Mon Sep 17 20:48:35 MDT 2001 ia64
Locale: LANG=en_US, LC_CTYPE=en_US

Reply to: