[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: python-lsp-server new upstream version



Hi Aeliton,

thanks for working on this. python-lsp-server is version locked by python3-spyder and needs coordination with Julian (Cc).

@Julian: can we get a new version in?

* Aeliton G. Silva <aeliton@aeliton.com> [2025-11-21 06:06]:
I managed to create a working package for python-lsp-server using the
upstream version 1.13.2 and I'd like to check if everything looks good.

According to [1] the next steps would be:

$ git push origin : --tags

but I'm not sure I should do that before any of the maintainers have a
look at what I did.

quoting form the wiki:

| Once you've built and uploaded your package,

Note the "uploaded" (to the Debian archive). So you should not tag.

From 9dabd3961d8e2383cfdbb58620fa41e2dc0ea0d4 Mon Sep 17 00:00:00 2001
From: Aeliton Silva <aeliton@aeliton.com>
Date: Fri, 21 Nov 2025 05:14:56 -0300
Subject: [PATCH 6/7] Add python3-websockets as build dependency

---
debian/control | 1 +
1 file changed, 1 insertion(+)

diff --git a/debian/control b/debian/control
index 9d9d026..e18920f 100644
--- a/debian/control
+++ b/debian/control
@@ -28,6 +28,7 @@ Build-Depends: black,
               python3-setuptools,
               python3-setuptools-scm,
               python3-ujson,
+               python3-websockets,

Can you test if this is a test only dependency and can be annotated with <!nocheck>?

From acbc33166e43dae829175d1ddd54bc6cc831be67 Mon Sep 17 00:00:00 2001
From: Aeliton Silva <aeliton@aeliton.com>
Date: Fri, 21 Nov 2025 05:14:11 -0300
Subject: [PATCH 4/7] Add black as a build dependency

---
debian/control | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index b052494..e012904 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,8 @@ Maintainer: Debian Python Team <team+python@tracker.debian.org>
Uploaders: Pablo Mestre Drake <pmdcuba@gmail.com>,
           Julian Gilbey <jdg@debian.org>,
           Jochen Sprickerhof <jspricke@debian.org>
-Build-Depends: debhelper-compat (= 13),
+Build-Depends: black,

Dito here.

From bdc87285ab9a12b6e06d858de93e287aadc09cde Mon Sep 17 00:00:00 2001
From: Aeliton Silva <aeliton@aeliton.com>
Date: Fri, 21 Nov 2025 05:12:09 -0300
Subject: [PATCH 3/7] Skip test that hangs

---
.../0004-Disable-test-that-hangs.patch        | 21 +++++++++++++++++++
debian/patches/series                         |  1 +
2 files changed, 22 insertions(+)
create mode 100644 debian/patches/0004-Disable-test-that-hangs.patch

diff --git a/debian/patches/0004-Disable-test-that-hangs.patch b/debian/patches/0004-Disable-test-that-hangs.patch
new file mode 100644
index 0000000..d2b417d
--- /dev/null
+++ b/debian/patches/0004-Disable-test-that-hangs.patch
@@ -0,0 +1,21 @@
+From: Aeliton Silva <aeliton@aeliton.com>
+Date: Fri, 21 Nov 2025 03:32:11 -0300
+Subject: Disable test that hangs
+
+---
+ test/test_language_server.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/test_language_server.py b/test/test_language_server.py
+index 9b36211..2b41ba9 100644
+--- a/test/test_language_server.py
++++ b/test/test_language_server.py
+@@ -77,7 +77,7 @@ def test_not_exit_without_check_parent_process_flag(
+ + + @flaky(max_runs=10, min_passes=1)
+-@pytest.mark.skipif(RUNNING_IN_CI, reason="This test is hanging on CI")
++@pytest.mark.skip(reason="This test is hanging on CI")
+ def test_missing_message(client_server_pair) -> None:

Please add the test in d/rules instead.

Cheers Jochen

Attachment: signature.asc
Description: PGP signature


Reply to: