[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

review for python-can/4.6.1-1



hi Carl,

I took a look at the python-can package, up for sponsorship in the
Python team:

* copyright: missing info (copyright holder) for:
  can/interfaces/ixxat/exceptions.py:5:Copyright (C) 2019 Marcel Kanter <marcel.kanter@googlemail.com>

* manpages: example commands use 'python' (= long gone python v2)
  rather than 'python3' for the interpreter.

* rules: weird indent for PYTEST_ADDOPTS (2nd and 3rd line appear
  very far off to the right?).

* rules: is that (manual) licensecheck target still useful enough to
  keep around in the day and age of CI/licenserecon?


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

Attachment: pgpPEvmsRKTLX.pgp
Description: OpenPGP digital signature


Reply to: