[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: review for python-atom/0.11.0-1

Hi Jeroen,

thanks for the quick and detailed review.

On 9/29/25 18:17, Jeroen Ploemen wrote:

* diff between orig tarball from uscan and pristine-tar branch
   (output from tardiff -m -s):
   + PKG-INFO
   + atom.egg-info
   + atom.egg-info/PKG-INFO
   + atom.egg-info/SOURCES.txt
   + atom.egg-info/dependency_links.txt
   + atom.egg-info/requires.txt
   + atom.egg-info/top_level.txt
   + atom/version.py
   + setup.cfg
I do not know how that could happen. Maybe I started the package with the pypi distribution tar. I recreated the repo (and the pristine-tar) branch from the uscan information. 


* control: possible missing build-dep on python3-psutil, (optional)
   import at tests/test_mem.py:21


Thanks for catching this, dependency added.
I added (and forwarded to upstream) a patch to fix a type hint error while building the documentation and added the examples to pybuild.testfiles. Now all tests are run and only one tests is skipped intentionally. 


* control: version requirements for the build-deps on
   python3-setuptools, python3-setuptools-scm, python3-cppy are
   ancient (already met in oldstable), please remove.


Removed.


* d/.docs, d/.examples: files could be moved to the documentation pkg?
Done. As the examples are already referenced in the generated sphinx documentation, I added jdupes to link the same files. Keeping the examples under /usr/share/doc/python-atom-doc/examples/ might improve the discoverability. 


* rules: override of dh_sphinxdoc might ignore nodoc build profile.


Fixed.



I assume the initial upload was rejected over missing copyright info?
Yes. Once the new upload is sponsored I would reply to the ftpmasters, that the issues in the copyright file are fixed. 


Thanks,
Alex

Attachment: OpenPGP_0x0BD13B63E2A9AF58.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply to: