Hi Jeroen, Thank you for your review!
I took a look at the python-leather package up for sponsorship in the
Python team. Some issues came up during review:
* possible unused build-deps on python3-six, -doc, dpkg-dev;
* build-dep on furo could be marked !nodoc;
* build-dep on sphinx-common is redundant, already a dependency of
python3-sphinx.
* examples are probably better installed into the documentation pkg > > * python3-leather suggests doc pkg with a build profile included
("<!nodoc>"; copy/paste error?);
All of the above suggestions have been completed and pushed to salsa. Changing the installation of examples generates lintian experimental warnings for duplicate files, so those files have been removed.
* doc package has a useless suggested dependency on itself.
This change is also pushed to salsa. It was part of the initial packaging for Debian, so I am surprised it has gone this long unnoticed.
* lintian hit: W: python3-colormap: debian-changelog-line-too-long [usr/share/doc/python3-colormap/changelog.Debian.gz:7]
This lintian warning looks like it is for a different package, python3-colormap.
Please let me know your thoughts and if any changes should be made! Best, -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354
Attachment:
OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature