[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

review for riscemu/2.2.5-1



hi Bo,

I took a look at the riscemu package, put up for sponsorship in the
Python team. Some (mostly minor) issues came up:

* copyright:
  + upstream years are incorrect (license file, sources have 2021-2022
    resp. 2023).
  + leftover boilerplate comments.
  + empty line (dot) at the start of the license paragraph.

* control:
  + no need to mention -doc/-examples pkgs in the long description,
    that's what a suggested dependency is for.
  + tiny (< 10kB) examples package is probably best merged into the
    documentation package.

* rules:
  + weird comment at the top of the file (leftover TODO?).
  + variables for doc and example dirs defined but not used?
  + documentation dir /usr/share/doc/riscemu-doc/; did you mean
    /usr/share/doc/riscemu/?

* d/riscemu-examples.install used for examples; these should be
  handled by dh_installexamples instead.

* lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].

Attachment: pgptwWyKUbyG2.pgp
Description: OpenPGP digital signature


Reply to: