[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

review for kivy/2.1.0-1



hi Dean,

I reviewed the kivy package up for sponsorship in the Python team:

* There's quite a few lintian hits [1], and most of those look legit.
  Please fix the correctly identified issues, and add overrides for
  any false positives.

* In the changelog, you should mention this is a team upload;
  otherwise (with you not listed as either maintainer or uploader) it
  looks like an NMU.

* The copyright file is missing many entries, including:
doc/sources/.static/jquery.cookie.js:6: * Copyright (c) 2010 Klaus Hartl (stilbuero.de)
doc/sources/.static/jquery-effects-core-and-slide.js:4: * Copyright 2011, AUTHORS.txt (http://jqueryui.com/about)
doc/sources/.static/jquery-effects-core-and-slide.js:736: * Copyright 2001 Robert Penner
kivy/lib/kivy_endian.h:3:  Copyright (C) 1997-2018 Sam Lantinga
kivy/lib/sdl2.pxi:1:#Copyright (c) 2010-2012, Gabriel Jacobo
kivy/lib/libtess2/Source/...:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/lib/libtess2/Include/tesselator.h:3:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/tools/pep8checker/pep8.py:4:# Copyright (C) 2006-2009 Johann C. Rocholl
kivy/tools/pep8checker/pep8.py:5:# Copyright (C) 2009-2014 Florent Xicluna
kivy/tools/pep8checker/pep8.py:6:# Copyright (C) 2014-2016 Ian Lee


Once fixed, simply add the package back to the RFS list in the IRC
channel topic.


[1] https://salsa.debian.org/python-team/packages/kivy/-/jobs/3617039

Attachment: pgpoOyMmnrtgu.pgp
Description: OpenPGP digital signature


Reply to: