Hi Étienne, * Étienne Mollier <emollier@emlwks999.eu> [2022-12-04 12:46]:
I'm a DD, but since this is my first DPT package, I wouldn't be against having a second pair of eyeballs having a look at the python-pyglfw package I produced this morning[1]. The packaging in itself was super smooth, I just wanted to make sure I didn't miss team specific bits; I had the policy and guide under the eyes while packaging, but one never knows. [1]: https://salsa.debian.org/python-team/packages/python-pyglfw
- You forgot to push the upstream and pristine-tar branches, the upstream/2.5.5+dfsg tag, and you should set "debian-branch = debian/master" in d/gbp.conf - I think the package can be arch:all, as the package will be identical an all architectures, with all architecture-specific bits hidden behind the ctypes indirection. - The "Build-Depends: libglfw3 <!nocheck>" seems unnecessary, because AFAICT, there is no test suite in the package at all. - There is no "Testsuite: autopkgtest-pkg-python" in d/control. I'm really not sure if this is an issue, because I usually have more intrusive tests and seldomly rely on the default one. Besides, you did add a config in d/tests, which may also suffice? I really don't know, but wanted to mention it just in case. - I've never set LC_ALL in d/rules. Is there a particular reason why it is necessary? - Personally, I prefer having dh-sequence-python3 in Build-Depends, so I don't have to add --with python3 in d/rules. Everything else looks good to me, with the caveat that I did not actually test-build the package, because of the missing pushes. Oh, and welcome to the team, nice to have you here! Cheers Timo -- ⢀⣴⠾⠻⢶⣦⠀ ╭────────────────────────────────────────────────────╮ ⣾⠁⢠⠒⠀⣿⡁ │ Timo Röhling │ ⢿⡄⠘⠷⠚⠋⠀ │ 9B03 EBB9 8300 DF97 C2B1 23BF CC8C 6BDD 1403 F4CA │ ⠈⠳⣄⠀⠀⠀⠀ ╰────────────────────────────────────────────────────╯
Attachment:
signature.asc
Description: PGP signature