[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: review for python-ssdpy



On Mon, 3 Oct 2022 11:56:30 -0400
Ben Westover <kwestover.kw@gmail.com> wrote:

> Thanks, I didn't catch that since I use sbuild instead of pbuilder.
> I have set the environment variable CI = true which should disable
> those tests.

Unfortunately, it doesn't.

The change suggested below does make 'CI=true' take effect, but that
still leaves a few failing tests not marked by upstream. Probably
easiest to exclude those remaining troublemakers by instructing
pybuild to set a pytest option, e.g. PYBUILD_TEST_ARGS = -k 'not ...'.

--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,6 @@
 #! /usr/bin/make -f
 
 export PYBUILD_NAME = ssdpy
-export CI = "true" # Skip tests which require network
 
 %:
        dh $@ --with python3,sphinxdoc --buildsystem=pybuild
@@ -11,3 +10,7 @@ execute_after_dh_auto_build:
 
 execute_after_dh_auto_clean:
        rm -rf debian/html
+
+override_dh_auto_test:
+       # Skip tests which require network
+       CI=true dh_auto_test

Attachment: pgp9ZbC3Yi9TW.pgp
Description: OpenPGP digital signature


Reply to: